Patchwork Protection against ever-more-talented fools...

login
register
mail settings
Submitter Peter Seebach
Date May 9, 2012, 7:20 p.m.
Message ID <20120509142007.528ca609@wrlaptop>
Download mbox | patch
Permalink /patch/27385/
State Accepted
Commit ac4201b714c83c614113bfa735d0a2fc6f64db99
Headers show

Comments

Peter Seebach - May 9, 2012, 7:20 p.m.
Time for some shell trivia!

Trivia point:  PATH=:/usr/bin and PATH=.:/usr/bin are equivalent.
Trivia point:  So are PATH=/bin::/usr/bin and PATH=/bin:.:/usr/bin
Trivia point:  People love to write stuff like:
  PATH=$(THAT_DIRECTORY):$PATH
Trivia point:  The shell expands undefined variables to empty strings.

Which is to say:
Richard Purdie - May 9, 2012, 7:49 p.m.
On Wed, 2012-05-09 at 14:20 -0500, Peter Seebach wrote:
> Time for some shell trivia!
> 
> Trivia point:  PATH=:/usr/bin and PATH=.:/usr/bin are equivalent.
> Trivia point:  So are PATH=/bin::/usr/bin and PATH=/bin:.:/usr/bin
> Trivia point:  People love to write stuff like:
>   PATH=$(THAT_DIRECTORY):$PATH
> Trivia point:  The shell expands undefined variables to empty strings.
> 
> Which is to say:

I like the patch and I can live with the commit message but could we
have the right subject line and a signed-off-by please? :)

Cheers,

Richard
Peter Seebach - May 9, 2012, 8:07 p.m.
On Wed, 9 May 2012 20:49:23 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> I like the patch and I can live with the commit message but could we
> have the right subject line and a signed-off-by please? :)

Heh.  I hadn't actually intended this as a pull request, just
commentary, but I can do a proper pull request with a meaningful
subject, commit message, etc.

-s

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 687ddeb..1384592 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -298,8 +298,9 @@  def check_sanity(e):
         if not check_app_exists("qemu-arm", e.data):
             messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
 
-    if "." in data.getVar('PATH', e.data, True).split(":"):
-        messages = messages + "PATH contains '.' which will break the build, please remove this"
+    paths = data.getVar('PATH', e.data, True).split(":")
+    if "." in paths or "" in paths:
+        messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
 
     if data.getVar('TARGET_ARCH', e.data, True) == "arm":
         # This path is no longer user-readable in modern (very recent) Linux