Patchwork [3/3] kmod: Use base_libdir for installing libkmod

login
register
mail settings
Submitter Khem Raj
Date May 8, 2012, 10:53 p.m.
Message ID <9f0168b7a33fbfe7920ee449f4cc34d4ba09ea17.1336517492.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/27317/
State Accepted
Commit 6b74f2461735272bd950a4f060dab6e778a36f92
Headers show

Comments

Khem Raj - May 8, 2012, 10:53 p.m.
This also helps avoid QA errors about binaries
accessing contents from /usr/lib

Also fixes emptry libkmod problem since now
the files are installed in expected place

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-kernel/kmod/kmod_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Koen Kooi - May 11, 2012, 12:47 p.m.
Op 9 mei 2012, om 00:53 heeft Khem Raj het volgende geschreven:

> This also helps avoid QA errors about binaries
> accessing contents from /usr/lib
> 
> Also fixes emptry libkmod problem since now
> the files are installed in expected place
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-kernel/kmod/kmod_git.bb |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
> index 4c860f0..fed068f 100644
> --- a/meta/recipes-kernel/kmod/kmod_git.bb
> +++ b/meta/recipes-kernel/kmod/kmod_git.bb
> @@ -16,7 +16,7 @@ RCONFLICTS_libkmod2 += "module-init-tools-insmod-static module-init-tools-depmod
> # autotools set prefix to /usr, however we want them in /bin and /sbin
> bindir = "${base_bindir}"
> sbindir = "${base_sbindir}"
> -# libdir = "${base_libdir}"
> +libdir = "${base_libdir}"

That breaks udev because the .pc is in the wrong place:

[koen@revo Angstrom]$ tar ztvf build/sstate-cache/sstate-kmod-armv7a-angstrom-linux-gnueabi-8-r0.1-armv7a-2-183860d867b80d514ca2f42ac90501a4_populate-sysroot.tgz
[..]
-rw-r--r-- koen/koen       205 2012-05-10 23:31 lib/pkgconfig/libkmod.pc

Patch

diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index 4c860f0..fed068f 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -16,7 +16,7 @@  RCONFLICTS_libkmod2 += "module-init-tools-insmod-static module-init-tools-depmod
 # autotools set prefix to /usr, however we want them in /bin and /sbin
 bindir = "${base_bindir}"
 sbindir = "${base_sbindir}"
-# libdir = "${base_libdir}"
+libdir = "${base_libdir}"
 
 do_install_append () {
         install -dm755 ${D}${base_bindir}