Patchwork [2/3] kmod: Update to .8 release

login
register
mail settings
Submitter Khem Raj
Date May 8, 2012, 10:53 p.m.
Message ID <339076a9cf1ef906416bd850e5825c3bb8521983.1336517492.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/27315/
State New
Headers show

Comments

Khem Raj - May 8, 2012, 10:53 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-kernel/kmod/kmod.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Koen Kooi - May 9, 2012, 5:31 a.m.
Op 9 mei 2012, om 00:53 heeft Khem Raj het volgende geschreven:

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-kernel/kmod/kmod.inc |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
> index 681e52b..70d376e 100644
> --- a/meta/recipes-kernel/kmod/kmod.inc
> +++ b/meta/recipes-kernel/kmod/kmod.inc
> @@ -7,7 +7,7 @@ HOMEPAGE = "http://packages.profusion.mobi/kmod/"
> LICENSE = "GPL-2.0+ & LGPL-2.1+"
> LICENSE_libkmod = "LGPL-2.1+"
> SECTION = "base"
> -PV = "7+git${SRCREV}"
> +PV = "8+git${SRCREV}"

Drop the +git$SRCREV, it's a release.
Martin Jansa - May 9, 2012, 9:42 a.m.
On Wed, May 09, 2012 at 07:31:52AM +0200, Koen Kooi wrote:
> 
> Op 9 mei 2012, om 00:53 heeft Khem Raj het volgende geschreven:
> 
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/recipes-kernel/kmod/kmod.inc |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
> > index 681e52b..70d376e 100644
> > --- a/meta/recipes-kernel/kmod/kmod.inc
> > +++ b/meta/recipes-kernel/kmod/kmod.inc
> > @@ -7,7 +7,7 @@ HOMEPAGE = "http://packages.profusion.mobi/kmod/"
> > LICENSE = "GPL-2.0+ & LGPL-2.1+"
> > LICENSE_libkmod = "LGPL-2.1+"
> > SECTION = "base"
> > -PV = "7+git${SRCREV}"
> > +PV = "8+git${SRCREV}"
> 
> Drop the +git$SRCREV, it's a release.

Agreed, this should be 
8+git${SRCPV}
or no +git at all.

But other than that, this patchset looks good:
Tested-by: Martin Jansa <Martin.Jansa@gmail.com>
Khem Raj - May 9, 2012, 3:42 p.m.
On Wed, May 9, 2012 at 2:42 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, May 09, 2012 at 07:31:52AM +0200, Koen Kooi wrote:
>>
>> Op 9 mei 2012, om 00:53 heeft Khem Raj het volgende geschreven:
>>
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> > meta/recipes-kernel/kmod/kmod.inc |    4 ++--
>> > 1 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
>> > index 681e52b..70d376e 100644
>> > --- a/meta/recipes-kernel/kmod/kmod.inc
>> > +++ b/meta/recipes-kernel/kmod/kmod.inc
>> > @@ -7,7 +7,7 @@ HOMEPAGE = "http://packages.profusion.mobi/kmod/"
>> > LICENSE = "GPL-2.0+ & LGPL-2.1+"
>> > LICENSE_libkmod = "LGPL-2.1+"
>> > SECTION = "base"
>> > -PV = "7+git${SRCREV}"
>> > +PV = "8+git${SRCREV}"
>>
>> Drop the +git$SRCREV, it's a release.

it does have 2 commits on top of .8 so  I have changed SRCREV to SRCPV
and updated the pull tree.

>
> Agreed, this should be
> 8+git${SRCPV}
> or no +git at all.
>
> But other than that, this patchset looks good:
> Tested-by: Martin Jansa <Martin.Jansa@gmail.com>
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Koen Kooi - May 9, 2012, 4:28 p.m.
Op 9 mei 2012, om 17:42 heeft Khem Raj het volgende geschreven:

> On Wed, May 9, 2012 at 2:42 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Wed, May 09, 2012 at 07:31:52AM +0200, Koen Kooi wrote:
>>> 
>>> Op 9 mei 2012, om 00:53 heeft Khem Raj het volgende geschreven:
>>> 
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> meta/recipes-kernel/kmod/kmod.inc |    4 ++--
>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
>>>> index 681e52b..70d376e 100644
>>>> --- a/meta/recipes-kernel/kmod/kmod.inc
>>>> +++ b/meta/recipes-kernel/kmod/kmod.inc
>>>> @@ -7,7 +7,7 @@ HOMEPAGE = "http://packages.profusion.mobi/kmod/"
>>>> LICENSE = "GPL-2.0+ & LGPL-2.1+"
>>>> LICENSE_libkmod = "LGPL-2.1+"
>>>> SECTION = "base"
>>>> -PV = "7+git${SRCREV}"
>>>> +PV = "8+git${SRCREV}"
>>> 
>>> Drop the +git$SRCREV, it's a release.
> 
> it does have 2 commits on top of .8 so  I have changed SRCREV to SRCPV
> and updated the pull tree.

Please drop the SRCPV, it's version '8', not 8+giter8735827548237582758293
Khem Raj - May 9, 2012, 6:49 p.m.
On Wed, May 9, 2012 at 9:28 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Please drop the SRCPV, it's version '8', not 8+giter8735827548237582758293

Alright. Done.

Patch

diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
index 681e52b..70d376e 100644
--- a/meta/recipes-kernel/kmod/kmod.inc
+++ b/meta/recipes-kernel/kmod/kmod.inc
@@ -7,7 +7,7 @@  HOMEPAGE = "http://packages.profusion.mobi/kmod/"
 LICENSE = "GPL-2.0+ & LGPL-2.1+"
 LICENSE_libkmod = "LGPL-2.1+"
 SECTION = "base"
-PV = "7+git${SRCREV}"
+PV = "8+git${SRCREV}"
 INC_PR = "r0"
 DEPENDS += "gnome-doc-utils-native"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
@@ -20,7 +20,7 @@  SRC_URI = "git://git.profusion.mobi/kmod.git;protocol=git;branch=master \
            file://0001-man-disable-man-page-generation-because-we-don-t-hav.patch \
           "
 
-SRCREV = "02629fa02e96763db7460a930239cc93649a52f8"
+SRCREV = "819f79a24d58e3c8429f1631df2f8f85a2f95d4a"
 
 S = "${WORKDIR}/git"