| Message ID | 20230712220332.1630850-1-u.oelmann@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] ref-manual: classes: kernel-fitimage: fix variable name | expand |
On Thu, Jul 13 2023 at 00:03 +0200, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote: > The actual code in kernel-fitimage.bbclass checks if "fitImage" is listed in > KERNEL_IMAGETYPES (see e.g. [1]) whereas the class does not use KERNEL_IMAGETYPE > at all. > > [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n9 I just stumbled across [2] in kernel.bbclass where KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE are merged into KERNEL_IMAGETYPES so that my statement in this patch is not correct. Thus, please do not apply this series, I am going to send a v2. Best regards Ulrich [2] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n74 > > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> > --- > documentation/ref-manual/classes.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst > index e555a80b5af9..c3fa9a86966e 100644 > --- a/documentation/ref-manual/classes.rst > +++ b/documentation/ref-manual/classes.rst > @@ -1599,8 +1599,8 @@ an optional :term:`Initramfs` bundle, an optional RAM disk, and any number of > device trees. > > To create a FIT image, it is required that :term:`KERNEL_CLASSES` > -is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPE` > -is set to "fitImage". > +is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPES` > +is set to include "fitImage". > > The options for the device tree compiler passed to ``mkimage -D`` > when creating the FIT image are specified using the
diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst index e555a80b5af9..c3fa9a86966e 100644 --- a/documentation/ref-manual/classes.rst +++ b/documentation/ref-manual/classes.rst @@ -1599,8 +1599,8 @@ an optional :term:`Initramfs` bundle, an optional RAM disk, and any number of device trees. To create a FIT image, it is required that :term:`KERNEL_CLASSES` -is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPE` -is set to "fitImage". +is set to include ":ref:`ref-classes-kernel-fitimage`" and :term:`KERNEL_IMAGETYPES` +is set to include "fitImage". The options for the device tree compiler passed to ``mkimage -D`` when creating the FIT image are specified using the
The actual code in kernel-fitimage.bbclass checks if "fitImage" is listed in KERNEL_IMAGETYPES (see e.g. [1]) whereas the class does not use KERNEL_IMAGETYPE at all. [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n9 Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> --- documentation/ref-manual/classes.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)