Patchwork [meta-oe] kmod: Delete in favor of OE-Core

login
register
mail settings
Submitter Khem Raj
Date May 7, 2012, 7:59 p.m.
Message ID <1336420791-4944-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/27237/
State Superseded, archived
Headers show

Comments

Khem Raj - May 7, 2012, 7:59 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/classes/kernel.bbclass          |    2 +-
 meta-oe/recipes-kernel/kmod/kmod_git.bb |   24 ------------------------
 2 files changed, 1 insertions(+), 25 deletions(-)
 delete mode 100644 meta-oe/recipes-kernel/kmod/kmod_git.bb
Martin Jansa - May 7, 2012, 8:05 p.m.
On Mon, May 07, 2012 at 12:59:51PM -0700, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

We should delete it only after issues reported on oe-core and here in 
"[meta-oe][meta-efl][meta-gpe][PATCH 7/7] kernel.bbclass"
are resolved..

and that kernel.bbclass change seems wrong.. removing depmod from
DEPENDS is not enough.. better to use your patch from oe-core which was
included in my patchset here..

Cheers,

> ---
>  meta-oe/classes/kernel.bbclass          |    2 +-
>  meta-oe/recipes-kernel/kmod/kmod_git.bb |   24 ------------------------
>  2 files changed, 1 insertions(+), 25 deletions(-)
>  delete mode 100644 meta-oe/recipes-kernel/kmod/kmod_git.bb
> 
> diff --git a/meta-oe/classes/kernel.bbclass b/meta-oe/classes/kernel.bbclass
> index 98320fe..81612da 100644
> --- a/meta-oe/classes/kernel.bbclass
> +++ b/meta-oe/classes/kernel.bbclass
> @@ -1,7 +1,7 @@
>  inherit linux-kernel-base module_strip
>  
>  PROVIDES += "virtual/kernel"
> -DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}depmod virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules"
> +DEPENDS += "virtual/${TARGET_PREFIX}gcc kmod-native virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules"
>  
>  # we include gcc above, we dont need virtual/libc
>  INHIBIT_DEFAULT_DEPS = "1"
> diff --git a/meta-oe/recipes-kernel/kmod/kmod_git.bb b/meta-oe/recipes-kernel/kmod/kmod_git.bb
> deleted file mode 100644
> index aae9e7f..0000000
> --- a/meta-oe/recipes-kernel/kmod/kmod_git.bb
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -DESCRIPTION = "kmod - handle kernel modules"
> -
> -LICENSE = "GPLv2"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> -
> -PR = "r3"
> -
> -inherit autotools gitpkgv
> -
> -PKGV = "${GITPKGVTAG}"
> -SRCREV = "8885ced062131214448fae056ef453f094303805"
> -SRC_URI = "git://git.profusion.mobi/kmod.git \
> -           file://0001-man-disable-man-page-generation-because-we-don-t-hav.patch \
> -"
> -
> -S = "${WORKDIR}/git"
> -
> -do_configure_prepend() {
> -	gtkdocize --docdir ${S}/libkmod/docs || touch ${S}/libkmod/docs/gtk-doc.make
> -}
> -
> -PACKAGES =+ "libkmod"
> -FILES_libkmod = "${libdir}/lib*${SOLIBS}"
> -
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/classes/kernel.bbclass b/meta-oe/classes/kernel.bbclass
index 98320fe..81612da 100644
--- a/meta-oe/classes/kernel.bbclass
+++ b/meta-oe/classes/kernel.bbclass
@@ -1,7 +1,7 @@ 
 inherit linux-kernel-base module_strip
 
 PROVIDES += "virtual/kernel"
-DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}depmod virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules"
+DEPENDS += "virtual/${TARGET_PREFIX}gcc kmod-native virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules"
 
 # we include gcc above, we dont need virtual/libc
 INHIBIT_DEFAULT_DEPS = "1"
diff --git a/meta-oe/recipes-kernel/kmod/kmod_git.bb b/meta-oe/recipes-kernel/kmod/kmod_git.bb
deleted file mode 100644
index aae9e7f..0000000
--- a/meta-oe/recipes-kernel/kmod/kmod_git.bb
+++ /dev/null
@@ -1,24 +0,0 @@ 
-DESCRIPTION = "kmod - handle kernel modules"
-
-LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-
-PR = "r3"
-
-inherit autotools gitpkgv
-
-PKGV = "${GITPKGVTAG}"
-SRCREV = "8885ced062131214448fae056ef453f094303805"
-SRC_URI = "git://git.profusion.mobi/kmod.git \
-           file://0001-man-disable-man-page-generation-because-we-don-t-hav.patch \
-"
-
-S = "${WORKDIR}/git"
-
-do_configure_prepend() {
-	gtkdocize --docdir ${S}/libkmod/docs || touch ${S}/libkmod/docs/gtk-doc.make
-}
-
-PACKAGES =+ "libkmod"
-FILES_libkmod = "${libdir}/lib*${SOLIBS}"
-