Patchwork connman: Disable tist plugin on powerpc

login
register
mail settings
Submitter Richard Purdie
Date May 7, 2012, 9:52 a.m.
Message ID <1336384362.23777.71.camel@ted>
Download mbox | patch
Permalink /patch/27211/
State Accepted
Commit 672846b0262add037daa2c9e434fe09388b58da8
Headers show

Comments

Richard Purdie - May 7, 2012, 9:52 a.m.
This plugin doesn't build on powerpc due to powerpc's terminal ioctl defintions
being incompatible with assumptions being made by this module. Until someone has
need and can test this on powerpc, disabling is the safest option.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Koen Kooi - May 7, 2012, 10:03 a.m.
Op 7 mei 2012, om 11:52 heeft Richard Purdie het volgende geschreven:

> This plugin doesn't build on powerpc due to powerpc's terminal ioctl defintions
> being incompatible with assumptions being made by this module. Until someone has
> need and can test this on powerpc, disabling is the safest option.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Acked-by: Koen Kooi <koen@circuitco.com>

> ---
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 8b27cfb..f2da8d9 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -20,6 +20,9 @@ DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
>             ofono \
>             "
> 
> +TIST = "--enable-tist"
> +TIST_powerpc = ""
> +
> EXTRA_OECONF += "\
>     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
>     ac_cv_path_PPPD=${sbindir}/pppd \
> @@ -28,8 +31,8 @@ EXTRA_OECONF += "\
>     --enable-threads \
>     --enable-loopback \
>     --enable-ethernet \
> -    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi --enable-tist', '--disable-wifi', d)} \
> -    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth --enable-tist', '--disable-bluetooth', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>     --enable-dnsproxy \
>     --enable-ofono \
>     --enable-tools \
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 8b27cfb..f2da8d9 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -20,6 +20,9 @@  DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
             ofono \
             "
 
+TIST = "--enable-tist"
+TIST_powerpc = ""
+
 EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
     ac_cv_path_PPPD=${sbindir}/pppd \
@@ -28,8 +31,8 @@  EXTRA_OECONF += "\
     --enable-threads \
     --enable-loopback \
     --enable-ethernet \
-    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi --enable-tist', '--disable-wifi', d)} \
-    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth --enable-tist', '--disable-bluetooth', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
     --enable-dnsproxy \
     --enable-ofono \
     --enable-tools \