Patchwork libpcap: Move pcap-config to -dev package

login
register
mail settings
Submitter Saul Wold
Date May 5, 2012, 12:13 a.m.
Message ID <1336176824-5954-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/27183/
State New
Headers show

Comments

Saul Wold - May 5, 2012, 12:13 a.m.
pcap-config is a tool used for getting the cflags and ln flags for development

[YOCTO #2367]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-connectivity/libpcap/libpcap.inc |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
Koen Kooi - May 5, 2012, 6:57 a.m.
Op 5 mei 2012, om 02:13 heeft Saul Wold het volgende geschreven:

> pcap-config is a tool used for getting the cflags and ln flags for development
> 
> [YOCTO #2367]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/recipes-connectivity/libpcap/libpcap.inc |    7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/libpcap/libpcap.inc b/meta/recipes-connectivity/libpcap/libpcap.inc
> index 427078f..7950b2a 100644
> --- a/meta/recipes-connectivity/libpcap/libpcap.inc
> +++ b/meta/recipes-connectivity/libpcap/libpcap.inc
> @@ -13,7 +13,7 @@ DEPENDS = "flex-native bison-native"
> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluetooth', '', d)}"
> PACKAGECONFIG[bluetooth] = "--enable-bluetooth,--disable-bluetooth,bluez4"
> 
> -INC_PR = "r1"
> +INC_PR = "r2"
> 
> SRC_URI = "http://www.tcpdump.org/release/libpcap-${PV}.tar.gz"
> 
> @@ -30,3 +30,8 @@ do_configure_prepend () {
>         cat aclocal.m4 > acinclude.m4
>     fi
> }
> +
> +# pcap-config is a dev tool and should not be packaged in the 
> +# core package.
> +FILES_${PN} = "${libdir}/lib*${SOLIBS}"
> +FILES_${PN}-dev += "${bindir}"

Change that go ${bindir}/pcap-config to avoid being too greedy during upgrades. Or just inherit 'binconfig' :)
Saul Wold - May 7, 2012, 6:59 a.m.
On 05/04/2012 11:57 PM, Koen Kooi wrote:
>
> Op 5 mei 2012, om 02:13 heeft Saul Wold het volgende geschreven:
>
>> pcap-config is a tool used for getting the cflags and ln flags for development
>>
>> [YOCTO #2367]
>>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>> meta/recipes-connectivity/libpcap/libpcap.inc |    7 ++++++-
>> 1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/libpcap/libpcap.inc b/meta/recipes-connectivity/libpcap/libpcap.inc
>> index 427078f..7950b2a 100644
>> --- a/meta/recipes-connectivity/libpcap/libpcap.inc
>> +++ b/meta/recipes-connectivity/libpcap/libpcap.inc
>> @@ -13,7 +13,7 @@ DEPENDS = "flex-native bison-native"
>> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluetooth', '', d)}"
>> PACKAGECONFIG[bluetooth] = "--enable-bluetooth,--disable-bluetooth,bluez4"
>>
>> -INC_PR = "r1"
>> +INC_PR = "r2"
>>
>> SRC_URI = "http://www.tcpdump.org/release/libpcap-${PV}.tar.gz"
>>
>> @@ -30,3 +30,8 @@ do_configure_prepend () {
>>          cat aclocal.m4>  acinclude.m4
>>      fi
>> }
>> +
>> +# pcap-config is a dev tool and should not be packaged in the
>> +# core package.
>> +FILES_${PN} = "${libdir}/lib*${SOLIBS}"
>> +FILES_${PN}-dev += "${bindir}"
>
> Change that go ${bindir}/pcap-config to avoid being too greedy during upgrades. Or just inherit 'binconfig' :)

It already inherits binconfig!

That does not seem to address which package it gets installed in!

Sau!

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-connectivity/libpcap/libpcap.inc b/meta/recipes-connectivity/libpcap/libpcap.inc
index 427078f..7950b2a 100644
--- a/meta/recipes-connectivity/libpcap/libpcap.inc
+++ b/meta/recipes-connectivity/libpcap/libpcap.inc
@@ -13,7 +13,7 @@  DEPENDS = "flex-native bison-native"
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluetooth', '', d)}"
 PACKAGECONFIG[bluetooth] = "--enable-bluetooth,--disable-bluetooth,bluez4"
 
-INC_PR = "r1"
+INC_PR = "r2"
 
 SRC_URI = "http://www.tcpdump.org/release/libpcap-${PV}.tar.gz"
 
@@ -30,3 +30,8 @@  do_configure_prepend () {
         cat aclocal.m4 > acinclude.m4
     fi
 }
+
+# pcap-config is a dev tool and should not be packaged in the 
+# core package.
+FILES_${PN} = "${libdir}/lib*${SOLIBS}"
+FILES_${PN}-dev += "${bindir}"