Patchwork libmodbus: ported recipe from classic and updated

login
register
mail settings
Submitter Andrea Galbusera
Date May 4, 2012, 9:25 p.m.
Message ID <1336166708-14019-1-git-send-email-gizero@gmail.com>
Download mbox | patch
Permalink /patch/27095/
State Superseded
Headers show

Comments

Andrea Galbusera - May 4, 2012, 9:25 p.m.
* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* also provide an _git version with up-to-date SRCREV and
DEFAULT_PREFERENCE = "-1"
* common part factorized as libmodbus.inc

Signed-off-by: Andrea Galbusera <gizero@gmail.com>
---
 meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
 .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
 3 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
Khem Raj - May 4, 2012, 9:49 p.m.
On Fri, May 4, 2012 at 2:25 PM, Andrea Galbusera <gizero@gmail.com> wrote:
> * based on recipe by Radoslav Kolev which was in classic
> * updated to latest released version 3.0.2
> * also provide an _git version with up-to-date SRCREV and
> DEFAULT_PREFERENCE = "-1"

You should always prefix the subject line with layername e.g.
[meta-oe]... so you get appropriate maintainers attention

Do we really need the git version ? if not then drop it.

> * common part factorized as libmodbus.inc
>
> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
> ---
>  meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
>  .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
>  3 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
>
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus.inc b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
> new file mode 100644
> index 0000000..8e0e011
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
> @@ -0,0 +1,13 @@
> +SUMMARY = "A Modbus library"
> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
> +QNX and Windows."
> +HOMEPAGE = "http://www.libmodbus.org/"
> +SECTION = "libs"
> +PRIORITY = "optional"

PRIORITY is no longer used drop it.

> +LICENSE = "LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
> +
> +INC_PR = "r0"

if you are just having 1 recipe i.e. dropping git recipe then change that
to PR

> +
> +inherit autotools pkgconfig
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> new file mode 100644
> index 0000000..7a99f72
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> @@ -0,0 +1,8 @@
> +require libmodbus.inc
> +
> +PR = "${INC_PR}.0"
> +
> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
> +SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
> new file mode 100644
> index 0000000..793a9d6
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
> @@ -0,0 +1,13 @@
> +require libmodbus.inc
> +
> +SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
> +
> +PV = "3.0.2+gitr${SRCPV}"
> +
> +PR = "${INC_PR}.0"
> +
> +DEFAULT_PREFERENCE = "-1"
> +
> +SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
> +S = "${WORKDIR}/git"
> +
> --
> 1.7.5.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Martin Jansa - May 5, 2012, 4:46 a.m.
On Fri, May 04, 2012 at 11:25:08PM +0200, Andrea Galbusera wrote:
> * based on recipe by Radoslav Kolev which was in classic
> * updated to latest released version 3.0.2
> * also provide an _git version with up-to-date SRCREV and
> DEFAULT_PREFERENCE = "-1"
> * common part factorized as libmodbus.inc
> 
> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
> ---
>  meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
>  .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
>  3 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
> 
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus.inc b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
> new file mode 100644
> index 0000000..8e0e011
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
> @@ -0,0 +1,13 @@
> +SUMMARY = "A Modbus library"
> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
> +QNX and Windows."
> +HOMEPAGE = "http://www.libmodbus.org/"
> +SECTION = "libs"
> +PRIORITY = "optional"

you can drop this field too.

> +LICENSE = "LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
> +
> +INC_PR = "r0"
> +
> +inherit autotools pkgconfig
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> new file mode 100644
> index 0000000..7a99f72
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> @@ -0,0 +1,8 @@
> +require libmodbus.inc
> +
> +PR = "${INC_PR}.0"
> +
> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
> +SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
> new file mode 100644
> index 0000000..793a9d6
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
> @@ -0,0 +1,13 @@
> +require libmodbus.inc
> +
> +SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
> +
> +PV = "3.0.2+gitr${SRCPV}"
> +
> +PR = "${INC_PR}.0"
> +
> +DEFAULT_PREFERENCE = "-1"
> +
> +SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
> +S = "${WORKDIR}/git"
> +
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Andrea Galbusera - May 5, 2012, 3:52 p.m.
Hi Khem and Martin,

On Fri, May 4, 2012 at 11:49 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, May 4, 2012 at 2:25 PM, Andrea Galbusera <gizero@gmail.com> wrote:
>> * based on recipe by Radoslav Kolev which was in classic
>> * updated to latest released version 3.0.2
>> * also provide an _git version with up-to-date SRCREV and
>> DEFAULT_PREFERENCE = "-1"
>
> You should always prefix the subject line with layername e.g.
> [meta-oe]... so you get appropriate maintainers attention

Ok!

>
> Do we really need the git version ? if not then drop it.

Thank you for reviewing. I agree with you: the stable release should
be enough. git version was included only because it was there in
classic.
I'll update and resend as v2.

>> * common part factorized as libmodbus.inc
>>
>> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
>> ---
>>  meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
>>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
>>  .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
>>  3 files changed, 34 insertions(+), 0 deletions(-)
>>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
>>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus.inc b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
>> new file mode 100644
>> index 0000000..8e0e011
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
>> @@ -0,0 +1,13 @@
>> +SUMMARY = "A Modbus library"
>> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
>> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
>> +QNX and Windows."
>> +HOMEPAGE = "http://www.libmodbus.org/"
>> +SECTION = "libs"
>> +PRIORITY = "optional"
>
> PRIORITY is no longer used drop it.

Good to know!

>> +LICENSE = "LGPLv2.1+"
>> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
>> +
>> +INC_PR = "r0"
>
> if you are just having 1 recipe i.e. dropping git recipe then change that
> to PR
>
>> +
>> +inherit autotools pkgconfig
>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>> new file mode 100644
>> index 0000000..7a99f72
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>> @@ -0,0 +1,8 @@
>> +require libmodbus.inc
>> +
>> +PR = "${INC_PR}.0"
>> +
>> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
>> +
>> +SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
>> +SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
>> new file mode 100644
>> index 0000000..793a9d6
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
>> @@ -0,0 +1,13 @@
>> +require libmodbus.inc
>> +
>> +SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
>> +
>> +PV = "3.0.2+gitr${SRCPV}"
>> +
>> +PR = "${INC_PR}.0"
>> +
>> +DEFAULT_PREFERENCE = "-1"
>> +
>> +SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
>> +S = "${WORKDIR}/git"
>> +
>> --
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus.inc b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
new file mode 100644
index 0000000..8e0e011
--- /dev/null
+++ b/meta-oe/recipes-extended/libmodbus/libmodbus.inc
@@ -0,0 +1,13 @@ 
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+PRIORITY = "optional"
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+INC_PR = "r0"
+
+inherit autotools pkgconfig
diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
new file mode 100644
index 0000000..7a99f72
--- /dev/null
+++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
@@ -0,0 +1,8 @@ 
+require libmodbus.inc
+
+PR = "${INC_PR}.0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
new file mode 100644
index 0000000..793a9d6
--- /dev/null
+++ b/meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
@@ -0,0 +1,13 @@ 
+require libmodbus.inc
+
+SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
+
+PV = "3.0.2+gitr${SRCPV}"
+
+PR = "${INC_PR}.0"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
+S = "${WORKDIR}/git"
+