Patchwork How to fix warning: set SYSTEMD_PACKAGES as <existing-package>-systemd

login
mail settings
Submitter Elvis Dowson
Date May 4, 2012, 6:09 p.m.
Message ID <BEB5EFF4-B2E1-40DC-A12F-60ACB097C4E3@gmail.com>
Download mbox | patch
Permalink /patch/27091/
State New
Headers show

Comments

Elvis Dowson - May 4, 2012, 6:09 p.m.
Hi Koen,

On May 4, 2012, at 11:46 AM, Koen Kooi wrote:

> When doing things like that you need to bump PR and fixup all dependents like tasks and images to ensure upgrade paths.

I bumped the PR, but still get the warning message. How is the warning for this specific package linked to its dependents. The warning looks localized to the lighttpd_1.4.30.bb recipe.

If you can tell me how to fix it, I'll do it and send a patch.


Elvis Dowson
Denys Dmytriyenko - May 4, 2012, 6:27 p.m.
On Fri, May 04, 2012 at 08:09:39PM +0200, Elvis Dowson wrote:
> Hi Koen,
> 
> I bumped the PR, but still get the warning message. How is the warning for 
> this specific package linked to its dependents. The warning looks localized 
> to the lighttpd_1.4.30.bb recipe.
> 
> If you can tell me how to fix it, I'll do it and send a patch.

You are trying to fix it in oe-core/poky layer, where it doesn't use systemd. 
There is a .bbappend in meta-oe for that. In fact, here's what I told you 
yesterday:

> WARNING: /tool/yocto/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb: it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd
> WARNING: /tool/yocto/poky/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb: it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd

For these 2 please report them on openembedded-devel mailing list, where
meta-oe things are being discussed. The last warning is confisuing, as it
reports the recipe is in poky/oe-core, but it actually comes from the
corresponding .bbappend in meta-oe.
Elvis Dowson - May 4, 2012, 6:52 p.m.
Hi Denys,

On May 4, 2012, at 8:27 PM, Denys Dmytriyenko wrote:

> You are trying to fix it in oe-core/poky layer, where it doesn't use systemd. 
> There is a .bbappend in meta-oe for that. 

Yes, you're right! :-) Ok, I'm slowly starting to see how its important to trace
any additional .bbappend recipes. 

> For these 2 please report them on openembedded-devel mailing list, where
> meta-oe things are being discussed. The last warning is confisuing, as it
> reports the recipe is in poky/oe-core, but it actually comes from the
> corresponding .bbappend in meta-oe.

I'll submit these two patches to the openembedded-devel mailing list, once
I go through the sutmitting patches README. :-) God, the things you have to
do just to submit a simple patch! ;-)

Best regards,

Elvis

Patch

diff --git a/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb b/meta/recipes-extended/lighttpd/lighttpd_1.4.30.
index 3ae3867..71ae64c 100644
--- a/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb
+++ b/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb
@@ -16,7 +16,7 @@  RDEPENDS_${PN} += " \
                lighttpd-module-staticfile \
 "
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://download.lighttpd.net/lighttpd/releases-1.4.x/lighttpd-${PV}.tar.bz2 \
         file://index.html.lighttpd \
@@ -51,6 +51,9 @@  do_install_append() {
     install -m 0644 ${WORKDIR}/index.html.lighttpd ${D}/www/pages/index.html
 }
 
+SYSTEMD_PACKAGES = "${PN}-systemd"
+SYSTEMD_SERVICE = "lighttpd.service"
+
 FILES_${PN} += "${sysconfdir} /www"
 
 CONFFILES_${PN} = "${sysconfdir}/lighttpd.conf"