From patchwork Fri Apr 22 19:51:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: wvstreams: add patch to add missing header includes Date: Fri, 22 Apr 2011 19:51:07 -0000 From: Paul Menzel X-Patchwork-Id: 2709 Message-Id: <1303501867.4155.11.camel@mattotaupa> To: openembedded-devel@lists.openembedded.org Cc: =?ISO-8859-1?Q?S=F8ren?= Holm From: Søren Holm Date: Wed, 20 Apr 2011 09:48:43 +0200 Building fails with the following error. | ./CXX -c ipstreams/wvunixdgsocket | In file included from ./include/wvunixdgsocket.h:13:0, | from ipstreams/wvunixdgsocket.cc:1: | ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const': | ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules | ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)': | ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope | make: *** [ipstreams/wvunixdgsocket.o] Error 1 This patch is build tested using `angstrom-2010.x` and `minimal` for `MACHINE = "beagleboard"`. The build still fails when uClibc is used. Signed-off-by: Paul Menzel CC: Søren Holm CC: Khem Raj Acked-by: Khem Raj Signed-off-by: Søren Holm --- 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1]. 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too. 3. Søren, please send your patch upstream. 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it. 5. Søren, I removed `apply=yes` since that is the default. [1] http://openembedded.org/index.php/Commit_Policy --- .../files/0001-Fixed-missing-header-includes.patch | 37 ++++++++++++++++++++ recipes/wvstreams/wvstreams_4.6.bb | 1 + 2 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch diff --git a/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch new file mode 100644 index 0000000..f6d99f0 --- /dev/null +++ b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch @@ -0,0 +1,37 @@ +From d76ec92a9e09fefa3083250f4aa588d0e94fe20c Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=B8ren=20Holm?= +Date: Wed, 20 Apr 2011 09:41:22 +0200 +Subject: [PATCH] Fixed missing header includes. + +--- + ipstreams/wvunixdgsocket.cc | 2 +- + streams/wvatomicfile.cc | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ipstreams/wvunixdgsocket.cc b/ipstreams/wvunixdgsocket.cc +index 41d2911..6dc12fc 100644 +--- a/ipstreams/wvunixdgsocket.cc ++++ b/ipstreams/wvunixdgsocket.cc +@@ -1,5 +1,5 @@ + #include "wvunixdgsocket.h" +-#ifdef MACOS ++#if defined(MACOS) || defined(__GNUC__) + #include + #include + #endif +diff --git a/streams/wvatomicfile.cc b/streams/wvatomicfile.cc +index 65ae202..0a58069 100644 +--- a/streams/wvatomicfile.cc ++++ b/streams/wvatomicfile.cc +@@ -11,7 +11,7 @@ + #include "wvfileutils.h" + #include "wvstrutils.h" + +-#ifdef MACOS ++#if defined(MACOS) || defined(__GNUC__) + #include + #endif + +-- +1.7.4.1 + diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb index 1c11268..0eb0198 100644 --- a/recipes/wvstreams/wvstreams_4.6.bb +++ b/recipes/wvstreams/wvstreams_4.6.bb @@ -6,6 +6,7 @@ DEPENDS = "zlib openssl (>= 0.9.8)" PR = "r1" SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \ + file://0001-Fixed-missing-header-includes.patch \ " inherit autotools pkgconfig