Patchwork [meta-openembedded] networkmanager: silence systemd bbclass WARNING.

login
register
mail settings
Submitter Elvis Dowson
Date May 4, 2012, 9:15 a.m.
Message ID <D54EB56C-3187-439B-BF54-4C4ACD76C8CC@gmail.com>
Download mbox | patch
Permalink /patch/27055/
State New
Headers show

Comments

Elvis Dowson - May 4, 2012, 9:15 a.m.
This patch fixes WARNING: /tool/yocto/meta-openembedded/meta-oe/
recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd

Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
---
.../networkmanager/networkmanager_0.9.2.0.bb       |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Koen Kooi - May 4, 2012, 10:23 a.m.
Please follow the README for submitting patches to meta-oe.

Op 4 mei 2012, om 11:15 heeft Elvis Dowson het volgende geschreven:

> This patch fixes WARNING: /tool/yocto/meta-openembedded/meta-oe/
> recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb:
> it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd
> 
> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
> ---
> .../networkmanager/networkmanager_0.9.2.0.bb       |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> index 474d98a..478d61e 100644
> --- a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> +++ b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> @@ -54,7 +54,7 @@ do_install_append () {
> 	install -d ${D}/etc/NetworkManager/VPN
> }
> 
> -SYSTEMD_PACKAGES = "${PN}"
> +SYSTEMD_PACKAGES = "${PN}-systemd"
> SYSTEMD_SERVICE = "NetworkManager.service"
> 
> PACKAGES =+ "libnmutil libnmglib libnmglib-vpn ${PN}-tests" 
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Denys Dmytriyenko - May 4, 2012, 5:33 p.m.
On Fri, May 04, 2012 at 11:15:33AM +0200, Elvis Dowson wrote:
> This patch fixes WARNING: /tool/yocto/meta-openembedded/meta-oe/

This is not the right mailing list for patches addressed to meta-oe. As I 
recall, I told you to submit to openembedded-devel, but not here. Sorry if it 
got you confused...


> recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb:
> it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd
> 
> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
> ---
> .../networkmanager/networkmanager_0.9.2.0.bb       |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> index 474d98a..478d61e 100644
> --- a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> +++ b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
> @@ -54,7 +54,7 @@ do_install_append () {
> 	install -d ${D}/etc/NetworkManager/VPN
> }
> 
> -SYSTEMD_PACKAGES = "${PN}"
> +SYSTEMD_PACKAGES = "${PN}-systemd"

That might be an overkill. I'm personally not yet very familiar with all the 
systemd specifics and not clear when to create ${PN}-systemd subpackage and 
when to just silence the warning...
Elvis Dowson - May 4, 2012, 5:39 p.m.
Hi Denys,

On May 4, 2012, at 7:33 PM, Denys Dmytriyenko wrote:

>> 
>> -SYSTEMD_PACKAGES = "${PN}"
>> +SYSTEMD_PACKAGES = "${PN}-systemd"
> 
> That might be an overkill. I'm personally not yet very familiar with all the 
> systemd specifics and not clear when to create ${PN}-systemd subpackage and 
> when to just silence the warning...
> 

Me neither :-) ,... but this is what the warning message, suggested be done.

It fixed the warning for networkmanager, though.

Best regards,

Elvis
Khem Raj - May 4, 2012, 6:39 p.m.
On Fri, May 4, 2012 at 10:39 AM, Elvis Dowson <elvis.dowson@gmail.com> wrote:
>
>
> Me neither :-) ,... but this is what the warning message, suggested be done.
>
> It fixed the warning for networkmanager, though.

If you have sysvinit scripts for this package then it makes sense to
have this renamed package otherwise leave it out. I think warning is
harmless in this case
Denys Dmytriyenko - May 4, 2012, 7:25 p.m.
On Fri, May 04, 2012 at 11:39:16AM -0700, Khem Raj wrote:
> On Fri, May 4, 2012 at 10:39 AM, Elvis Dowson <elvis.dowson@gmail.com> wrote:
> >
> >
> > Me neither :-) ,... but this is what the warning message, suggested be done.
> >
> > It fixed the warning for networkmanager, though.
> 
> If you have sysvinit scripts for this package then it makes sense to
> have this renamed package otherwise leave it out. I think warning is
> harmless in this case

And there's a knob for that:

+NATIVE_SYSTEMD_SUPPORT = "1"

But use it wisely! :)

Patch

diff --git a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
index 474d98a..478d61e 100644
--- a/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
+++ b/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.2.0.bb
@@ -54,7 +54,7 @@  do_install_append () {
	install -d ${D}/etc/NetworkManager/VPN
}

-SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_PACKAGES = "${PN}-systemd"
SYSTEMD_SERVICE = "NetworkManager.service"

PACKAGES =+ "libnmutil libnmglib libnmglib-vpn ${PN}-tests"