Patchwork [1/7] unfs-server: Do not use DESTDIR

login
register
mail settings
Submitter Khem Raj
Date May 2, 2012, 8:53 p.m.
Message ID <0c57b76bc47680ccf576d412a3dc7e726f1daba2.1335991900.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/26843/
State New
Headers show

Comments

Khem Raj - May 2, 2012, 8:53 p.m.
DESTDIR is makefile variable not available in
bitbake environment

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../unfs-server/unfs-server_2.1+2.2beta47.bb       |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - May 2, 2012, 11:09 p.m.
On Wed, 2012-05-02 at 13:53 -0700, Khem Raj wrote:
> DESTDIR is makefile variable not available in
> bitbake environment
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../unfs-server/unfs-server_2.1+2.2beta47.bb       |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> index d03c153..682891d 100644
> --- a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> +++ b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> @@ -7,7 +7,7 @@ RDEPENDS_${PN} = "pseudo"
>  RDEPENDS_${PN}_virtclass-native = "pseudo-native"
>  RDEPENDS_${PN}_virtclass-nativesdk = "pseudo-nativesdk"
>  BASEPV = "2.2beta47"
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "ftp://linux.mathematik.tu-darmstadt.de/pub/linux/oldstuff/people/okir/nfs-server-${BASEPV}.tar.gz \
>             file://001-2.2b47-2.2b51.patch \
> @@ -53,7 +53,7 @@ EXTRA_OECONF = "--enable-ugid-dynamic \
>                  --with-exports-uid=0 \
>                  --with-exports-gid=0 \
>                  --enable-mount-logging \
> -                --with-devtab=${DESTDIR}${base_prefix}/var/lib/nfs/devtab \
> +                --with-devtab=${base_prefix}/var/lib/nfs/devtab \

This is not correct, you want ${D} there I think. It is rather odd
though and we might be better patching the makefile for this.

Cheers,

Richard
Khem Raj - May 3, 2012, 12:02 a.m.
On Wed, May 2, 2012 at 4:09 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2012-05-02 at 13:53 -0700, Khem Raj wrote:
>> DESTDIR is makefile variable not available in
>> bitbake environment
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  .../unfs-server/unfs-server_2.1+2.2beta47.bb       |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
>> index d03c153..682891d 100644
>> --- a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
>> +++ b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
>> @@ -7,7 +7,7 @@ RDEPENDS_${PN} = "pseudo"
>>  RDEPENDS_${PN}_virtclass-native = "pseudo-native"
>>  RDEPENDS_${PN}_virtclass-nativesdk = "pseudo-nativesdk"
>>  BASEPV = "2.2beta47"
>> -PR = "r1"
>> +PR = "r2"
>>
>>  SRC_URI = "ftp://linux.mathematik.tu-darmstadt.de/pub/linux/oldstuff/people/okir/nfs-server-${BASEPV}.tar.gz \
>>             file://001-2.2b47-2.2b51.patch \
>> @@ -53,7 +53,7 @@ EXTRA_OECONF = "--enable-ugid-dynamic \
>>                  --with-exports-uid=0 \
>>                  --with-exports-gid=0 \
>>                  --enable-mount-logging \
>> -                --with-devtab=${DESTDIR}${base_prefix}/var/lib/nfs/devtab \
>> +                --with-devtab=${base_prefix}/var/lib/nfs/devtab \
>
> This is not correct, you want ${D} there I think. It is rather odd
> though and we might be better patching the makefile for this.

hmmm ok. Drop that one. It sort of seemed wrong to have ${D} in there

Patch

diff --git a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
index d03c153..682891d 100644
--- a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
+++ b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
@@ -7,7 +7,7 @@  RDEPENDS_${PN} = "pseudo"
 RDEPENDS_${PN}_virtclass-native = "pseudo-native"
 RDEPENDS_${PN}_virtclass-nativesdk = "pseudo-nativesdk"
 BASEPV = "2.2beta47"
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "ftp://linux.mathematik.tu-darmstadt.de/pub/linux/oldstuff/people/okir/nfs-server-${BASEPV}.tar.gz \
            file://001-2.2b47-2.2b51.patch \
@@ -53,7 +53,7 @@  EXTRA_OECONF = "--enable-ugid-dynamic \
                 --with-exports-uid=0 \
                 --with-exports-gid=0 \
                 --enable-mount-logging \
-                --with-devtab=${DESTDIR}${base_prefix}/var/lib/nfs/devtab \
+                --with-devtab=${base_prefix}/var/lib/nfs/devtab \
                "
 
 do_configure_prepend () {