| Submitter | Peter Seebach |
|---|---|
| Date | May 2, 2012, 1:45 a.m. |
| Message ID | <cover.1335922726.git.peter.seebach@windriver.com> |
| Download | mbox |
| Permalink | /patch/26789/ |
| State | New |
| Headers | show |
Pull-request
git://git.yoctoproject.org/poky-contrib seebs/toolchainsComments
On 05/01/2012 06:45 PM, Peter Seebach wrote: > And yes, I'm aware that "toolchain sanity checks" is sort of a > self-defeating concept. > > Okay, cleanups: > * Now checking MULTILIB_VARIANTS, not MULTILIBS. Simpler and less indented. > * Added a third commit to do the BBCLASSEXTEND checks since those seem like > a good idea, and it's less work to do it than to create a todo item. > * Did you know that, despite a lot of this being Python, you can't use > triple-quote strings in documentation.conf? I didn't, and apparently > that "fix" went in untested. (Also the addition of duplicate but indented > copies of two later lines, which didn't parse. Looks like I got a bit > careless with my cut and paste there.) > > The following changes since commit 35b5fb2dd2131d4c7dc6635c14c6e08ea6926457: > Saul Wold (1): > eglibc-package: remove /var > > are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib seebs/toolchains > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/toolchains > > Peter Seebach (3): > conf/machine: Clean up configuration values. > sanity.bbclass: Implement initial toolchain sanity checks These 2 have been merged into OE-Core > sanity.bbclass: Check for bogus values in BBCLASSEXTEND > RP commented on this one. Thanks Sau! > meta/classes/sanity.bbclass | 86 ++++++++++++++++++++++ > meta/conf/documentation.conf | 9 ++ > meta/conf/machine/include/README | 4 + > meta/conf/machine/include/arm/arch-armv5-dsp.inc | 1 + > meta/conf/machine/include/arm/arch-armv7a.inc | 2 +- > meta/conf/machine/include/ia32/arch-ia32.inc | 2 +- > meta/conf/machine/include/mips/arch-mips.inc | 6 +- > meta/conf/machine/include/tune-c3.inc | 2 +- > 8 files changed, 106 insertions(+), 6 deletions(-) > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Wed, 9 May 2012 16:32:17 -0700 Saul Wold <sgw@linux.intel.com> wrote: > > sanity.bbclass: Check for bogus values in BBCLASSEXTEND > > > RP commented on this one. I'm gonna drop that for now, I think. I am looking a little at per-package sanity checking, but it turns out to be harder than I would ideally like. -s
And yes, I'm aware that "toolchain sanity checks" is sort of a self-defeating concept. Okay, cleanups: * Now checking MULTILIB_VARIANTS, not MULTILIBS. Simpler and less indented. * Added a third commit to do the BBCLASSEXTEND checks since those seem like a good idea, and it's less work to do it than to create a todo item. * Did you know that, despite a lot of this being Python, you can't use triple-quote strings in documentation.conf? I didn't, and apparently that "fix" went in untested. (Also the addition of duplicate but indented copies of two later lines, which didn't parse. Looks like I got a bit careless with my cut and paste there.) The following changes since commit 35b5fb2dd2131d4c7dc6635c14c6e08ea6926457: Saul Wold (1): eglibc-package: remove /var are available in the git repository at: git://git.yoctoproject.org/poky-contrib seebs/toolchains http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/toolchains Peter Seebach (3): conf/machine: Clean up configuration values. sanity.bbclass: Implement initial toolchain sanity checks sanity.bbclass: Check for bogus values in BBCLASSEXTEND meta/classes/sanity.bbclass | 86 ++++++++++++++++++++++ meta/conf/documentation.conf | 9 ++ meta/conf/machine/include/README | 4 + meta/conf/machine/include/arm/arch-armv5-dsp.inc | 1 + meta/conf/machine/include/arm/arch-armv7a.inc | 2 +- meta/conf/machine/include/ia32/arch-ia32.inc | 2 +- meta/conf/machine/include/mips/arch-mips.inc | 6 +- meta/conf/machine/include/tune-c3.inc | 2 +- 8 files changed, 106 insertions(+), 6 deletions(-)