Patchwork [07/10] gcc-cross.inc: Fix cross testing script

login
mail settings
Submitter Khem Raj
Date April 30, 2012, 5:46 p.m.
Message ID <b844d82b14bec3a4f8cc6784a0ec368b0da1f196.1335807802.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/26659/
State Accepted
Commit 4cd306ab0c9404a31f38c7e5fb67fe32fdca3d4b
Headers show

Comments

Khem Raj - April 30, 2012, 5:46 p.m.
shift the cmdline argument after determining
there is atleast 1 argument to shift otherwise
it ends up in error when no argument is specified

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-cross.inc |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index e7a5e41..6d160d6 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -45,7 +45,6 @@  do_compile () {
 	# append execution part of the script
 cat >> ${B}/${TARGET_PREFIX}testgcc << STOP
 target="\$1"
-shift
 usage () {
 	echo "Usage:"
 	echo "\$0 user@target 'extra options to dejagnu'"
@@ -60,11 +59,13 @@  usage () {
     }
 if [ "x\$target" = "x" ]
 then
-	echo "Please specify the target machine and remote user in form of user@target"
+	echo "Please specify the target machine and remote user in form of user@target\n"
 	usage
 	exit 1;
 fi
 
+shift
+
 echo "\$target" | grep "@" 2>&1 > /dev/null
 if [ "x\$?" = "x0" ]
 then