Patchwork [6/8] ofono: upgrade to version 1.6

login
register
mail settings
Submitter Dongxiao Xu
Date April 28, 2012, 8:12 a.m.
Message ID <baa0f344e516b3474cf5f1a5e8afcbc392be16de.1335600691.git.dongxiao.xu@intel.com>
Download mbox | patch
Permalink /patch/26561/
State New
Headers show

Comments

Dongxiao Xu - April 28, 2012, 8:12 a.m.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
---
 .../ofono/{ofono_1.5.bb => ofono_1.6.bb}           |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 rename meta/recipes-connectivity/ofono/{ofono_1.5.bb => ofono_1.6.bb} (97%)
Martin Jansa - April 29, 2012, 8:45 a.m.
On Sat, Apr 28, 2012 at 04:12:30PM +0800, Dongxiao Xu wrote:
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  .../ofono/{ofono_1.5.bb => ofono_1.6.bb}           |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>  rename meta/recipes-connectivity/ofono/{ofono_1.5.bb => ofono_1.6.bb} (97%)
> 
> diff --git a/meta/recipes-connectivity/ofono/ofono_1.5.bb b/meta/recipes-connectivity/ofono/ofono_1.6.bb
> similarity index 97%
> rename from meta/recipes-connectivity/ofono/ofono_1.5.bb
> rename to meta/recipes-connectivity/ofono/ofono_1.6.bb
> index dad813f..d0f273b 100644
> --- a/meta/recipes-connectivity/ofono/ofono_1.5.bb
> +++ b/meta/recipes-connectivity/ofono/ofono_1.6.bb
> @@ -1,6 +1,6 @@
>  require ofono.inc
>  
> -PR = "r1"
> +PR = "r0"

without checksum change it will fail, right?

I'll send patch I have for ofono upgrade in my branch.

>  
>  SRC_URI  = "${KERNELORG_MIRROR}/linux/network/ofono/${BPN}-${PV}.tar.bz2 \
>  	          file://ofono"
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Saul Wold - April 30, 2012, 3:21 p.m.
On 04/29/2012 01:45 AM, Martin Jansa wrote:
> On Sat, Apr 28, 2012 at 04:12:30PM +0800, Dongxiao Xu wrote:
>> Signed-off-by: Dongxiao Xu<dongxiao.xu@intel.com>
>> ---
>>   .../ofono/{ofono_1.5.bb =>  ofono_1.6.bb}           |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>   rename meta/recipes-connectivity/ofono/{ofono_1.5.bb =>  ofono_1.6.bb} (97%)
>>
>> diff --git a/meta/recipes-connectivity/ofono/ofono_1.5.bb b/meta/recipes-connectivity/ofono/ofono_1.6.bb
>> similarity index 97%
>> rename from meta/recipes-connectivity/ofono/ofono_1.5.bb
>> rename to meta/recipes-connectivity/ofono/ofono_1.6.bb
>> index dad813f..d0f273b 100644
>> --- a/meta/recipes-connectivity/ofono/ofono_1.5.bb
>> +++ b/meta/recipes-connectivity/ofono/ofono_1.6.bb
>> @@ -1,6 +1,6 @@
>>   require ofono.inc
>>
>> -PR = "r1"
>> +PR = "r0"
>
> without checksum change it will fail, right?
>
> I'll send patch I have for ofono upgrade in my branch.
>
This seems to have uncovered a problem with the Fetcher, it happily 
pulls the upstream tarball, raises a BBFetchException, and writes the 
checksum failure to the log file, but it seems to still mark the fetch 
complete with a .done file and continues to build.

I will file a bug.

Sau!

>>
>>   SRC_URI  = "${KERNELORG_MIRROR}/linux/network/ofono/${BPN}-${PV}.tar.bz2 \
>>   	          file://ofono"
>> --
>> 1.7.4.1
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - April 30, 2012, 3:31 p.m.
On Monday, April 30, 2012, Saul Wold <sgw@linux.intel.com> wrote:
> On 04/29/2012 01:45 AM, Martin Jansa wrote:
>>
>> On Sat, Apr 28, 2012 at 04:12:30PM +0800, Dongxiao Xu wrote:
>>>
>>> Signed-off-by: Dongxiao Xu<dongxiao.xu@intel.com>
>>> ---
>>>  .../ofono/{ofono_1.5.bb =>  ofono_1.6.bb}           |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>  rename meta/recipes-connectivity/ofono/{ofono_1.5.bb =>  ofono_1.6.bb}
(97%)
>>>
>>> diff --git a/meta/recipes-connectivity/ofono/ofono_1.5.bbb/meta/recipes-connectivity/ofono/
ofono_1.6.bb
>>> similarity index 97%
>>> rename from meta/recipes-connectivity/ofono/ofono_1.5.bb
>>> rename to meta/recipes-connectivity/ofono/ofono_1.6.bb
>>> index dad813f..d0f273b 100644
>>> --- a/meta/recipes-connectivity/ofono/ofono_1.5.bb
>>> +++ b/meta/recipes-connectivity/ofono/ofono_1.6.bb
>>> @@ -1,6 +1,6 @@
>>>  require ofono.inc
>>>
>>> -PR = "r1"
>>> +PR = "r0"
>>
>> without checksum change it will fail, right?
>>
>> I'll send patch I have for ofono upgrade in my branch.
>>
> This seems to have uncovered a problem with the Fetcher, it happily pulls
the upstream tarball, raises a BBFetchException, and writes the checksum
failure to the log file, but it seems to still mark the fetch complete with
a .done file and continues to build.
>

Will check summing not be done next time it tries to build the recipe

> I will file a bug.
>
> Sau!
>
>>>
>>>  SRC_URI  =
"${KERNELORG_MIRROR}/linux/network/ofono/${BPN}-${PV}.tar.bz2 \
>>>                  file://ofono"
>>> --
>>> 1.7.4.1
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Koen Kooi - April 30, 2012, 3:46 p.m.
Op 30 apr. 2012, om 17:21 heeft Saul Wold het volgende geschreven:

> On 04/29/2012 01:45 AM, Martin Jansa wrote:
>> On Sat, Apr 28, 2012 at 04:12:30PM +0800, Dongxiao Xu wrote:
>>> Signed-off-by: Dongxiao Xu<dongxiao.xu@intel.com>
>>> ---
>>>  .../ofono/{ofono_1.5.bb =>  ofono_1.6.bb}           |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>  rename meta/recipes-connectivity/ofono/{ofono_1.5.bb =>  ofono_1.6.bb} (97%)
>>> 
>>> diff --git a/meta/recipes-connectivity/ofono/ofono_1.5.bb b/meta/recipes-connectivity/ofono/ofono_1.6.bb
>>> similarity index 97%
>>> rename from meta/recipes-connectivity/ofono/ofono_1.5.bb
>>> rename to meta/recipes-connectivity/ofono/ofono_1.6.bb
>>> index dad813f..d0f273b 100644
>>> --- a/meta/recipes-connectivity/ofono/ofono_1.5.bb
>>> +++ b/meta/recipes-connectivity/ofono/ofono_1.6.bb
>>> @@ -1,6 +1,6 @@
>>>  require ofono.inc
>>> 
>>> -PR = "r1"
>>> +PR = "r0"
>> 
>> without checksum change it will fail, right?
>> 
>> I'll send patch I have for ofono upgrade in my branch.
>> 
> This seems to have uncovered a problem with the Fetcher, it happily pulls the upstream tarball, raises a BBFetchException, and writes the checksum failure to the log file, but it seems to still mark the fetch complete with a .done file and continues to build.

I've had reports of that bug as well, it is also triggered by things like redirects to fancy error pages. 

regards,

Koen

Patch

diff --git a/meta/recipes-connectivity/ofono/ofono_1.5.bb b/meta/recipes-connectivity/ofono/ofono_1.6.bb
similarity index 97%
rename from meta/recipes-connectivity/ofono/ofono_1.5.bb
rename to meta/recipes-connectivity/ofono/ofono_1.6.bb
index dad813f..d0f273b 100644
--- a/meta/recipes-connectivity/ofono/ofono_1.5.bb
+++ b/meta/recipes-connectivity/ofono/ofono_1.6.bb
@@ -1,6 +1,6 @@ 
 require ofono.inc
 
-PR = "r1"
+PR = "r0"
 
 SRC_URI  = "${KERNELORG_MIRROR}/linux/network/ofono/${BPN}-${PV}.tar.bz2 \
 	          file://ofono"