| Submitter | Peter Seebach |
|---|---|
| Date | April 27, 2012, 11:51 p.m. |
| Message ID | <8fd6ef92079e16fdf31fe8b6f3194df7a858ed71.1335569869.git.peter.seebach@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/26547/ |
| State | Accepted |
| Commit | e63fb1e9918bff6f91bbab09b29248ab8b649e84 |
| Headers | show |
Comments
On 04/27/2012 04:51 PM, Peter Seebach wrote: > In tune-sh3, tune-xscale, and tune-sh4, several FEATURES lines referred > to nonexistent features like "sh3eb" when they should have referred to "sh3 > bigendian" or the like. Caught by the TUNEVALID sanity check. > > Signed-off-by: Peter Seebach<peter.seebach@windriver.com> > --- > meta/conf/machine/include/tune-sh3.inc | 2 +- > meta/conf/machine/include/tune-sh4.inc | 4 ++-- > meta/conf/machine/include/tune-xscale.inc | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/meta/conf/machine/include/tune-sh3.inc b/meta/conf/machine/include/tune-sh3.inc > index 816c9c4..70bb10b 100644 > --- a/meta/conf/machine/include/tune-sh3.inc > +++ b/meta/conf/machine/include/tune-sh3.inc > @@ -11,7 +11,7 @@ TUNE_ARCH_tune-sh3 = "sh3" > TUNE_PKGARCH_tune-sh3 = "sh3" > PACKAGE_EXTRA_ARCHS_tune-sh3 = "sh sh3" > > -TUNE_FEATURES_tune-sh3eb = "sh3eb" > +TUNE_FEATURES_tune-sh3eb = "sh3 bigendian" > TUNE_ARCH_tune-sh3eb = "sh3eb" > TUNE_PKGARCH_tune-sh3eb = "sh3eb" > PACKAGE_EXTRA_ARCHS_tune-sh3eb = "sheb sh3eb" > diff --git a/meta/conf/machine/include/tune-sh4.inc b/meta/conf/machine/include/tune-sh4.inc > index f971f23..00cfc3d 100644 > --- a/meta/conf/machine/include/tune-sh4.inc > +++ b/meta/conf/machine/include/tune-sh4.inc > @@ -18,7 +18,7 @@ TUNE_ARCH_tune-sh4 = "sh4" > TUNE_PKGARCH_tune-sh4 = "sh4" > PACKAGE_EXTRA_ARCHS_tune-sh4 = "sh sh4" > > -TUNE_FEATURES_tune-sh4eb = "sh4eb" > +TUNE_FEATURES_tune-sh4eb = "sh4 bigendian" > TUNE_ARCH_tune-sh4eb = "sh4eb" > TUNE_PKGARCH_tune-sh4eb = "sh4eb" > PACKAGE_EXTRA_ARCHS_tune-sh4eb = "sheb sh4eb" > @@ -28,7 +28,7 @@ TUNE_ARCH_tune-sh4a = "sh4" > TUNE_PKGARCH_tune-sh4a = "sh4a" > PACKAGE_EXTRA_ARCHS_tune-sh4a = "sh sh4 sh4a" > > -TUNE_FEATURES_tune-sh4aeb = "sh4aeb" > +TUNE_FEATURES_tune-sh4aeb = "sh4a bigendian" > TUNE_ARCH_tune-sh4aeb = "sh4eb" > TUNE_PKGARCH_tune-sh4aeb = "sh4aeb" > PACKAGE_EXTRA_ARCHS_tune-sh4aeb = "sheb sh4eb sh4aeb" > diff --git a/meta/conf/machine/include/tune-xscale.inc b/meta/conf/machine/include/tune-xscale.inc > index 54f3727..80a3683 100644 > --- a/meta/conf/machine/include/tune-xscale.inc > +++ b/meta/conf/machine/include/tune-xscale.inc > @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-xscale = "${TUNE_FEATURES_tune-armv5te} xscale" > PACKAGE_EXTRA_ARCHS_tune-xscale = "${PACKAGE_EXTRA_ARCHS_tune-armv5te}" > > AVAILTUNES += "xscale-be" > -TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale-be" > +TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale bigendian" > PACKAGE_EXTRA_ARCHS_tune-xscale-be = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb}" > > # webkit-gtk has alignment issues with double instructions on armv5 so Merged this patch into OE-Core Thanks Sau!
Patch
diff --git a/meta/conf/machine/include/tune-sh3.inc b/meta/conf/machine/include/tune-sh3.inc index 816c9c4..70bb10b 100644 --- a/meta/conf/machine/include/tune-sh3.inc +++ b/meta/conf/machine/include/tune-sh3.inc @@ -11,7 +11,7 @@ TUNE_ARCH_tune-sh3 = "sh3" TUNE_PKGARCH_tune-sh3 = "sh3" PACKAGE_EXTRA_ARCHS_tune-sh3 = "sh sh3" -TUNE_FEATURES_tune-sh3eb = "sh3eb" +TUNE_FEATURES_tune-sh3eb = "sh3 bigendian" TUNE_ARCH_tune-sh3eb = "sh3eb" TUNE_PKGARCH_tune-sh3eb = "sh3eb" PACKAGE_EXTRA_ARCHS_tune-sh3eb = "sheb sh3eb" diff --git a/meta/conf/machine/include/tune-sh4.inc b/meta/conf/machine/include/tune-sh4.inc index f971f23..00cfc3d 100644 --- a/meta/conf/machine/include/tune-sh4.inc +++ b/meta/conf/machine/include/tune-sh4.inc @@ -18,7 +18,7 @@ TUNE_ARCH_tune-sh4 = "sh4" TUNE_PKGARCH_tune-sh4 = "sh4" PACKAGE_EXTRA_ARCHS_tune-sh4 = "sh sh4" -TUNE_FEATURES_tune-sh4eb = "sh4eb" +TUNE_FEATURES_tune-sh4eb = "sh4 bigendian" TUNE_ARCH_tune-sh4eb = "sh4eb" TUNE_PKGARCH_tune-sh4eb = "sh4eb" PACKAGE_EXTRA_ARCHS_tune-sh4eb = "sheb sh4eb" @@ -28,7 +28,7 @@ TUNE_ARCH_tune-sh4a = "sh4" TUNE_PKGARCH_tune-sh4a = "sh4a" PACKAGE_EXTRA_ARCHS_tune-sh4a = "sh sh4 sh4a" -TUNE_FEATURES_tune-sh4aeb = "sh4aeb" +TUNE_FEATURES_tune-sh4aeb = "sh4a bigendian" TUNE_ARCH_tune-sh4aeb = "sh4eb" TUNE_PKGARCH_tune-sh4aeb = "sh4aeb" PACKAGE_EXTRA_ARCHS_tune-sh4aeb = "sheb sh4eb sh4aeb" diff --git a/meta/conf/machine/include/tune-xscale.inc b/meta/conf/machine/include/tune-xscale.inc index 54f3727..80a3683 100644 --- a/meta/conf/machine/include/tune-xscale.inc +++ b/meta/conf/machine/include/tune-xscale.inc @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-xscale = "${TUNE_FEATURES_tune-armv5te} xscale" PACKAGE_EXTRA_ARCHS_tune-xscale = "${PACKAGE_EXTRA_ARCHS_tune-armv5te}" AVAILTUNES += "xscale-be" -TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale-be" +TUNE_FEATURES_tune-xscale-be = "${TUNE_FEATURES_tune-armv5teb} xscale bigendian" PACKAGE_EXTRA_ARCHS_tune-xscale-be = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb}" # webkit-gtk has alignment issues with double instructions on armv5 so
In tune-sh3, tune-xscale, and tune-sh4, several FEATURES lines referred to nonexistent features like "sh3eb" when they should have referred to "sh3 bigendian" or the like. Caught by the TUNEVALID sanity check. Signed-off-by: Peter Seebach <peter.seebach@windriver.com> --- meta/conf/machine/include/tune-sh3.inc | 2 +- meta/conf/machine/include/tune-sh4.inc | 4 ++-- meta/conf/machine/include/tune-xscale.inc | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)