| Submitter | Lianhao Lu |
|---|---|
| Date | April 27, 2012, 5:04 a.m. |
| Message ID | <94e2c16d1d19f800c14e012b0fc24b8117944652.1335498445.git.lianhao.lu@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/26497/ |
| State | New |
| Headers | show |
Comments
On Fri, 2012-04-27 at 13:04 +0800, Lianhao Lu wrote: > Use the base_libdir to set the udev rules directory. > > Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> > --- > meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb > index 597e8b6..c39cd11 100644 > --- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb > +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb > @@ -6,7 +6,7 @@ LICENSE = "GPLv2+" > LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ > file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9" > DEPENDS = "alsa-lib ncurses libsamplerate0" > -PR = "r2" > +PR = "r3" > > SRC_URI = "ftp://ftp.alsa-project.org/pub/utils/alsa-utils-${PV}.tar.bz2 \ > file://ncursesfix.patch \ > @@ -21,7 +21,9 @@ SRC_URI[sha256sum] = "2e676a2f634bbfe279b260e10a96f617cb72ee63c5bbf6c5f96bb61570 > # http://bugs.openembedded.org/show_bug.cgi?id=2348 > # please close bug and remove this comment when properly fixed > # > -EXTRA_OECONF = "--disable-xmlto" > +EXTRA_OECONF = "--disable-xmlto \ > + --with-udev-rules-dir=${base_libdir}/udev/rules.d \ > + " > EXTRA_OECONF_append_libc-uclibc = " --disable-nls" > > inherit autotools gettext The udev configuration files are probably one case where using /lib makes a lot of sense since we should only have one set of these. I therefore think this should be added as an exception to the sanity test... Cheers, Richard
Op 27 apr. 2012, om 12:47 heeft Richard Purdie het volgende geschreven: > On Fri, 2012-04-27 at 13:04 +0800, Lianhao Lu wrote: >> Use the base_libdir to set the udev rules directory. >> >> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> >> --- >> meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb >> index 597e8b6..c39cd11 100644 >> --- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb >> +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb >> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+" >> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ >> file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9" >> DEPENDS = "alsa-lib ncurses libsamplerate0" >> -PR = "r2" >> +PR = "r3" >> >> SRC_URI = "ftp://ftp.alsa-project.org/pub/utils/alsa-utils-${PV}.tar.bz2 \ >> file://ncursesfix.patch \ >> @@ -21,7 +21,9 @@ SRC_URI[sha256sum] = "2e676a2f634bbfe279b260e10a96f617cb72ee63c5bbf6c5f96bb61570 >> # http://bugs.openembedded.org/show_bug.cgi?id=2348 >> # please close bug and remove this comment when properly fixed >> # >> -EXTRA_OECONF = "--disable-xmlto" >> +EXTRA_OECONF = "--disable-xmlto \ >> + --with-udev-rules-dir=${base_libdir}/udev/rules.d \ >> + " >> EXTRA_OECONF_append_libc-uclibc = " --disable-nls" >> >> inherit autotools gettext > > The udev configuration files are probably one case where using /lib > makes a lot of sense since we should only have one set of these. I > therefore think this should be added as an exception to the sanity > test... And keep in mind it's more '/lib' than '${base_libdir}' since it isn't supposed to adhere to multilib naming. So even on /lib64 machines the rules are in /lib. regards, Koen
Patch
diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb index 597e8b6..c39cd11 100644 --- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb @@ -6,7 +6,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9" DEPENDS = "alsa-lib ncurses libsamplerate0" -PR = "r2" +PR = "r3" SRC_URI = "ftp://ftp.alsa-project.org/pub/utils/alsa-utils-${PV}.tar.bz2 \ file://ncursesfix.patch \ @@ -21,7 +21,9 @@ SRC_URI[sha256sum] = "2e676a2f634bbfe279b260e10a96f617cb72ee63c5bbf6c5f96bb61570 # http://bugs.openembedded.org/show_bug.cgi?id=2348 # please close bug and remove this comment when properly fixed # -EXTRA_OECONF = "--disable-xmlto" +EXTRA_OECONF = "--disable-xmlto \ + --with-udev-rules-dir=${base_libdir}/udev/rules.d \ + " EXTRA_OECONF_append_libc-uclibc = " --disable-nls" inherit autotools gettext
Use the base_libdir to set the udev rules directory. Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> --- meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)