Patchwork [bitbake-devel,1/3] event.py: Add SanityCheck and SanityCheckPassed events

login
register
mail settings
Submitter Dongxiao Xu
Date April 24, 2012, 8:16 a.m.
Message ID <2bbdbdf903d6c80f54058bcb5edd8a1e6aa89d15.1335254750.git.dongxiao.xu@intel.com>
Download mbox | patch
Permalink /patch/26369/
State Accepted
Commit 4d7bf9d813229b78b1cd87d06f7042e7923b7db4
Headers show

Comments

Dongxiao Xu - April 24, 2012, 8:16 a.m.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
---
 lib/bb/event.py |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
Chris Larson - April 25, 2012, 1:26 a.m.
On Tue, Apr 24, 2012 at 1:16 AM, Dongxiao Xu <dongxiao.xu@intel.com> wrote:
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  lib/bb/event.py |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/lib/bb/event.py b/lib/bb/event.py
> index bbece58..f3fb521 100644
> --- a/lib/bb/event.py
> +++ b/lib/bb/event.py
> @@ -517,3 +517,13 @@ class PackageInfo(Event):
>     def __init__(self, pkginfolist):
>         Event.__init__(self)
>         self._pkginfolist = pkginfolist
> +
> +class SanityCheck(Event):
> +    """
> +    Event to issue sanity check
> +    """
> +
> +class SanityCheckPassed(Event):
> +    """
> +    Event to indicate sanity check is passed
> +    """

Sanity checking is not part of bitbake, nor does it belong there. I'd
say to find another way to do this.
Chris Larson - April 25, 2012, 1:27 a.m.
On Tue, Apr 24, 2012 at 6:26 PM, Chris Larson <clarson@kergoth.com> wrote:
> On Tue, Apr 24, 2012 at 1:16 AM, Dongxiao Xu <dongxiao.xu@intel.com> wrote:
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
>> ---
>>  lib/bb/event.py |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/lib/bb/event.py b/lib/bb/event.py
>> index bbece58..f3fb521 100644
>> --- a/lib/bb/event.py
>> +++ b/lib/bb/event.py
>> @@ -517,3 +517,13 @@ class PackageInfo(Event):
>>     def __init__(self, pkginfolist):
>>         Event.__init__(self)
>>         self._pkginfolist = pkginfolist
>> +
>> +class SanityCheck(Event):
>> +    """
>> +    Event to issue sanity check
>> +    """
>> +
>> +class SanityCheckPassed(Event):
>> +    """
>> +    Event to indicate sanity check is passed
>> +    """
>
> Sanity checking is not part of bitbake, nor does it belong there. I'd
> say to find another way to do this.

Erm, ignore this, I was obviously mistaken. I had no idea any of this
code existed. It does seem pretty questionable, still. 'sanity check'
is extremely vague, and unclear about what it does, and further, the
terminology overlaps with the various checks in the metadata. At a
minimum I'd think we should improve this naming.

Patch

diff --git a/lib/bb/event.py b/lib/bb/event.py
index bbece58..f3fb521 100644
--- a/lib/bb/event.py
+++ b/lib/bb/event.py
@@ -517,3 +517,13 @@  class PackageInfo(Event):
     def __init__(self, pkginfolist):
         Event.__init__(self)
         self._pkginfolist = pkginfolist
+
+class SanityCheck(Event):
+    """
+    Event to issue sanity check
+    """
+
+class SanityCheckPassed(Event):
+    """
+    Event to indicate sanity check is passed
+    """