Patchwork [CONSOLIDATED,PULL,02/43] rt-tests: fix dependency on eglibc, clean LDFLAGS passing

login
mail settings
Submitter Saul Wold
Date April 20, 2012, 4:44 p.m.
Message ID <d2330607b1757ad68add6ab2b37c6182b4f28d00.1334940120.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/26257/
State New
Headers show

Comments

Saul Wold - April 20, 2012, 4:44 p.m.
From: Denys Dmytriyenko <denys@ti.com>

Replace dependency on eglibc with virtual/libc
Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta/recipes-rt/rt-tests/rt-tests_0.83.bb |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Denys Dmytriyenko - April 20, 2012, 8:04 p.m.
On Fri, Apr 20, 2012 at 09:44:53AM -0700, Saul Wold wrote:
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Replace dependency on eglibc with virtual/libc
> Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>

That's already been fixed differently:
http://cgit.openembedded.org/openembedded-core/commit/?id=fb89e4585644db0958a633a637fc70f0459af26a
Saul Wold - April 20, 2012, 8:10 p.m.
On 04/20/2012 01:04 PM, Denys Dmytriyenko wrote:
> On Fri, Apr 20, 2012 at 09:44:53AM -0700, Saul Wold wrote:
>> From: Denys Dmytriyenko<denys@ti.com>
>>
>> Replace dependency on eglibc with virtual/libc
>> Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it
>>
>> Signed-off-by: Denys Dmytriyenko<denys@ti.com>
>
> That's already been fixed differently:
> http://cgit.openembedded.org/openembedded-core/commit/?id=fb89e4585644db0958a633a637fc70f0459af26a
>
Thanks, I had it in my holding bin and must have just not matched up 
with this patch.

I will update my branch with this removed.

Sau!

Patch

diff --git a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
index 6c4931e..e38ada9 100644
--- a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
+++ b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
@@ -18,8 +18,7 @@  SRC_URI = "git://github.com/clrkwllms/rt-tests.git \
 
 S = "${WORKDIR}/git"
 
-# need to append rt-tests' default CFLAGS to ours
-CFLAGS += "-I${S}/src/include -D_GNU_SOURCE -Wall -Wno-nonnulli"
+TARGET_CC_ARCH += "${LDFLAGS}"
 
 # calling 'uname -m' is broken on crossbuilds
 EXTRA_OEMAKE = "NUMA=0"