Patchwork package.bbclass: Ensure kernel modules get stripped

login
register
mail settings
Submitter Richard Purdie
Date April 19, 2012, 12:17 p.m.
Message ID <1334837877.13017.0.camel@ted>
Download mbox | patch
Permalink /patch/26157/
State Accepted
Commit 00b0a5f2f51bb3f88bbb9ae558c2859e3c1c406c
Headers show

Comments

Richard Purdie - April 19, 2012, 12:17 p.m.
Kernel modules are not marked as executable but we do expect to strip them.
This patch adds in missing code to ensure we do this. Without this images
are getting sigificantly bloated in size.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Eric BENARD - April 19, 2012, 12:29 p.m.
Le Thu, 19 Apr 2012 13:17:57 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :

> Kernel modules are not marked as executable but we do expect to strip them.
> This patch adds in missing code to ensure we do this. Without this images
> are getting sigificantly bloated in size.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

cool, that explains why I had a 190 MB modules.tar.bz2 when building a
test image for a Pandaboard last weekend ;-)

Eric

Patch

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index c3f077a..44e551f 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -870,6 +870,14 @@  python split_and_strip_files () {
 				elf_file = int(file_list[file][5:])
 				#bb.note("Strip %s" % file)
 				runstrip(file, elf_file, d)
+
+
+	if (d.getVar('INHIBIT_PACKAGE_STRIP', True) != '1'):	
+		for root, dirs, files in os.walk(dvar):
+			for f in files:
+				if not f.endswith(".ko"):
+					continue
+				runstrip(os.path.join(root, f), None, d)
 	#
 	# End of strip
 	#