Patchwork [1/1] gthumb: Disable parallel make for gthumb install

login
register
mail settings
Submitter Darren Hart
Date April 18, 2012, 3:40 p.m.
Message ID <5840692e28971d911b9c95eb85c2aff0eb028e3c.1334763599.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/26133/
State Accepted
Commit 01e14ae25c133e46603d01a72d0372c111e12f11
Headers show

Comments

Darren Hart - April 18, 2012, 3:40 p.m.
With PARALLEL_MAKE set to 14, I frequently see the gthumb do_install
task hang. Make is spinning at 100% CPU and the build makes no
more progress.

The following work-around proposed by Richard Purdie allows progress
to be made.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Joshua Lock <josh@linux.intel.com>
CC: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-gnome/gthumb/gthumb_2.12.4.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Darren Hart - April 18, 2012, 3:50 p.m.
On 04/18/2012 08:40 AM, Darren Hart wrote:
> With PARALLEL_MAKE set to 14, I frequently see the gthumb do_install
> task hang. Make is spinning at 100% CPU and the build makes no
> more progress.
> 
> The following work-around proposed by Richard Purdie allows progress
> to be made.

Ooops, forgot to add:

Fixes [YOCTO #2319]

> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Joshua Lock <josh@linux.intel.com>
> CC: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-gnome/gthumb/gthumb_2.12.4.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> index 5c87dc1..5821dc4 100644
> --- a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> +++ b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> @@ -8,6 +8,8 @@ PR = "r2"
>  
>  EXTRA_OECONF = "--disable-gnome-keyring --disable-libsoup --disable-exiv2 --disable-clutter"
>  
> +PARALLEL_MAKEINST=""
> +
>  inherit gnome pkgconfig
>  
>  FILES_${PN} += "${datadir}/icons"
Joshua Lock - April 18, 2012, 3:52 p.m.
On 18/04/12 08:40, Darren Hart wrote:
> With PARALLEL_MAKE set to 14, I frequently see the gthumb do_install
> task hang. Make is spinning at 100% CPU and the build makes no
> more progress.
>
> The following work-around proposed by Richard Purdie allows progress
> to be made.
>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Joshua Lock<josh@linux.intel.com>
> CC: Richard Purdie<richard.purdie@linuxfoundation.org>

Signed-off-by: Joshua Lock <josh@linux.intel.com>

Can you confirm whether the issues you're seeing are the same as in #2245?

https://bugzilla.yoctoproject.org/show_bug.cgi?id=2245

I was looking at a proper fix yesterday but may need to use your beast 
to reproduce and test.

Cheers,
Joshua

> ---
>   meta/recipes-gnome/gthumb/gthumb_2.12.4.bb |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> index 5c87dc1..5821dc4 100644
> --- a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> +++ b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
> @@ -8,6 +8,8 @@ PR = "r2"
>
>   EXTRA_OECONF = "--disable-gnome-keyring --disable-libsoup --disable-exiv2 --disable-clutter"
>
> +PARALLEL_MAKEINST=""
> +
>   inherit gnome pkgconfig
>
>   FILES_${PN} += "${datadir}/icons"
Darren Hart - April 18, 2012, 3:54 p.m.
On 04/18/2012 08:52 AM, Joshua Lock wrote:
> 
> 
> On 18/04/12 08:40, Darren Hart wrote:
>> With PARALLEL_MAKE set to 14, I frequently see the gthumb do_install
>> task hang. Make is spinning at 100% CPU and the build makes no
>> more progress.
>>
>> The following work-around proposed by Richard Purdie allows progress
>> to be made.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Joshua Lock<josh@linux.intel.com>
>> CC: Richard Purdie<richard.purdie@linuxfoundation.org>
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> 
> Can you confirm whether the issues you're seeing are the same as in #2245?
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=2245
> 

I haven't seen those particular errors, but will follow-up in the bug.

--
Darren

> I was looking at a proper fix yesterday but may need to use your beast 
> to reproduce and test.
> 
> Cheers,
> Joshua
> 
>> ---
>>   meta/recipes-gnome/gthumb/gthumb_2.12.4.bb |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> index 5c87dc1..5821dc4 100644
>> --- a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> +++ b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> @@ -8,6 +8,8 @@ PR = "r2"
>>
>>   EXTRA_OECONF = "--disable-gnome-keyring --disable-libsoup --disable-exiv2 --disable-clutter"
>>
>> +PARALLEL_MAKEINST=""
>> +
>>   inherit gnome pkgconfig
>>
>>   FILES_${PN} += "${datadir}/icons"
>

Patch

diff --git a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
index 5c87dc1..5821dc4 100644
--- a/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
+++ b/meta/recipes-gnome/gthumb/gthumb_2.12.4.bb
@@ -8,6 +8,8 @@  PR = "r2"
 
 EXTRA_OECONF = "--disable-gnome-keyring --disable-libsoup --disable-exiv2 --disable-clutter"
 
+PARALLEL_MAKEINST=""
+
 inherit gnome pkgconfig
 
 FILES_${PN} += "${datadir}/icons"