Patchwork [16/17] lrzsz: sz, sx and sb were linked incorrectly

login
register
mail settings
Submitter Mark Hatle
Date April 16, 2012, 11:16 p.m.
Message ID <4da378412f0dceff4b3c3757a185ffa67997599c.1334616144.git.mark.hatle@windriver.com>
Download mbox | patch
Permalink /patch/26007/
State Accepted
Commit 663b608357b86aba5cdf7f07291893725e579b75
Headers show

Comments

Mark Hatle - April 16, 2012, 11:16 p.m.
The sz, sx and sb links were created incorrectly to lrz, they should
point to lsz.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
 meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)
Mark Hatle - April 17, 2012, 5:03 p.m.
Just wanted to highlight this patch.  It should probably go into oe-core before 
the freeze, as the existing lrzsz package is completely broken.  (None of the 
send functions are linked properly and will fail to work.)

Since nobody has reported this, I do find it highly suspect this this component 
is even being used these days.

--Mark

On 4/16/12 6:16 PM, Mark Hatle wrote:
> The sz, sx and sb links were created incorrectly to lrz, they should
> point to lsz.
>
> Signed-off-by: Mark Hatle<mark.hatle@windriver.com>
> ---
>   meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb |   12 +++++++++---
>   1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> index 414f2f4..7f86157 100644
> --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>   			file://src/lrz.c;beginline=1;endline=10;md5=5276956373ff7d8758837f6399a1045f"
>   SECTION = "console/network"
>   DEPENDS = ""
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
>   	   file://autotools.patch \
> @@ -28,13 +28,19 @@ do_install() {
>   }
>
>   pkg_postinst_${PN}() {
> -	for util in rz rx rb sz sx sb; do
> +	for util in rz rx rb; do
>   		update-alternatives --install ${bindir}/$util $util lrz 100
>   	done
> +	for util in sz sx sb; do
> +		update-alternatives --install ${bindir}/$util $util lsz 100
> +	done
>   }
>
>   pkg_postrm_${PN}() {
> -	for util in rz rx rb sz sx sb; do
> +	for util in rz rx rb; do
>   		update-alternatives --remove $util ${bindir}/lrz
>   	done
> +	for util sz sx sb; do
> +		update-alternatives --remove $util ${bindir}/lsz
> +	done
>   }

Patch

diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
index 414f2f4..7f86157 100644
--- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
+++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
@@ -10,7 +10,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
 			file://src/lrz.c;beginline=1;endline=10;md5=5276956373ff7d8758837f6399a1045f"
 SECTION = "console/network"
 DEPENDS = ""
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
 	   file://autotools.patch \
@@ -28,13 +28,19 @@  do_install() {
 }
 
 pkg_postinst_${PN}() {
-	for util in rz rx rb sz sx sb; do
+	for util in rz rx rb; do
 		update-alternatives --install ${bindir}/$util $util lrz 100
 	done
+	for util in sz sx sb; do
+		update-alternatives --install ${bindir}/$util $util lsz 100
+	done
 }
 
 pkg_postrm_${PN}() {
-	for util in rz rx rb sz sx sb; do
+	for util in rz rx rb; do
 		update-alternatives --remove $util ${bindir}/lrz
 	done
+	for util sz sx sb; do
+		update-alternatives --remove $util ${bindir}/lsz
+	done
 }