Patchwork [bitbake-devel,1/1] Hob: fixed a little view issue about package selection page

login
register
mail settings
Submitter An, LimingX L
Date April 16, 2012, 10:09 a.m.
Message ID <cb025c92d54ad2f20abc15f81d89fb26bf7dd65c.1334570665.git.limingx.l.an@intel.com>
Download mbox | patch
Permalink /patch/25923/
State New
Headers show

Comments

An, LimingX L - April 16, 2012, 10:09 a.m.
In package selection page, treeview cell data callback function not cover the 'else' case, so parent item will render the pervious value.

Signed-off-by: Liming An <limingx.l.an@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Joshua Lock - April 16, 2012, 4:21 p.m.
On 16/04/12 03:09, Liming An wrote:
> In package selection page, treeview cell data callback function not cover the 'else' case, so parent item will render the pervious value.
>
> Signed-off-by: Liming An<limingx.l.an@intel.com>

Good catch, thanks!

Signed-off-by: Joshua Lock<josh@linux.intel.com>

> ---
>   bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py
> index a42cdec..8cbd6aa 100644
> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py
> +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py
> @@ -175,7 +175,8 @@ class HobViewTable (gtk.VBox):
>           if binb:
>               bin = binb.split(', ')
>               cell.set_property('text', bin[0])
> -
> +        else:
> +            cell.set_property('text', "")
>           return True
>
>       def set_model(self, tree_model):

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py
index a42cdec..8cbd6aa 100644
--- a/bitbake/lib/bb/ui/crumbs/hobwidget.py
+++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py
@@ -175,7 +175,8 @@  class HobViewTable (gtk.VBox):
         if binb:
             bin = binb.split(', ')
             cell.set_property('text', bin[0])
-
+        else:
+            cell.set_property('text', "")
         return True
 
     def set_model(self, tree_model):