Patchwork librsvg 2.32.1: fix postinst script

login
register
mail settings
Submitter Koen Kooi
Date April 21, 2011, 12:21 p.m.
Message ID <1303388485-25698-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/2581/
State New, archived
Headers show

Comments

Koen Kooi - April 21, 2011, 12:21 p.m.
The symptom:

root@pandaboard-core:~# sh /var/lib/opkg/info/librsvg-2-gtk.postinst
g_module_open() failed for /home/root/--update-cache: /home/root/--update-cache.so: cannot open shared object file: No such file or directory
root@pandaboard-core:~#

the gdk-pixbuf-query-loaders app doesn't support arguments, only .so names, so remove --update-cache

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-gnome/librsvg/librsvg_2.32.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - April 21, 2011, 12:31 p.m.
On Thu, Apr 21, 2011 at 02:21:25PM +0200, Koen Kooi wrote:
> The symptom:
> 
> root@pandaboard-core:~# sh /var/lib/opkg/info/librsvg-2-gtk.postinst
> g_module_open() failed for /home/root/--update-cache: /home/root/--update-cache.so: cannot open shared object file: No such file or directory
> root@pandaboard-core:~#
> 
> the gdk-pixbuf-query-loaders app doesn't support arguments, only .so names, so remove --update-cache

I can confirm same symptom here

shouldn't we store output from it as we did in oe.dev to
/etc/gtk-2.0/gdk-pixbuf.loaders ?

> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/recipes-gnome/librsvg/librsvg_2.32.1.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> index ea9456d..08ac01d 100644
> --- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> +++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>  SECTION = "x11/utils"
>  DEPENDS = "gtk+ libcroco cairo libxml2 popt"
>  
> -PR = "r0"
> +PR = "r1"
>  
>  inherit autotools pkgconfig gnome
>  
> @@ -43,6 +43,6 @@ if [ "x$D" != "x" ]; then
>    exit 1
>  fi
>  
> -test -x ${bindir}/gdk-pixbuf-query-loaders && { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders --update-cache ; }
> +test -x ${bindir}/gdk-pixbuf-query-loaders && { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders ; }
>  test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
>  }
> -- 
> 1.6.6.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - April 21, 2011, 12:43 p.m.
Op 21 apr 2011, om 14:31 heeft Martin Jansa het volgende geschreven:

> On Thu, Apr 21, 2011 at 02:21:25PM +0200, Koen Kooi wrote:
>> The symptom:
>> 
>> root@pandaboard-core:~# sh /var/lib/opkg/info/librsvg-2-gtk.postinst
>> g_module_open() failed for /home/root/--update-cache: /home/root/--update-cache.so: cannot open shared object file: No such file or directory
>> root@pandaboard-core:~#
>> 
>> the gdk-pixbuf-query-loaders app doesn't support arguments, only .so names, so remove --update-cache
> 
> I can confirm same symptom here
> 
> shouldn't we store output from it as we did in oe.dev to
> /etc/gtk-2.0/gdk-pixbuf.loaders ?

I think we do :) Let's see if other requests come in before I respin it.

regards,

Koen
Koen Kooi - April 21, 2011, 1:31 p.m.
Op 21 apr 2011, om 14:43 heeft Koen Kooi het volgende geschreven:

> 
> Op 21 apr 2011, om 14:31 heeft Martin Jansa het volgende geschreven:
> 
>> On Thu, Apr 21, 2011 at 02:21:25PM +0200, Koen Kooi wrote:
>>> The symptom:
>>> 
>>> root@pandaboard-core:~# sh /var/lib/opkg/info/librsvg-2-gtk.postinst
>>> g_module_open() failed for /home/root/--update-cache: /home/root/--update-cache.so: cannot open shared object file: No such file or directory
>>> root@pandaboard-core:~#
>>> 
>>> the gdk-pixbuf-query-loaders app doesn't support arguments, only .so names, so remove --update-cache
>> 
>> I can confirm same symptom here
>> 
>> shouldn't we store output from it as we did in oe.dev to
>> /etc/gtk-2.0/gdk-pixbuf.loaders ?
> 
> I think we do :) Let's see if other requests come in before I respin it.

So Martin and I talked a bit on IRC and we noticed a problem:

root@pandaboard-core:/etc/gtk-2.0# find /usr/lib | grep libpixbufloader
/usr/lib/gtk-2.0/2.10.0/loaders/libpixbufloader-xpm.so
/usr/lib/gtk-2.0/2.10.0/loaders/libpixbufloader-jpeg.so
/usr/lib/gtk-2.0/2.10.0/loaders/libpixbufloader-svg.so
/usr/lib/gtk-2.0/2.10.0/loaders/libpixbufloader-gif.so
/usr/lib/gtk-2.0/2.10.0/loaders/libpixbufloader-png.so
root@pandaboard-core:/etc/gtk-2.0# 

On Martins system those are in /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders. So the postinst script needs to know where to look. Do we want to provide backward compatibility for older gtk releases with an extra if statement?

regards,

Koen
Saul Wold - April 25, 2011, 4:22 a.m.
On 04/21/2011 05:21 AM, Koen Kooi wrote:
> The symptom:
>
> root@pandaboard-core:~# sh /var/lib/opkg/info/librsvg-2-gtk.postinst
> g_module_open() failed for /home/root/--update-cache: /home/root/--update-cache.so: cannot open shared object file: No such file or directory
> root@pandaboard-core:~#
>
> the gdk-pixbuf-query-loaders app doesn't support arguments, only .so names, so remove --update-cache
>
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/recipes-gnome/librsvg/librsvg_2.32.1.bb |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> index ea9456d..08ac01d 100644
> --- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> +++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>   SECTION = "x11/utils"
>   DEPENDS = "gtk+ libcroco cairo libxml2 popt"
>
> -PR = "r0"
> +PR = "r1"
>
>   inherit autotools pkgconfig gnome
>
> @@ -43,6 +43,6 @@ if [ "x$D" != "x" ]; then
>     exit 1
>   fi
>
> -test -x ${bindir}/gdk-pixbuf-query-loaders&&  { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders --update-cache ; }
> +test -x ${bindir}/gdk-pixbuf-query-loaders&&  { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders ; }
>   test -x ${bindir}/gtk-update-icon-cache&&  gtk-update-icon-cache  -q ${datadir}/icons/hicolor
>   }
Pulled into OE-Core and Poky/Master

Thanks
	Sau!

Patch

diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
index ea9456d..08ac01d 100644
--- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
+++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 SECTION = "x11/utils"
 DEPENDS = "gtk+ libcroco cairo libxml2 popt"
 
-PR = "r0"
+PR = "r1"
 
 inherit autotools pkgconfig gnome
 
@@ -43,6 +43,6 @@  if [ "x$D" != "x" ]; then
   exit 1
 fi
 
-test -x ${bindir}/gdk-pixbuf-query-loaders && { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders --update-cache ; }
+test -x ${bindir}/gdk-pixbuf-query-loaders && { GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders ; }
 test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
 }