| Submitter | Joshua Lock |
|---|---|
| Date | April 13, 2012, 11:24 p.m. |
| Message ID | <cover.1334359238.git.josh@linux.intel.com> |
| Download | mbox |
| Permalink | /patch/25779/ |
| State | New |
| Headers | show |
Pull-request
git://github.com/incandescant/bitbake gtk2.20Comments
On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote: > *** This series prevents users of distros with old Gtk+ releases using Hob *** > > This is a follow-on from my RFC of yesterday with a similar title. Sadly I > hadn't realised that one of the API calls I am using is not available in the > version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). > > This change will prevent CentOS 6 users from being able to use Hob. > > I spent some time in Gtk+ internals trying to figure out if we can emulate the > behaviour on older versions but the GtkNotebook widget internals were enhanced > significantly to support the set_action_widget API. > > I've submitted the change as an RFC regardless, it's ready to merge if we're > willing to make the sacrifice. > > The primary motivation for making this change, and making it so late in the > cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC > custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit > widgets. > > An added benefit is that standard toolkit widgets generally integrate better > into the users OS thanks to inheriting their standard theme. > > Tested on: > Fedora 16 (x86_64) - PASS > CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old > Ubuntu 10.04 (x86_64) - Fail: pygtk version too old > Ubuntu 12.04 Beta (x86_64) - PASS > > Per the final patch in the series the changes here require gtk+-2.20 or newer > and pygtk 2.22 or newer. Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release. Cheers, Richard
On 14/04/12 03:23, Richard Purdie wrote: > On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote: >> *** This series prevents users of distros with old Gtk+ releases using Hob *** >> >> This is a follow-on from my RFC of yesterday with a similar title. Sadly I >> hadn't realised that one of the API calls I am using is not available in the >> version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). >> >> This change will prevent CentOS 6 users from being able to use Hob. >> >> I spent some time in Gtk+ internals trying to figure out if we can emulate the >> behaviour on older versions but the GtkNotebook widget internals were enhanced >> significantly to support the set_action_widget API. >> >> I've submitted the change as an RFC regardless, it's ready to merge if we're >> willing to make the sacrifice. >> >> The primary motivation for making this change, and making it so late in the >> cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC >> custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit >> widgets. >> >> An added benefit is that standard toolkit widgets generally integrate better >> into the users OS thanks to inheriting their standard theme. >> >> Tested on: >> Fedora 16 (x86_64) - PASS >> CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old >> Ubuntu 10.04 (x86_64) - Fail: pygtk version too old >> Ubuntu 12.04 Beta (x86_64) - PASS >> >> Per the final patch in the series the changes here require gtk+-2.20 or newer >> and pygtk 2.22 or newer. > > Since we don't have a good external-python tarball solution in place > yet, I'm going to have to hold off these patches until after the current > release. This makes perfect sense and I agree with the decision. Thanks, Joshua
Hi Richard, There are still some issues in these patches, but I think we can check in first and I also have some fixes which depends on the check-in. I will submit the patches to fix them as long as they are pulled in. Please to review. Thanks! -- Liming -----Original Message----- From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Richard Purdie Sent: Saturday, April 14, 2012 6:23 PM To: Joshua Lock Cc: bitbake-devel@lists.openembedded.org Subject: Re: [bitbake-devel] [PATCH 0/4] Replace HobNotebook with gtk.Notebook, comments invited On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote: > *** This series prevents users of distros with old Gtk+ releases using > Hob *** > > This is a follow-on from my RFC of yesterday with a similar title. > Sadly I hadn't realised that one of the API calls I am using is not > available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). > > This change will prevent CentOS 6 users from being able to use Hob. > > I spent some time in Gtk+ internals trying to figure out if we can > emulate the behaviour on older versions but the GtkNotebook widget > internals were enhanced significantly to support the set_action_widget API. > > I've submitted the change as an RFC regardless, it's ready to merge if > we're willing to make the sacrifice. > > The primary motivation for making this change, and making it so late > in the cycle, is maintainability. The diffstat says it all - we're > replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets > which subclass standard toolkit widgets. > > An added benefit is that standard toolkit widgets generally integrate > better into the users OS thanks to inheriting their standard theme. > > Tested on: > Fedora 16 (x86_64) - PASS > CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) > - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASS > > Per the final patch in the series the changes here require gtk+-2.20 > or newer and pygtk 2.22 or newer. Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release. Cheers, Richard
Hi Joshua, Sorry for my reply is so late. I know it will be concerned in the version 1.3. I had tested your patches in 'poky-contrib/josh/hob_next', It's has the same functions as our current version, I agree to merge to current version. Thanks -- Liming -----Original Message----- From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Joshua Lock Sent: Sunday, April 15, 2012 3:44 AM To: Richard Purdie Cc: bitbake-devel@lists.openembedded.org Subject: Re: [bitbake-devel] [PATCH 0/4] Replace HobNotebook with gtk.Notebook, comments invited On 14/04/12 03:23, Richard Purdie wrote: > On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote: >> *** This series prevents users of distros with old Gtk+ releases >> using Hob *** >> >> This is a follow-on from my RFC of yesterday with a similar title. >> Sadly I hadn't realised that one of the API calls I am using is not >> available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). >> >> This change will prevent CentOS 6 users from being able to use Hob. >> >> I spent some time in Gtk+ internals trying to figure out if we can >> emulate the behaviour on older versions but the GtkNotebook widget >> internals were enhanced significantly to support the set_action_widget API. >> >> I've submitted the change as an RFC regardless, it's ready to merge >> if we're willing to make the sacrifice. >> >> The primary motivation for making this change, and making it so late >> in the cycle, is maintainability. The diffstat says it all - we're >> replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets >> which subclass standard toolkit widgets. >> >> An added benefit is that standard toolkit widgets generally integrate >> better into the users OS thanks to inheriting their standard theme. >> >> Tested on: >> Fedora 16 (x86_64) - PASS >> CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 >> (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - >> PASS >> >> Per the final patch in the series the changes here require gtk+-2.20 >> or newer and pygtk 2.22 or newer. > > Since we don't have a good external-python tarball solution in place > yet, I'm going to have to hold off these patches until after the > current release. This makes perfect sense and I agree with the decision. Thanks, Joshua -- Joshua Lock Yocto Project Intel Open Source Technology Centre
On Sat, 2012-04-14 at 11:23 +0100, Richard Purdie wrote: > On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote: > > *** This series prevents users of distros with old Gtk+ releases using Hob *** > > > > This is a follow-on from my RFC of yesterday with a similar title. Sadly I > > hadn't realised that one of the API calls I am using is not available in the > > version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). > > > > This change will prevent CentOS 6 users from being able to use Hob. > > > > I spent some time in Gtk+ internals trying to figure out if we can emulate the > > behaviour on older versions but the GtkNotebook widget internals were enhanced > > significantly to support the set_action_widget API. > > > > I've submitted the change as an RFC regardless, it's ready to merge if we're > > willing to make the sacrifice. > > > > The primary motivation for making this change, and making it so late in the > > cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC > > custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit > > widgets. > > > > An added benefit is that standard toolkit widgets generally integrate better > > into the users OS thanks to inheriting their standard theme. > > > > Tested on: > > Fedora 16 (x86_64) - PASS > > CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old > > Ubuntu 10.04 (x86_64) - Fail: pygtk version too old > > Ubuntu 12.04 Beta (x86_64) - PASS > > > > Per the final patch in the series the changes here require gtk+-2.20 or newer > > and pygtk 2.22 or newer. > > Since we don't have a good external-python tarball solution in place > yet, I'm going to have to hold off these patches until after the current > release. I've not gone ahead and merged these since they still seem to apply and basically worked when I tested them just now. Cheers, Richard
On Thu, 2012-05-10 at 06:31 +0000, An, LimingX L wrote: > Hi Richard, > > There are still some issues in these patches, but I think we can check > in first and I also have some fixes which depends on the check-in. I > will submit the patches to fix them as long as they are pulled in. > > Please to review. Thanks! I've merged this, please send the other fixes for review. Cheers, Richard
Josh, I just found I can't run Hob on my Ubuntu 10.04 after I checked out the latest master. Since Ubuntu 10.04 is a long-term-support version, can we do something to make Hob compatible with that? What kind of failure did you meet on Ubuntu 10.04? -- Shane Joshua Lock wrote on 2012-04-14: > *** This series prevents users of distros with old Gtk+ releases using Hob *** > > This is a follow-on from my RFC of yesterday with a similar title. Sadly I > hadn't realised that one of the API calls I am using is not available in the > version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). > > This change will prevent CentOS 6 users from being able to use Hob. > > I spent some time in Gtk+ internals trying to figure out if we can > emulate the behaviour on older versions but the GtkNotebook widget > internals were enhanced significantly to support the set_action_widget > API. > > I've submitted the change as an RFC regardless, it's ready to merge if we're > willing to make the sacrifice. > > The primary motivation for making this change, and making it so late in > the cycle, is maintainability. The diffstat says it all - we're > replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which > subclass standard toolkit widgets. > > An added benefit is that standard toolkit widgets generally integrate better > into the users OS thanks to inheriting their standard theme. > > Tested on: > Fedora 16 (x86_64) - PASS > CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old > Ubuntu 10.04 (x86_64) - Fail: pygtk version too old > Ubuntu 12.04 Beta (x86_64) - PASS > > Per the final patch in the series the changes here require gtk+-2.20 or newer > and pygtk 2.22 or newer. > > Cheers, > Joshua > > The following changes since commit > 434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892: > > Hob: Added required packages for toolchain. (2012-04-13 12:00:12 +0100) > are available in the git repository at: > git://github.com/incandescant/bitbake gtk2.20 > https://github.com/incandescant/bitbake/tree/gtk2.20 > Joshua Lock (4): > lib/bb/ui/crumbs/: replace custom HobNotebook > lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator > lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width > hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0 > lib/bb/ui/crumbs/builddetailspage.py | 6 +- > lib/bb/ui/crumbs/hobwidget.py | 499 > +++++++--------------------- lib/bb/ui/crumbs/imageconfigurationpage.py > | 2 - lib/bb/ui/crumbs/packageselectionpage.py | 3 +- > lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- lib/bb/ui/hob.py > | 2 +- 6 files changed, 120 insertions(+), > 397 deletions(-)
Hi Shane, On 22/05/12 18:35, Wang, Shane wrote: > Josh, I just found I can't run Hob on my Ubuntu 10.04 after I checked out the latest master. > > Since Ubuntu 10.04 is a long-term-support version, can we do something to make Hob compatible with that? The plan is to provide an external-python-tarball with a full Gtk+ & PyGtk nativesdk stack built by OE-Core/Poky and installed into a standalone sysroot on the users host. Whilst I have a branch based on some work by Richard to achieve this it hasn't been submitted to upstream as I haven't figured out a clean way to handle things on the SDK host which would usually require a postinstall in the target rootfs. Aside: I really can't see a clean way around requiring postinst type functionality for the SDK targets, particularly in the pagno case here. I'm currently ruminating on supercharging the toolchain scripts to handle this. > What kind of failure did you meet on Ubuntu 10.04? IIRC the set_action_widget() API I referred to in the original email isn't available in the version of Gtk+ and PyGtk that was shipped with Ubuntu 10.04. This is required to add the search entry to the gtk.Notebook. Cheers, Joshua > > -- > Shane > > Joshua Lock wrote on 2012-04-14: > >> *** This series prevents users of distros with old Gtk+ releases using Hob *** >> >> This is a follow-on from my RFC of yesterday with a similar title. Sadly I >> hadn't realised that one of the API calls I am using is not available in the >> version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget). >> >> This change will prevent CentOS 6 users from being able to use Hob. >> >> I spent some time in Gtk+ internals trying to figure out if we can >> emulate the behaviour on older versions but the GtkNotebook widget >> internals were enhanced significantly to support the set_action_widget >> API. >> >> I've submitted the change as an RFC regardless, it's ready to merge if we're >> willing to make the sacrifice. >> >> The primary motivation for making this change, and making it so late in >> the cycle, is maintainability. The diffstat says it all - we're >> replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which >> subclass standard toolkit widgets. >> >> An added benefit is that standard toolkit widgets generally integrate better >> into the users OS thanks to inheriting their standard theme. >> >> Tested on: >> Fedora 16 (x86_64) - PASS >> CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old >> Ubuntu 10.04 (x86_64) - Fail: pygtk version too old >> Ubuntu 12.04 Beta (x86_64) - PASS >> >> Per the final patch in the series the changes here require gtk+-2.20 or newer >> and pygtk 2.22 or newer. >> >> Cheers, >> Joshua >> >> The following changes since commit >> 434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892: >> >> Hob: Added required packages for toolchain. (2012-04-13 12:00:12 +0100) >> are available in the git repository at: >> git://github.com/incandescant/bitbake gtk2.20 >> https://github.com/incandescant/bitbake/tree/gtk2.20 >> Joshua Lock (4): >> lib/bb/ui/crumbs/: replace custom HobNotebook >> lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator >> lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width >> hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0 >> lib/bb/ui/crumbs/builddetailspage.py | 6 +- >> lib/bb/ui/crumbs/hobwidget.py | 499 >> +++++++--------------------- lib/bb/ui/crumbs/imageconfigurationpage.py >> | 2 - lib/bb/ui/crumbs/packageselectionpage.py | 3 +- >> lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- lib/bb/ui/hob.py >> | 2 +- 6 files changed, 120 insertions(+), >> 397 deletions(-) >