Patchwork [bitbake-devel,RFC,0/3] Replace HobNotebook with gtk.Notebook

login
mail settings
Submitter Joshua Lock
Date April 13, 2012, 12:10 a.m.
Message ID <cover.1334275549.git.josh@linux.intel.com>
Download mbox
Permalink /patch/25707/
State New
Headers show

Pull-request

git://github.com/incandescant/bitbake josh/hob

Comments

Joshua Lock - April 13, 2012, 12:10 a.m.
The important patch in this RFC is the first which replaces the fully custom
HobNotebook with a simpler gtk.Notebook subclass.

It's an RFC as there's currently what looks like a rendering glitch in how the
tabs are displayed. See the white boxes in the tabs of this screenshot:
https://bugzilla.yoctoproject.org/attachment.cgi?id=465

I'm researching how to remove this artifact but wanted to gather feedback on the
patch as it stands as we are close to the checkin deadline.

Thanks,
Joshua

The following changes since commit 3c2808b67384e92601cbd66877c36ca40df7c7ba:

  Hob: fix the missing functions (2012-04-12 15:56:42 +0100)

are available in the git repository at:
  git://github.com/incandescant/bitbake josh/hob
  https://github.com/incandescant/bitbake/tree/josh/hob

Joshua Lock (3):
  lib/bb/ui/crumbs/: replace custom HobNotebook
  lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator
  lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width

 lib/bb/ui/crumbs/builddetailspage.py       |    4 +-
 lib/bb/ui/crumbs/hobwidget.py              |  468 +++++-----------------------
 lib/bb/ui/crumbs/imageconfigurationpage.py |    2 -
 lib/bb/ui/crumbs/packageselectionpage.py   |    3 +-
 lib/bb/ui/crumbs/recipeselectionpage.py    |    5 +-
 5 files changed, 82 insertions(+), 400 deletions(-)
Joshua Lock - April 13, 2012, 5:10 p.m.
I've figured out how to composite things so the artefact is gone. 
Updated patchset shortly!

Thanks,
Joshua

On 12/04/12 17:10, Joshua Lock wrote:
> The important patch in this RFC is the first which replaces the fully custom
> HobNotebook with a simpler gtk.Notebook subclass.
>
> It's an RFC as there's currently what looks like a rendering glitch in how the
> tabs are displayed. See the white boxes in the tabs of this screenshot:
> https://bugzilla.yoctoproject.org/attachment.cgi?id=465
>
> I'm researching how to remove this artifact but wanted to gather feedback on the
> patch as it stands as we are close to the checkin deadline.
>
> Thanks,
> Joshua
>
> The following changes since commit 3c2808b67384e92601cbd66877c36ca40df7c7ba:
>
>    Hob: fix the missing functions (2012-04-12 15:56:42 +0100)
>
> are available in the git repository at:
>    git://github.com/incandescant/bitbake josh/hob
>    https://github.com/incandescant/bitbake/tree/josh/hob
>
> Joshua Lock (3):
>    lib/bb/ui/crumbs/: replace custom HobNotebook
>    lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator
>    lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width
>
>   lib/bb/ui/crumbs/builddetailspage.py       |    4 +-
>   lib/bb/ui/crumbs/hobwidget.py              |  468 +++++-----------------------
>   lib/bb/ui/crumbs/imageconfigurationpage.py |    2 -
>   lib/bb/ui/crumbs/packageselectionpage.py   |    3 +-
>   lib/bb/ui/crumbs/recipeselectionpage.py    |    5 +-
>   5 files changed, 82 insertions(+), 400 deletions(-)
>