| Submitter | ml@communistcode.co.uk |
|---|---|
| Date | April 12, 2012, 1:42 p.m. |
| Message ID | <1334238147-15338-1-git-send-email-ml@communistcode.co.uk> |
| Download | mbox | patch |
| Permalink | /patch/25671/ |
| State | New |
| Headers | show |
Comments
Op 12 apr. 2012, om 15:42 heeft ml@communistcode.co.uk het volgende geschreven: > From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk> > > Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk> > --- > meta-oe/recipes-support/jansson/jansson.inc | 8 ++++++++ > meta-oe/recipes-support/jansson/jansson_2.3.bb | 4 ++++ I'll ask the standard question: why is this needed in oe-core? regards, Koen
On 12/04/12 15:08, Koen Kooi wrote: > Op 12 apr. 2012, om 15:42 heeft ml@communistcode.co.uk het volgende geschreven: > >> From: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >> >> Signed-off-by: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >> --- >> meta-oe/recipes-support/jansson/jansson.inc | 8 ++++++++ >> meta-oe/recipes-support/jansson/jansson_2.3.bb | 4 ++++ > I'll ask the standard question: why is this needed in oe-core? > > regards, > > Koen > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core It was in oe-classic so I believed it would be useful to port it over oe-core. I thought that the location I chose was the most suitable place for it. There doesn't seem to be a general 'user-cotrib/devel' layer into which these packages can go, I was unsure of it's relevance but a patch declined is a patch archived, right? Kind Regards,
On Thursday 12 April 2012 15:17:35 Jack Mitchell wrote: > It was in oe-classic so I believed it would be useful to port it over > oe-core. I thought that the location I chose was the most suitable place > for it. There doesn't seem to be a general 'user-cotrib/devel' layer > into which these packages can go, I was unsure of it's relevance but a > patch declined is a patch archived, right? I think that this recipe is definitely useful, but there's a question as to where the best place for it is. FYI, the (loose) criteria for something being included in OE-Core itself is it is either something everyone will need or it is something needed by something else in OE-Core. If there isn't an obvious place then meta-oe is where it should probably go. Cheers, Paul
On 12.04.2012 16:17, Jack Mitchell wrote: > On 12/04/12 15:08, Koen Kooi wrote: >> Op 12 apr. 2012, om 15:42 heeft ml@communistcode.co.uk het volgende >> geschreven: >> >>> From: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>> >>> Signed-off-by: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>> --- >>> meta-oe/recipes-support/jansson/jansson.inc | 8 ++++++++ >>> meta-oe/recipes-support/jansson/jansson_2.3.bb | 4 ++++ ^^^^^^^ >> I'll ask the standard question: why is this needed in oe-core? >> >> regards, >> >> Koen I think there's a misunderstanding. Jack sent the patch to the wrong list. Jack, patches for meta-oe should be submitted to openembedded-devel@lists.openembedded.org, with [meta-oe] as part of the subject. See http://www.openembedded.org/wiki/Mailing_lists. Regards, Andreas
Op 12 apr. 2012, om 16:38 heeft Andreas Oberritter het volgende geschreven: > On 12.04.2012 16:17, Jack Mitchell wrote: >> On 12/04/12 15:08, Koen Kooi wrote: >>> Op 12 apr. 2012, om 15:42 heeft ml@communistcode.co.uk het volgende >>> geschreven: >>> >>>> From: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>>> >>>> Signed-off-by: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>>> --- >>>> meta-oe/recipes-support/jansson/jansson.inc | 8 ++++++++ >>>> meta-oe/recipes-support/jansson/jansson_2.3.bb | 4 ++++ > > ^^^^^^^ > >>> I'll ask the standard question: why is this needed in oe-core? >>> >>> regards, >>> >>> Koen > > I think there's a misunderstanding. Jack sent the patch to the wrong list. > > Jack, patches for meta-oe should be submitted to > openembedded-devel@lists.openembedded.org, with [meta-oe] as part of the > subject. See http://www.openembedded.org/wiki/Mailing_lists. Or read the dang README in the meta-oe layer, it's called README for a reason.
On 12/04/12 15:40, Koen Kooi wrote: > Op 12 apr. 2012, om 16:38 heeft Andreas Oberritter het volgende geschreven: > >> On 12.04.2012 16:17, Jack Mitchell wrote: >>> On 12/04/12 15:08, Koen Kooi wrote: >>>> Op 12 apr. 2012, om 15:42 heeft ml@communistcode.co.uk het volgende >>>> geschreven: >>>> >>>>> From: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>>>> >>>>> Signed-off-by: Jack Mitchell<jack.mitchell@dbbroadcast.co.uk> >>>>> --- >>>>> meta-oe/recipes-support/jansson/jansson.inc | 8 ++++++++ >>>>> meta-oe/recipes-support/jansson/jansson_2.3.bb | 4 ++++ >> ^^^^^^^ >> >>>> I'll ask the standard question: why is this needed in oe-core? >>>> >>>> regards, >>>> >>>> Koen >> I think there's a misunderstanding. Jack sent the patch to the wrong list. >> >> Jack, patches for meta-oe should be submitted to >> openembedded-devel@lists.openembedded.org, with [meta-oe] as part of the >> subject. See http://www.openembedded.org/wiki/Mailing_lists. > Or read the dang README in the meta-oe layer, it's called README for a reason. > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core Apologies. On further inspection it seems openembedded-devel was the right place to send this patch. I have been under the impression that oe-core was the new meta-oe & oe-core list and oe-dev was the maintenance oe-classic list. I followed the Wiki page and made alterations as I saw fit. n.b. Koen, whilst I understand that the information was in the README (which I have now read - thanks) I was following the Wiki and doing what I believed to be right. It is not a requisite of my job to push patches back, I was doing it out of support for the community and the drive to help others. As it was my first ever OE Patch, and therefore my first offence I don't believe the snarkyness was warranted. Regards,
Patch
diff --git a/meta-oe/recipes-support/jansson/jansson.inc b/meta-oe/recipes-support/jansson/jansson.inc new file mode 100644 index 0000000..d3620ad --- /dev/null +++ b/meta-oe/recipes-support/jansson/jansson.inc @@ -0,0 +1,8 @@ +DESCRIPTION = "Jansson is a C library for encoding, decoding and manipulating JSON data." +HOMEPAGE = "http://www.digip.org/jansson/" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://LICENSE;md5=f521466f4aa39f2dec7513bf8ad26805" + +SRC_URI = "http://www.digip.org/jansson/releases/${PN}-${PV}.tar.gz" + +inherit autotools diff --git a/meta-oe/recipes-support/jansson/jansson_2.3.bb b/meta-oe/recipes-support/jansson/jansson_2.3.bb new file mode 100644 index 0000000..7e6e797 --- /dev/null +++ b/meta-oe/recipes-support/jansson/jansson_2.3.bb @@ -0,0 +1,4 @@ +require jansson.inc + +SRC_URI[md5sum] = "17d92cb6200cc06d8403134cb37ad2b8" +SRC_URI[sha256sum] = "db2a4202b4731398b16c97335f94536611283801236dbcd529e190f11e837292"