From patchwork Mon Apr 9 14:13:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel, 06/21] Hob: clean up and unify the steps for new build to call initiate_new_build_async() Date: Mon, 09 Apr 2012 14:13:36 -0000 From: Shane Wang X-Patchwork-Id: 25397 Message-Id: <0dc83006e19fe1ada319ea3eec95fa31ff6c1ef6.1333980505.git.shane.wang@intel.com> To: bitbake-devel@lists.openembedded.org initiate_new_build() (changed the function name into initiate_new_build_async() to indicate it is an async function) or the similar sub-functions are called at different places. This patch is unify to call initiate_new_build_async(). Signed-off-by: Shane Wang --- bitbake/lib/bb/ui/crumbs/builder.py | 19 +++++++------------ bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 2 +- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py index a3410d4..ef6f182 100755 --- a/bitbake/lib/bb/ui/crumbs/builder.py +++ b/bitbake/lib/bb/ui/crumbs/builder.py @@ -294,11 +294,7 @@ class Builder(gtk.Window): self.handler.connect("command-succeeded", self.handler_command_succeeded_cb) self.handler.connect("command-failed", self.handler_command_failed_cb) - self.handler.init_cooker() - self.handler.set_extra_inherit("image_types") - self.handler.parse_config() - - self.switch_page(self.MACHINE_SELECTION) + self.initiate_new_build_async() def create_visual_elements(self): self.set_title("Hob") @@ -334,6 +330,12 @@ class Builder(gtk.Window): self.show_all() self.nb.set_current_page(0) + def initiate_new_build_async(self): + self.switch_page(self.MACHINE_SELECTION) + self.handler.init_cooker() + self.handler.set_extra_inherit("image_types") + self.handler.parse_config() + def load_template(self, path): self.template = TemplateMgr() self.template.load(path) @@ -987,13 +989,6 @@ class Builder(gtk.Window): def show_recipes(self): self.switch_page(self.RECIPE_SELECTION) - def initiate_new_build(self): - self.handler.init_cooker() - self.handler.set_extra_inherit("image_types") - self.handler.parse_config() - self.image_configuration_page.switch_machine_combo() - self.switch_page(self.MACHINE_SELECTION) - def show_configuration(self): self.switch_page(self.BASEIMG_SELECTED) diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py index b685d11..e550653 100755 --- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py +++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py @@ -381,7 +381,7 @@ class ImageDetailsPage (HobPage): self.builder.runqemu_image(image_name) def build_new_button_clicked_cb(self, button): - self.builder.initiate_new_build() + self.builder.initiate_new_build_async() def edit_config_button_clicked_cb(self, button): self.builder.show_configuration()