Patchwork [bitbake-devel,00/21,Resend] Hob fixes and cleanups

login
register
mail settings
Submitter Shane Wang
Date April 9, 2012, 2:09 p.m.
Message ID <cover.1333980504.git.shane.wang@intel.com>
Download mbox
Permalink /patch/25387/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib shane/hob-fixes-continue

Comments

Shane Wang - April 9, 2012, 2:09 p.m.
Those patches fix the following:
  - the UI bug to fade out the entry in the "Included" page when it is removed
  - add and correct tooltips reviewed by Scott
  - clean up the code and maximize reusage, for exception handling
  - misc

The following changes since commit 190f6d791d51aaa4cfb9f1cf932bc205ff674fb5:

  runqemu-internal: Add console=tty for qemuppc and NFS (2012-04-06 01:12:47 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib shane/hob-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob-fixes-continue

Liming An (4):
  Hob: add fadeout display effection for recipe view include page
  Hob: add fadeout display effection for package view include page
  Hob: Add the tooltips for recipe view page as request
  Hob:Fixed some incorrect values of Build configuration tab

Shane Wang (17):
  Hob: fix version check - Hob can run on pygtk 2.21.0
  Hob: correct indent
  Hob: clean up and unify the steps for new build to call
    initiate_new_build_async()
  Hob: clean up and unify the steps for CONFIG_UPDATE to call
    update_config_async()
  Hob: clean up and unify the steps for RCPPKGINFO_POPULATING to call
    populate_recipe_package_info_async()
  Hob: clean up and unify the steps for PACKAGE_GENERATING and
    FAST_IMAGE_GENERATING to call generate_packages_async() and
    fast_generate_image_async()
  Hob: clean up and unify the steps for IMAGE_GENERATING to call
    generate_image_async()
  Hob: clean up to call clear_busy() in hobeventhandler.py
  Hob: clean up and unify get_parameters() to be get_parameters_sync()
  Hob: clean up request_package_info_async()
  Hob: clean up cancel_build()
  Hob: clean up generate_configuration()
  Hob: clean up and reword stop_parse()
  Hob: tooltip change for "Build image" button
  Hob: add tooltips into image details screen
  Hob: forget selected_recipes and selected_packages after users change
    the machine
  Hob: show those appliable buttons on the image details page only

 bitbake/lib/bb/ui/crumbs/builddetailspage.py       |   20 ++-
 bitbake/lib/bb/ui/crumbs/builder.py                |  164 +++++++++++---------
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py        |    7 +-
 bitbake/lib/bb/ui/crumbs/hoblistmodel.py           |   35 ++++-
 bitbake/lib/bb/ui/crumbs/hobwidget.py              |  155 ++++++++++++++++---
 bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py |   30 +++-
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py       |  136 +++++++++++-----
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py   |   54 ++++++-
 bitbake/lib/bb/ui/crumbs/recipeselectionpage.py    |   58 ++++++-
 bitbake/lib/bb/ui/hob.py                           |    2 +-
 10 files changed, 482 insertions(+), 179 deletions(-)
Richard Purdie - April 10, 2012, 10:48 p.m.
On Mon, 2012-04-09 at 22:09 +0800, Shane Wang wrote:
> Those patches fix the following:
>   - the UI bug to fade out the entry in the "Included" page when it is removed
>   - add and correct tooltips reviewed by Scott
>   - clean up the code and maximize reusage, for exception handling
>   - misc
> 
> The following changes since commit 190f6d791d51aaa4cfb9f1cf932bc205ff674fb5:
> 
>   runqemu-internal: Add console=tty for qemuppc and NFS (2012-04-06 01:12:47 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib shane/hob-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob-fixes-continue
> 
> Liming An (4):
>   Hob: add fadeout display effection for recipe view include page
>   Hob: add fadeout display effection for package view include page
>   Hob: Add the tooltips for recipe view page as request
>   Hob:Fixed some incorrect values of Build configuration tab
> 
> Shane Wang (17):
>   Hob: fix version check - Hob can run on pygtk 2.21.0
>   Hob: correct indent
>   Hob: clean up and unify the steps for new build to call
>     initiate_new_build_async()
>   Hob: clean up and unify the steps for CONFIG_UPDATE to call
>     update_config_async()
>   Hob: clean up and unify the steps for RCPPKGINFO_POPULATING to call
>     populate_recipe_package_info_async()
>   Hob: clean up and unify the steps for PACKAGE_GENERATING and
>     FAST_IMAGE_GENERATING to call generate_packages_async() and
>     fast_generate_image_async()
>   Hob: clean up and unify the steps for IMAGE_GENERATING to call
>     generate_image_async()
>   Hob: clean up to call clear_busy() in hobeventhandler.py
>   Hob: clean up and unify get_parameters() to be get_parameters_sync()
>   Hob: clean up request_package_info_async()
>   Hob: clean up cancel_build()
>   Hob: clean up generate_configuration()
>   Hob: clean up and reword stop_parse()
>   Hob: tooltip change for "Build image" button
>   Hob: add tooltips into image details screen
>   Hob: forget selected_recipes and selected_packages after users change
>     the machine
>   Hob: show those appliable buttons on the image details page only

I've merged these apart from the version change for which I took
Joshua's patches.

I have to say that cleanups at this point in the cycle are less than
ideal, I've only taken them since they were unit tested with the rest of
this and I can't really take one without the other.

Also, there were patch rejects on the fadeout patches and I had to merge
things due to taking other patches so please check the final result.

Cheers,

Richard