From patchwork Fri Apr 6 23:18:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel,4/4] selectionpage: show persistent tooltips on click Date: Fri, 06 Apr 2012 23:18:36 -0000 From: Joshua Lock X-Patchwork-Id: 25289 Message-Id: To: bitbake-devel@lists.openembedded.org Requiring a double click to show the tooltips isn't very intuitive, add a callback to show the persistent tooltips on button release. Signed-off-by: Joshua Lock --- lib/bb/ui/crumbs/packageselectionpage.py | 13 ++++++++----- lib/bb/ui/crumbs/recipeselectionpage.py | 13 ++++++++----- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/lib/bb/ui/crumbs/packageselectionpage.py b/lib/bb/ui/crumbs/packageselectionpage.py index b1a199c..81ff76d 100755 --- a/lib/bb/ui/crumbs/packageselectionpage.py +++ b/lib/bb/ui/crumbs/packageselectionpage.py @@ -117,7 +117,7 @@ class PackageSelectionPage (HobPage): tab.set_model(self.package_model.tree_model(filter)) tab.connect("toggled", self.table_toggled_cb) if page['name'] == "Included": - tab.connect("row-activated", self.tree_row_activated_cb) + tab.connect("button-release-event", self.button_click_cb) label = gtk.Label(page['name']) self.ins.append_page(tab, label) @@ -146,10 +146,13 @@ class PackageSelectionPage (HobPage): self.back_button.connect("clicked", self.back_button_clicked_cb) button_box.pack_start(self.back_button, expand=False, fill=False) - def tree_row_activated_cb(self, table, tree_model, path): - binb = tree_model.get_value(tree_model.get_iter(path), PackageListModel.COL_BINB) - if binb: - self.builder.show_binb_dialog(binb) + def button_click_cb(self, widget, event): + path, col = widget.table_tree.get_cursor() + tree_model = widget.table_tree.get_model() + if path: # else activation is likely a removal + binb = tree_model.get_value(tree_model.get_iter(path), PackageListModel.COL_BINB) + if binb: + self.builder.show_binb_dialog(binb) def build_image_clicked_cb(self, button): self.builder.build_image() diff --git a/lib/bb/ui/crumbs/recipeselectionpage.py b/lib/bb/ui/crumbs/recipeselectionpage.py index d70fe52..019f9f3 100755 --- a/lib/bb/ui/crumbs/recipeselectionpage.py +++ b/lib/bb/ui/crumbs/recipeselectionpage.py @@ -148,7 +148,7 @@ class RecipeSelectionPage (HobPage): tab.set_model(self.recipe_model.tree_model(filter)) tab.connect("toggled", self.table_toggled_cb) if page['name'] == "Included": - tab.connect("row-activated", self.tree_row_activated_cb) + tab.connect("button-release-event", self.button_click_cb) label = gtk.Label(page['name']) self.ins.append_page(tab, label) @@ -177,10 +177,13 @@ class RecipeSelectionPage (HobPage): self.back_button.connect("clicked", self.back_button_clicked_cb) button_box.pack_start(self.back_button, expand=False, fill=False) - def tree_row_activated_cb(self, table, tree_model, path): - binb = tree_model.get_value(tree_model.get_iter(path), RecipeListModel.COL_BINB) - if binb: - self.builder.show_binb_dialog(binb) + def button_click_cb(self, widget, event): + path, col = widget.table_tree.get_cursor() + tree_model = widget.table_tree.get_model() + if path: # else activation is likely a removal + binb = tree_model.get_value(tree_model.get_iter(path), RecipeListModel.COL_BINB) + if binb: + self.builder.show_binb_dialog(binb) def build_packages_clicked_cb(self, button): self.builder.build_packages()