Patchwork [1/1] connman: ensure ofono package is generated.

login
register
mail settings
Submitter Lianhao Lu
Date April 6, 2012, 6:20 a.m.
Message ID <af03fd7f8452c7795fce23e3276e456dc431266f.1333693070.git.lianhao.lu@intel.com>
Download mbox | patch
Permalink /patch/25263/
State New
Headers show

Comments

Lianhao Lu - April 6, 2012, 6:20 a.m.
Make sure ofono package is generated when buidling connman, because
dynamic package connman-plugin-ofono has a RDEPENDS on ofono.

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
---
 meta/recipes-connectivity/connman/connman.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Saul Wold - April 9, 2012, 9:21 p.m.
On 04/05/2012 11:20 PM, Lianhao Lu wrote:
> Make sure ofono package is generated when buidling connman, because
> dynamic package connman-plugin-ofono has a RDEPENDS on ofono.
>
Since this is for a plugin, can the connman-plugin-ofono be generated in 
a separate package (or possibly even a separate recipe that depends on 
ofono, instead of making connman depend on ofono, I am not sure the 
solution below is correct either.

Sau!

> Signed-off-by: Lianhao Lu<lianhao.lu@intel.com>
> ---
>   meta/recipes-connectivity/connman/connman.inc |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 1a6dd1b..3ed5667 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -39,6 +39,8 @@ EXTRA_OECONF += "\
>       --disable-ntpd \
>   "
>
> +do_package[depends] = "${MLPREFIX}ofono:do_package"
> +
>   INITSCRIPT_NAME = "connman"
>   INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>
Lianhao Lu - April 10, 2012, 3:03 a.m.
Saul Wold wrote on 2012-04-10:
> On 04/05/2012 11:20 PM, Lianhao Lu wrote:
>> Make sure ofono package is generated when buidling connman, because
>> dynamic package connman-plugin-ofono has a RDEPENDS on ofono.
>> 
> Since this is for a plugin, can the connman-plugin-ofono be generated in
> a separate package (or possibly even a separate recipe that depends on
> ofono, instead of making connman depend on ofono, I am not sure the
> solution below is correct either.

connman-plugin-ofono is already generated in a separate dynamic package, just like other dynamic connman-plugin-bluez4. I think we'd better build the connman-plugin-ofono based on the value distro_features, just like we did for connman-plugin-bluez4 in commit http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit?id=1288313411f8db7628e9ec4c04f2ad7f830e994d. I'll remake the patch. 

-Lianhao 

> Sau!
> 
>> Signed-off-by: Lianhao Lu<lianhao.lu@intel.com>
>> ---
>>   meta/recipes-connectivity/connman/connman.inc |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
>> index 1a6dd1b..3ed5667 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -39,6 +39,8 @@ EXTRA_OECONF += "\
>>       --disable-ntpd \
>>   "
>> +do_package[depends] = "${MLPREFIX}ofono:do_package"
>> +
>>   INITSCRIPT_NAME = "connman"
>>   INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."

Best Regards,
Lianhao

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 1a6dd1b..3ed5667 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -39,6 +39,8 @@  EXTRA_OECONF += "\
     --disable-ntpd \
 "
 
+do_package[depends] = "${MLPREFIX}ofono:do_package"
+
 INITSCRIPT_NAME = "connman"
 INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."