tcmode-default.inc: clear PREFERRED_VERSION for llvm

Message ID 20220116164706.4555-1-kai.kang@windriver.com
State New
Headers show
Series tcmode-default.inc: clear PREFERRED_VERSION for llvm | expand

Commit Message

Kai Jan. 16, 2022, 4:47 p.m. UTC
From: Kai Kang <kai.kang@windriver.com>

When include layer meta-clang which set LLVMVERSION in layer.conf, it
shows warnings:

| WARNING: preferred version 13.0.1 of llvm-native not available (for item llvm-native)
| WARNING: versions of llvm-native available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-dev)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-bugpointpasses)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-liboptremarks)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-llvmhello)
| WARNING: versions of llvm available: 12.0.1

Because only one version llvm exists, remove the PREFERRED_VERSION
setting for llvm.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/conf/distro/include/tcmode-default.inc | 4 ----
 1 file changed, 4 deletions(-)

Comments

Khem Raj Jan. 16, 2022, 6:43 p.m. UTC | #1
On Sun, Jan 16, 2022 at 8:47 AM <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> When include layer meta-clang which set LLVMVERSION in layer.conf, it
> shows warnings:
>
> | WARNING: preferred version 13.0.1 of llvm-native not available (for item
> llvm-native)
> | WARNING: versions of llvm-native available: 12.0.1
> | WARNING: preferred version 13.0.1 of llvm not available (for item llvm)
> | WARNING: versions of llvm available: 12.0.1
> | WARNING: preferred version 13.0.1 of llvm not available (for item
> llvm-dev)
> | WARNING: versions of llvm available: 12.0.1
> | WARNING: preferred version 13.0.1 of llvm not available (for item
> llvm-bugpointpasses)
> | WARNING: versions of llvm available: 12.0.1
> | WARNING: preferred version 13.0.1 of llvm not available (for item
> llvm-liboptremarks)
> | WARNING: versions of llvm available: 12.0.1
> | WARNING: preferred version 13.0.1 of llvm not available (for item
> llvm-llvmhello)
> | WARNING: versions of llvm available: 12.0.1
>
> Because only one version llvm exists, remove the PREFERRED_VERSION
> setting for llvm.


I think these are PROVIDERS mismatch more than anything between two recipes
so perhaps it’s better to keep that in sync

Fwiw llvm is not heavily used in oe-core perhaps it should be removed

>
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> index 49e99af8f2..2622b055a2 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -79,10 +79,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
>
> -PREFERRED_VERSION_llvm = "${LLVMVERSION}"
> -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
> -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
> -
>  # Rust toolchain preferred versions:
>
>  PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
> --
> 2.17.1
>
>
Kai Jan. 17, 2022, 3:35 a.m. UTC | #2
On 1/17/22 2:43 AM, Khem Raj wrote:
>
>
> On Sun, Jan 16, 2022 at 8:47 AM <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     From: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>
>     When include layer meta-clang which set LLVMVERSION in layer.conf, it
>     shows warnings:
>
>     | WARNING: preferred version 13.0.1 of llvm-native not available
>     (for item llvm-native)
>     | WARNING: versions of llvm-native available: 12.0.1
>     | WARNING: preferred version 13.0.1 of llvm not available (for
>     item llvm)
>     | WARNING: versions of llvm available: 12.0.1
>     | WARNING: preferred version 13.0.1 of llvm not available (for
>     item llvm-dev)
>     | WARNING: versions of llvm available: 12.0.1
>     | WARNING: preferred version 13.0.1 of llvm not available (for
>     item llvm-bugpointpasses)
>     | WARNING: versions of llvm available: 12.0.1
>     | WARNING: preferred version 13.0.1 of llvm not available (for
>     item llvm-liboptremarks)
>     | WARNING: versions of llvm available: 12.0.1
>     | WARNING: preferred version 13.0.1 of llvm not available (for
>     item llvm-llvmhello)
>     | WARNING: versions of llvm available: 12.0.1
>
>     Because only one version llvm exists, remove the PREFERRED_VERSION
>     setting for llvm.
>
>
> I think these are PROVIDERS mismatch more than anything between two 
> recipes so perhaps it’s better to keep that in sync

My doubt is that it seems only a single llvm recipe exists in oe-core 
around all the layers including meta-clang.

Regards,
Kai

>
> Fwiw llvm is not heavily used in oe-core perhaps it should be removed
>
>
>
>     Signed-off-by: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>     ---
>      meta/conf/distro/include/tcmode-default.inc | 4 ----
>      1 file changed, 4 deletions(-)
>
>     diff --git a/meta/conf/distro/include/tcmode-default.inc
>     b/meta/conf/distro/include/tcmode-default.inc
>     index 49e99af8f2..2622b055a2 100644
>     --- a/meta/conf/distro/include/tcmode-default.inc
>     +++ b/meta/conf/distro/include/tcmode-default.inc
>     @@ -79,10 +79,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
>      PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
>      PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
>
>     -PREFERRED_VERSION_llvm = "${LLVMVERSION}"
>     -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
>     -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
>     -
>      # Rust toolchain preferred versions:
>
>      PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
>     -- 
>     2.17.1
>

Patch

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index 49e99af8f2..2622b055a2 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -79,10 +79,6 @@  PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
 
-PREFERRED_VERSION_llvm = "${LLVMVERSION}"
-PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
-PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
-
 # Rust toolchain preferred versions:
 
 PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"