Patchwork [2/3] xterm: port the recipe from OE and upgrade to v278

login
register
mail settings
Submitter Dexuan Cui
Date April 5, 2012, 4:10 p.m.
Message ID <db6ed82ab474a1b521b8f9bcb14abee243ac63a9.1333642153.git.dexuan.cui@intel.com>
Download mbox | patch
Permalink /patch/25211/
State New
Headers show

Comments

Dexuan Cui - April 5, 2012, 4:10 p.m.
The recipe is ported from OE:
http://git.openembedded.org/openembedded/tree/recipes/xorg-app/xterm_266.bb

I upgraded it from v266 to v278.
I added LICENSE, LIC_FILES_CHKSUM and updated SRC_URI checksums.

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
 meta/recipes-graphics/xorg-app/xterm_278.bb |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-graphics/xorg-app/xterm_278.bb
Paul Eggleton - April 5, 2012, 4:19 p.m.
On Friday 06 April 2012 00:10:12 Dexuan Cui wrote:
> The recipe is ported from OE:
> http://git.openembedded.org/openembedded/tree/recipes/xorg-app/xterm_266.bb
> 
> I upgraded it from v266 to v278.
> I added LICENSE, LIC_FILES_CHKSUM and updated SRC_URI checksums.

I think it's unfortunate we have to pull in xterm just for the sake of showing 
the qemu output - can we not use matchbox-terminal for this?

If we have to have it, Dexuan can you please compare this to the meta-oe xterm 
recipe as that is likely to be more up-to-date than the one in OE-Classic?

Thanks,
Paul
Dexuan Cui - April 5, 2012, 4:47 p.m.
Paul Eggleton wrote on 2012-04-06:
> On Friday 06 April 2012 00:10:12 Dexuan Cui wrote:
>> The recipe is ported from OE:
>> 
> http://git.openembedded.org/openembedded/tree/recipes/xorg-app/xterm_2
> 66.bb
>> 
>> I upgraded it from v266 to v278.
>> I added LICENSE, LIC_FILES_CHKSUM and updated SRC_URI checksums.
> 
> I think it's unfortunate we have to pull in xterm just for the sake of showing
> the qemu output - can we not use matchbox-terminal for this?
Thanks for the suggestion!
I suppose we could, but we need to fix bitbake as it uses /usr/bin/xterm
by hardcode...

> If we have to have it, Dexuan can you please compare this to the meta-oe
> xterm recipe as that is likely to be more up-to-date than the one in
> OE-Classic?
Ok, I'll investigate this.

Thanks,
-- Dexuan
Martin Jansa - April 5, 2012, 6:40 p.m.
On Thu, Apr 05, 2012 at 05:19:22PM +0100, Paul Eggleton wrote:
> On Friday 06 April 2012 00:10:12 Dexuan Cui wrote:
> > The recipe is ported from OE:
> > http://git.openembedded.org/openembedded/tree/recipes/xorg-app/xterm_266.bb
> > 
> > I upgraded it from v266 to v278.
> > I added LICENSE, LIC_FILES_CHKSUM and updated SRC_URI checksums.
> 
> I think it's unfortunate we have to pull in xterm just for the sake of showing 
> the qemu output - can we not use matchbox-terminal for this?
> 
> If we have to have it, Dexuan can you please compare this to the meta-oe xterm 
> recipe as that is likely to be more up-to-date than the one in OE-Classic?

yes it is..
meta-openembedded/meta-oe/recipes-graphics/xorg-app/xterm_277.bb

and already with LICENSE from xorg-app-common.inc and LIC_FILES_CHKSUM
using xterm.h instead of package/debian/copyright

Cheers,

> 
> Thanks,
> Paul
> 
> -- 
> 
> Paul Eggleton
> Intel Open Source Technology Centre
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-graphics/xorg-app/xterm_278.bb b/meta/recipes-graphics/xorg-app/xterm_278.bb
new file mode 100644
index 0000000..64c8866
--- /dev/null
+++ b/meta/recipes-graphics/xorg-app/xterm_278.bb
@@ -0,0 +1,25 @@ 
+require xorg-app-common.inc
+DESCRIPTION = "xterm is the standard terminal emulator for the X Window System."
+DEPENDS = "libxaw xproto xextproto libxext libxau libxpm ncurses"
+PR = "${INC_PR}.0"
+
+SRC_URI = "ftp://invisible-island.net/xterm/${PN}-${PV}.tgz"
+
+LICENSE = "MIT & MIT-style"
+LIC_FILES_CHKSUM = "file://package/debian/copyright;md5=d1415419990d510a698de36fb386f797"
+
+SRC_URI[md5sum] = "3eeddfe35cb0a2db1924cfe0c20be443"
+SRC_URI[sha256sum] = "1372f9afe07bc35bfd47482db146c649223dadd0b472da31f8c337ab37f90585"
+
+EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
+                 --x-libraries=${STAGING_LIBDIR} \
+                 FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config \
+                 --disable-imake \
+                 --disable-setuid"
+
+do_configure() {
+        sed -e "s%/usr/contrib/X11R6%${STAGING_LIBDIR}%g" -i configure
+        oe_runconf
+}
+
+FILES_${PN} += " /usr/lib/X11"