| Submitter | Lianhao Lu |
|---|---|
| Date | March 31, 2012, 6:49 a.m. |
| Message ID | <eb2bbe99f15183d5c82ab5c12178a1e336a7c5ce.1333176251.git.lianhao.lu@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/24973/ |
| State | New |
| Headers | show |
Comments
On Sat, 2012-03-31 at 14:49 +0800, Lianhao Lu wrote: > Set only necessary GCC_ADDONS for eglibc-nativesdk so that it is not > dependant on the target eglibc's GCC_ADDONS settings. You mean GLIBC_ADDONS, right? :) > Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> > --- > meta/recipes-core/eglibc/eglibc_2.13.bb | 3 ++- > meta/recipes-core/eglibc/eglibc_2.15.bb | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) This is a tricky problem as this is only correct for SDKMACHINEs which are IA based (which the only tested combinations are atm). Ideally this would go in conf/machine-sdk/* as SDK_GLIBC_ADDONS and then in eglibc.inc we'd do: GLIBC_ADDONS ?= "ports,nptl,libidn" SDK_GLIBC_ADDONS ?= "${GLIBC_ADDONS}" GLIBC_ADDONS_virtclass-nativesdk = "${SDK_GLIBC_ADDONS}" which I appreciate is more complex but I think its more correct in case someone wants to try a different SDKMACHINE. Cheers, Richard
On Fri, Mar 30, 2012 at 11:49 PM, Lianhao Lu <lianhao.lu@intel.com> wrote: > > GLIBC_ADDONS ?= "ports,nptl,libidn" > +GLIBC_ADDONS_virtclass-nativesdk = "nptl" nptl is bogus now a days. so please delete it completely.
On Sat, Mar 31, 2012 at 7:39 AM, Khem Raj <raj.khem@gmail.com> wrote:
> nptl is bogus now a days. so please delete it completely.
heh I must have said in GLIBC_ADDON context its bogus. Since its _the_
only thread implementation in eglibc/glibc
I've recreated the patches per Richard's comment. However, removing nptl from the add-on settings resulted an eglibc configure error saying that it is an required add-on. -Lianhao Khem Raj wrote on 2012-03-31: > On Sat, Mar 31, 2012 at 7:39 AM, Khem Raj <raj.khem@gmail.com> wrote: >> nptl is bogus now a days. so please delete it completely. > > heh I must have said in GLIBC_ADDON context its bogus. Since its _the_ > only thread implementation in eglibc/glibc > > _______________________________________________ Openembedded-core > mailing list Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Mon, Apr 2, 2012 at 5:22 PM, Lu, Lianhao <lianhao.lu@intel.com> wrote:
> I've recreated the patches per Richard's comment. However, removing nptl from the add-on settings resulted an eglibc configure error saying that it is an required add-on.
hmm interesting. I will see whats going on there.
Patch
diff --git a/meta/recipes-core/eglibc/eglibc_2.13.bb b/meta/recipes-core/eglibc/eglibc_2.13.bb index e02c80f..e480772 100644 --- a/meta/recipes-core/eglibc/eglibc_2.13.bb +++ b/meta/recipes-core/eglibc/eglibc_2.13.bb @@ -3,7 +3,7 @@ require eglibc.inc SRCREV = "15508" DEPENDS += "gperf-native" -PR = "r22" +PR = "r23" PR_append = "+svnr${SRCPV}" EGLIBC_BRANCH="eglibc-2_13" @@ -37,6 +37,7 @@ BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${layout_includedir}" GLIBC_ADDONS ?= "ports,nptl,libidn" +GLIBC_ADDONS_virtclass-nativesdk = "nptl" GLIBC_BROKEN_LOCALES = " _ER _ET so_ET yn_ER sid_ET tr_TR mn_MN gez_ET gez_ER bn_BD te_IN es_CR.ISO-8859-1" diff --git a/meta/recipes-core/eglibc/eglibc_2.15.bb b/meta/recipes-core/eglibc/eglibc_2.15.bb index 75ccace..4e7fe1e 100644 --- a/meta/recipes-core/eglibc/eglibc_2.15.bb +++ b/meta/recipes-core/eglibc/eglibc_2.15.bb @@ -3,7 +3,7 @@ require eglibc.inc SRCREV = "17386" DEPENDS += "gperf-native" -PR = "r2" +PR = "r3" PR_append = "+svnr${SRCPV}" EGLIBC_BRANCH="eglibc-2_15" @@ -42,6 +42,7 @@ BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${layout_includedir}" GLIBC_ADDONS ?= "ports,nptl,libidn" +GLIBC_ADDONS_virtclass-nativesdk = "nptl" GLIBC_BROKEN_LOCALES = " _ER _ET so_ET yn_ER sid_ET tr_TR mn_MN gez_ET gez_ER bn_BD te_IN es_CR.ISO-8859-1"
Set only necessary GCC_ADDONS for eglibc-nativesdk so that it is not dependant on the target eglibc's GCC_ADDONS settings. Signed-off-by: Lianhao Lu <lianhao.lu@intel.com> --- meta/recipes-core/eglibc/eglibc_2.13.bb | 3 ++- meta/recipes-core/eglibc/eglibc_2.15.bb | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)