Patchwork [bitbake-devel,4/7] Revert "lib/bb/ui/crumbs/hig: fix layers_changed test"

login
register
mail settings
Submitter Dongxiao Xu
Date March 30, 2012, 12:01 p.m.
Message ID <28ccf8cd2d23a4cfc8e94fa1ad089dd68334bf35.1333108781.git.dongxiao.xu@intel.com>
Download mbox | patch
Permalink /patch/24927/
State New
Headers show

Comments

Dongxiao Xu - March 30, 2012, 12:01 p.m.
We do not sort the layer list, therefore when response_cb, the ordering
is also not needed.

This reverts commit 71c1de347eef07a2059fc4544dc3cae090181f44.
---
 lib/bb/ui/crumbs/hig.py |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
Joshua Lock - March 30, 2012, 4:10 p.m.
On 30/03/12 05:01, Dongxiao Xu wrote:
> We do not sort the layer list, therefore when response_cb, the ordering
> is also not needed.
>
> This reverts commit 71c1de347eef07a2059fc4544dc3cae090181f44.

This only makes sense if 3/7 is merged, correct?

Cheers,
Joshua

> ---
>   lib/bb/ui/crumbs/hig.py |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
> index 9a38bc0..0ac4496 100644
> --- a/lib/bb/ui/crumbs/hig.py
> +++ b/lib/bb/ui/crumbs/hig.py
> @@ -958,10 +958,7 @@ class LayerSelectionDialog (CrumbsDialog):
>               layers.append(model.get_value(it, 0))
>               it = model.iter_next(it)
>
> -        orig_layers = sorted(self.layers)
> -        layers.sort()
> -
> -        self.layers_changed = (orig_layers != layers)
> +        self.layers_changed = (self.layers != layers)
>           self.layers = layers
>
>       """
Dongxiao Xu - March 31, 2012, 12:32 a.m.
On Fri, 2012-03-30 at 09:10 -0700, Joshua Lock wrote:
> 
> On 30/03/12 05:01, Dongxiao Xu wrote:
> > We do not sort the layer list, therefore when response_cb, the ordering
> > is also not needed.
> >
> > This reverts commit 71c1de347eef07a2059fc4544dc3cae090181f44.
> 
> This only makes sense if 3/7 is merged, correct?

Yes, I should have made the comment more clear.

Thanks,
Dongxiao

> 
> Cheers,
> Joshua
> 
> > ---
> >   lib/bb/ui/crumbs/hig.py |    5 +----
> >   1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
> > index 9a38bc0..0ac4496 100644
> > --- a/lib/bb/ui/crumbs/hig.py
> > +++ b/lib/bb/ui/crumbs/hig.py
> > @@ -958,10 +958,7 @@ class LayerSelectionDialog (CrumbsDialog):
> >               layers.append(model.get_value(it, 0))
> >               it = model.iter_next(it)
> >
> > -        orig_layers = sorted(self.layers)
> > -        layers.sort()
> > -
> > -        self.layers_changed = (orig_layers != layers)
> > +        self.layers_changed = (self.layers != layers)
> >           self.layers = layers
> >
> >       """
>

Patch

diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
index 9a38bc0..0ac4496 100644
--- a/lib/bb/ui/crumbs/hig.py
+++ b/lib/bb/ui/crumbs/hig.py
@@ -958,10 +958,7 @@  class LayerSelectionDialog (CrumbsDialog):
             layers.append(model.get_value(it, 0))
             it = model.iter_next(it)
 
-        orig_layers = sorted(self.layers)
-        layers.sort()
-
-        self.layers_changed = (orig_layers != layers)
+        self.layers_changed = (self.layers != layers)
         self.layers = layers
 
     """