Patchwork [PATCHv2] rootfs_ipk: don't echo opkg-cl output to log.do_rootfs

login
register
mail settings
Submitter Martin Jansa
Date March 30, 2012, 10:55 a.m.
Message ID <1333104939-25404-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/24923/
State Accepted
Commit 76c83f107d4a4688a879e30821ab70812052bbdc
Headers show

Comments

Martin Jansa - March 30, 2012, 10:55 a.m.
* log_check can find some files with ERR or Fail substring e.g. in "Source: " field

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/rootfs_ipk.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Denys Dmytriyenko - March 30, 2012, 6:10 p.m.
On Fri, Mar 30, 2012 at 12:55:39PM +0200, Martin Jansa wrote:
> * log_check can find some files with ERR or Fail substring e.g. in "Source: " field
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>

This one looks better and it does not change the regex string, like the patch 
sent to bitbake-devel...

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
>  meta/classes/rootfs_ipk.bbclass |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index 13bd4bf..cbc63f0 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -127,10 +127,12 @@ list_installed_packages() {
>  }
>  
>  get_package_filename() {
> +	set +x
>  	info=`opkg-cl ${IPKG_ARGS} info $1 | grep -B 7 -A 7 "^Status.* \(\(installed\)\|\(unpacked\)\)" || true`
>  	name=`echo "${info}" | awk '/^Package/ {printf $2"_"}'`
>  	name=$name`echo "${info}" | awk -F: '/^Version/ {printf $NF"_"}' | sed 's/^\s*//g'`
>  	name=$name`echo "${info}" | awk '/^Archi/ {print $2".ipk"}'`
> +	set -x
>  
>  	fullname=`find ${DEPLOY_DIR_IPK} -name "$name" || true`
>  	if [ "$fullname" = "" ] ; then
> -- 
> 1.7.8.5
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - March 30, 2012, 6:21 p.m.
Op 30 mrt. 2012, om 11:10 heeft Denys Dmytriyenko het volgende geschreven:

> On Fri, Mar 30, 2012 at 12:55:39PM +0200, Martin Jansa wrote:
>> * log_check can find some files with ERR or Fail substring e.g. in "Source: " field
>> 
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> This one looks better and it does not change the regex string, like the patch 
> sent to bitbake-devel...
> 
> Acked-by: Denys Dmytriyenko <denys@ti.com>

Acked-by: Koen Kooi <koen@circuitco.com>
Saul Wold - April 3, 2012, 11:23 p.m.
On 03/30/2012 03:55 AM, Martin Jansa wrote:
> * log_check can find some files with ERR or Fail substring e.g. in "Source: " field
>
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> ---
>   meta/classes/rootfs_ipk.bbclass |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index 13bd4bf..cbc63f0 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -127,10 +127,12 @@ list_installed_packages() {
>   }
>
>   get_package_filename() {
> +	set +x
>   	info=`opkg-cl ${IPKG_ARGS} info $1 | grep -B 7 -A 7 "^Status.* \(\(installed\)\|\(unpacked\)\)" || true`
>   	name=`echo "${info}" | awk '/^Package/ {printf $2"_"}'`
>   	name=$name`echo "${info}" | awk -F: '/^Version/ {printf $NF"_"}' | sed 's/^\s*//g'`
>   	name=$name`echo "${info}" | awk '/^Archi/ {print $2".ipk"}'`
> +	set -x
>
>   	fullname=`find ${DEPLOY_DIR_IPK} -name "$name" || true`
>   	if [ "$fullname" = "" ] ; then

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
index 13bd4bf..cbc63f0 100644
--- a/meta/classes/rootfs_ipk.bbclass
+++ b/meta/classes/rootfs_ipk.bbclass
@@ -127,10 +127,12 @@  list_installed_packages() {
 }
 
 get_package_filename() {
+	set +x
 	info=`opkg-cl ${IPKG_ARGS} info $1 | grep -B 7 -A 7 "^Status.* \(\(installed\)\|\(unpacked\)\)" || true`
 	name=`echo "${info}" | awk '/^Package/ {printf $2"_"}'`
 	name=$name`echo "${info}" | awk -F: '/^Version/ {printf $NF"_"}' | sed 's/^\s*//g'`
 	name=$name`echo "${info}" | awk '/^Archi/ {print $2".ipk"}'`
+	set -x
 
 	fullname=`find ${DEPLOY_DIR_IPK} -name "$name" || true`
 	if [ "$fullname" = "" ] ; then