Patchwork [1/1] qt4-x11-free: enable -accessibility and -sm

login
register
mail settings
Submitter Robert Yang
Date March 30, 2012, 5:29 a.m.
Message ID <ac05d9a1b72099761bbc1a8312cd0d4ad8600b4a.1333085308.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/24897/
State Accepted
Commit 678973a9ad258b466295a666cbcd56df15a57c7c
Headers show

Comments

Robert Yang - March 30, 2012, 5:29 a.m.
Is it possible to enable the "-sm -accessibility" in oe-core, please?
There is a meta-kde layer which requires the "-sm -accessibility", but
they are disabled in meta/recipes-qt/qt4/qt4.inc:

QT_DISTRO_FLAGS ?= "-no-accessibility -no-sm"

I checked the log of the qt4, can't find the related log for
"-no-accessibility -no-sm".

Another way is use the bbappend, but it would be great if it can be
enabled in oe-core.

This only enables for qt4-x11, doesn't enable for qt4-embedded, and
have done testing on: qemux86, qemuarm, qemumips, qemuppc.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-qt/qt4/qt4-x11-free.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Robert Yang - April 12, 2012, 2 p.m.
Is there any suggestions for this one please?

// Robert

On 03/30/2012 01:29 PM, Robert Yang wrote:
> Is it possible to enable the "-sm -accessibility" in oe-core, please?
> There is a meta-kde layer which requires the "-sm -accessibility", but
> they are disabled in meta/recipes-qt/qt4/qt4.inc:
>
> QT_DISTRO_FLAGS ?= "-no-accessibility -no-sm"
>
> I checked the log of the qt4, can't find the related log for
> "-no-accessibility -no-sm".
>
> Another way is use the bbappend, but it would be great if it can be
> enabled in oe-core.
>
> This only enables for qt4-x11, doesn't enable for qt4-embedded, and
> have done testing on: qemux86, qemuarm, qemumips, qemuppc.
>
> Signed-off-by: Robert Yang<liezhi.yang@windriver.com>
> ---
>   meta/recipes-qt/qt4/qt4-x11-free.inc |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc
> index 072c522..a59198d 100644
> --- a/meta/recipes-qt/qt4/qt4-x11-free.inc
> +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
> @@ -13,6 +13,9 @@ QT_GLFLAGS_qemuppc = "-opengl"
>   QT_CONFIG_FLAGS += "-no-xinerama -no-xkb"
>   QT_BASE_LIB  ?= "libqt"
>
> +# required by kdelibs4
> +QT_DISTRO_FLAGS = "-accessibility -sm"
> +
>   inherit qt4x11
>
>   do_install_append() {
Richard Purdie - April 13, 2012, 11:07 a.m.
On Thu, 2012-04-12 at 22:00 +0800, Robert Yang wrote:
> Is there any suggestions for this one please?

This is a change suitable for post 1.2 so it needs to wait until after
release.

Cheers,

Richard

Patch

diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc
index 072c522..a59198d 100644
--- a/meta/recipes-qt/qt4/qt4-x11-free.inc
+++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
@@ -13,6 +13,9 @@  QT_GLFLAGS_qemuppc = "-opengl"
 QT_CONFIG_FLAGS += "-no-xinerama -no-xkb"
 QT_BASE_LIB  ?= "libqt"
 
+# required by kdelibs4
+QT_DISTRO_FLAGS = "-accessibility -sm"
+
 inherit qt4x11
 
 do_install_append() {