Patchwork libc-packgae.bbclass: Add i686 support in locale_arch_options

login
register
mail settings
Submitter Noor Ahsan
Date March 29, 2012, 6:48 a.m.
Message ID <1333003715-3872-1-git-send-email-noor_ahsan@mentor.com>
Download mbox | patch
Permalink /patch/24807/
State Accepted
Commit c8afc79b5d3205355ad61d2589221bf8babe8395
Headers show

Comments

Noor Ahsan - March 29, 2012, 6:48 a.m.
From: Noor Ahsan <noor_ahsan@mentor.com>

* While building for i686 architectre an error was coming that
locale_arch_options does not have support for i686. Add missing support.
* Verified on intel architecture.

Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
 meta/classes/libc-package.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Otavio Salvador - March 29, 2012, 7:35 a.m.
Typo in commit log; please fix it and resend.

On Thu, Mar 29, 2012 at 03:48, Noor, Ahsan <noor_ahsan@mentor.com> wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
>
> * While building for i686 architectre an error was coming that
> locale_arch_options does not have support for i686. Add missing support.
> * Verified on intel architecture.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
>  meta/classes/libc-package.bbclass |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
> index 4acf91a..957243d 100644
> --- a/meta/classes/libc-package.bbclass
> +++ b/meta/classes/libc-package.bbclass
> @@ -271,6 +271,7 @@ python package_do_split_gconvs () {
>                                "mips":    " --uint32-align=4 --big-endian ",    \
>                                "mipsel":  " --uint32-align=4 --little-endian ", \
>                                "i586":    " --uint32-align=4 --little-endian ", \
> +                               "i686":    " --uint32-align=4 --little-endian ", \
>                                "x86_64":  " --uint32-align=4 --little-endian "  }
>
>                        if target_arch in locale_arch_options:
> --
> 1.7.9
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - March 29, 2012, 9:23 p.m.
On Thu, 2012-03-29 at 11:48 +0500, Noor, Ahsan wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
> 
> * While building for i686 architectre an error was coming that
> locale_arch_options does not have support for i686. Add missing support.
> * Verified on intel architecture.
> 
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
>  meta/classes/libc-package.bbclass |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

I merged this to master with the typo fixed.

Cheers,

Richard

Patch

diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
index 4acf91a..957243d 100644
--- a/meta/classes/libc-package.bbclass
+++ b/meta/classes/libc-package.bbclass
@@ -271,6 +271,7 @@  python package_do_split_gconvs () {
 				"mips":    " --uint32-align=4 --big-endian ",    \
 				"mipsel":  " --uint32-align=4 --little-endian ", \
 				"i586":    " --uint32-align=4 --little-endian ", \
+				"i686":    " --uint32-align=4 --little-endian ", \
 				"x86_64":  " --uint32-align=4 --little-endian "  }
 
 			if target_arch in locale_arch_options: