From patchwork Tue Mar 27 19:07:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel] bb.build: use relative log links, not absolute Date: Tue, 27 Mar 2012 19:07:23 -0000 From: Christopher Larson X-Patchwork-Id: 24675 Message-Id: <1332875243-16798-1-git-send-email-kergoth@gmail.com> To: bitbake-devel@lists.openembedded.org Cc: Christopher Larson From: Christopher Larson Using symlinks to absolute paths isn't gaining us anything, and can cause problems in situations such as automated build systems when they try to resolve the link, depending on the mechanism used to pull the build artifacts (e.g. nfs). Signed-off-by: Christopher Larson --- lib/bb/build.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/bb/build.py b/lib/bb/build.py index 736ba24..95f1dcf 100644 --- a/lib/bb/build.py +++ b/lib/bb/build.py @@ -291,12 +291,13 @@ def _exec_task(fn, task, d, quieterr): bb.utils.mkdirhier(tempdir) loglink = os.path.join(tempdir, 'log.{0}'.format(task)) - logfn = os.path.join(tempdir, 'log.{0}.{1}'.format(task, os.getpid())) + logbase = 'log.{0}.{1}'.format(task, os.getpid()) + logfn = os.path.join(tempdir, logbase) if loglink: bb.utils.remove(loglink) try: - os.symlink(logfn, loglink) + os.symlink(logbase, loglink) except OSError: pass