Patchwork [4/4] obexd: fix QA warnings

login
register
mail settings
Submitter Andreas Müller
Date March 27, 2012, 1:03 p.m.
Message ID <1332853398-9501-4-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/24657/
State Superseded
Headers show

Comments

Andreas Müller - March 27, 2012, 1:03 p.m.
fix the following warnings:
WARNING: For recipe obexd, the following files/directories were installed but not shipped in any package:
WARNING:   /usr/lib
WARNING:   /usr/lib/obex
WARNING:   /usr/lib/obex/plugins

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta-oe/recipes-connectivity/obex/obexd_0.44.bb |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
Khem Raj - March 27, 2012, 9:39 p.m.
On Tue, Mar 27, 2012 at 6:03 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> +do_install_append() {
> +    # remove empty plugins dir
> +    rm -rf ${D}${libdir}
> +}
> +

can you use use rmdir instead so it gets flagged when the dir
is not empty ?
Denys Dmytriyenko - March 28, 2012, 12:20 a.m.
On Tue, Mar 27, 2012 at 02:39:24PM -0700, Khem Raj wrote:
> On Tue, Mar 27, 2012 at 6:03 AM, Andreas M??ller
> <schnitzeltony@googlemail.com> wrote:
> > +do_install_append() {
> > +    # remove empty plugins dir
> > +    rm -rf ${D}${libdir}
> > +}
> > +
> 
> can you use use rmdir instead so it gets flagged when the dir
> is not empty ?

Can we instead create obex-plugins in PACKAGES, even if it's empty now?

Patch

diff --git a/meta-oe/recipes-connectivity/obex/obexd_0.44.bb b/meta-oe/recipes-connectivity/obex/obexd_0.44.bb
index 24edb9d..c53bfdc 100644
--- a/meta-oe/recipes-connectivity/obex/obexd_0.44.bb
+++ b/meta-oe/recipes-connectivity/obex/obexd_0.44.bb
@@ -4,12 +4,19 @@  DEPENDS = "openobex glib-2.0 dbus bluez4 libical"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "files://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e"
 
+PR = "r1"
+
 SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/obexd-${PV}.tar.gz"
 SRC_URI[md5sum] = "3fb9cb9d7ab119753253ff784235a364"
 SRC_URI[sha256sum] = "104fc50eb8bf41d690d31588c3a4829a75dc7738b1c76cf260171d8f525da758"
 
 inherit autotools
 
+do_install_append() {
+    # remove empty plugins dir
+    rm -rf ${D}${libdir}
+}
+
 PACKAGES =+ "obex-client"
 
 FILES_${PN} += "${datadir}/dbus-1/services/${PN}.service"