Patchwork [bitbake-devel,0/9,v3,PULL] Hob: Bug fixes: image_types, runqemu/deploy functionality filter, and DISTRO setting

login
register
mail settings
Submitter Dongxiao Xu
Date March 24, 2012, 11:49 a.m.
Message ID <cover.1332589589.git.dongxiao.xu@intel.com>
Download mbox
Permalink /patch/24463/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix

Comments

Dongxiao Xu - March 24, 2012, 11:49 a.m.
Hi Richard,

This is the third pull request for Hob bug fixes, please help to review and pull.

Changes from v2:
1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.

Thanks,
Dongxiao

The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:

  Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix

Dongxiao Xu (9):
  Hob: Remove unnecessary PARSE_BBFILES command
  Hob: Cleanup for hobeventhandler.py
  Hob: Initial an empty label in recipeselectionpage.py
  Hob: Change the Hob initialization process
  Hob: Fix the workaround to get image types
  Hob: Add a supported image type "vmdk"
  Hob: runqemu and deployment functionality filter
  Hob: Set empty DISTRO if "defaultsetup" is selected
  Hob: Avoid getting TMPDIR in hardcode

 lib/bb/ui/crumbs/builder.py             |   23 +++++--
 lib/bb/ui/crumbs/hobeventhandler.py     |   94 ++++++++++++++-----------------
 lib/bb/ui/crumbs/hobwidget.py           |    1 +
 lib/bb/ui/crumbs/imagedetailspage.py    |   44 +++++++++++----
 lib/bb/ui/crumbs/recipeselectionpage.py |    2 +-
 lib/bb/ui/hob.py                        |    2 -
 6 files changed, 94 insertions(+), 72 deletions(-)
Richard Purdie - March 25, 2012, 11:07 a.m.
On Sat, 2012-03-24 at 19:49 +0800, Dongxiao Xu wrote:
> Hi Richard,
> 
> This is the third pull request for Hob bug fixes, please help to review and pull.
> 
> Changes from v2:
> 1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
> 2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.
> 
> Thanks,
> Dongxiao
> 
> The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:
> 
>   Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
> 
> Dongxiao Xu (9):
>   Hob: Remove unnecessary PARSE_BBFILES command
>   Hob: Cleanup for hobeventhandler.py
>   Hob: Initial an empty label in recipeselectionpage.py
>   Hob: Change the Hob initialization process
>   Hob: Fix the workaround to get image types
>   Hob: Add a supported image type "vmdk"
>   Hob: runqemu and deployment functionality filter
>   Hob: Set empty DISTRO if "defaultsetup" is selected
>   Hob: Avoid getting TMPDIR in hardcode

Merged to master, thanks.

I do have some concerns around the "runqemu and deployment functionality
filter" in that I'd prefer it if we treated the
RUNNABLE_MACHINE_PATTERNS as a proper regexp and matched it against
MACHINE rather than the image name. I'd prefer to see if behave like
COMPATIBLE_MACHINE for example.

This is a detail we can fix in subsequent patches though.

Cheers,

Richard
Dongxiao Xu - March 26, 2012, 2:38 a.m.
On Sun, 2012-03-25 at 12:07 +0100, Richard Purdie wrote:
> On Sat, 2012-03-24 at 19:49 +0800, Dongxiao Xu wrote:
> > Hi Richard,
> > 
> > This is the third pull request for Hob bug fixes, please help to review and pull.
> > 
> > Changes from v2:
> > 1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
> > 2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.
> > 
> > Thanks,
> > Dongxiao
> > 
> > The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:
> > 
> >   Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)
> > 
> > are available in the git repository at:
> >   git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
> >   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
> > 
> > Dongxiao Xu (9):
> >   Hob: Remove unnecessary PARSE_BBFILES command
> >   Hob: Cleanup for hobeventhandler.py
> >   Hob: Initial an empty label in recipeselectionpage.py
> >   Hob: Change the Hob initialization process
> >   Hob: Fix the workaround to get image types
> >   Hob: Add a supported image type "vmdk"
> >   Hob: runqemu and deployment functionality filter
> >   Hob: Set empty DISTRO if "defaultsetup" is selected
> >   Hob: Avoid getting TMPDIR in hardcode
> 
> Merged to master, thanks.
> 
> I do have some concerns around the "runqemu and deployment functionality
> filter" in that I'd prefer it if we treated the
> RUNNABLE_MACHINE_PATTERNS as a proper regexp and matched it against
> MACHINE rather than the image name. I'd prefer to see if behave like
> COMPATIBLE_MACHINE for example.

We can change the RUNNABLE_MACHINE_PATTERNS to be regexp style, but
maybe we still need to match it with image name, since we will have two
ways to access to the image details page:
1) Through a normal build, where we are able to get the MACHINE
variable.
2) Through clicking "My images" button and load an already built image,
from which we could not get the MACHINE variable but only image name.

BTW, to implement the filter functionality, we still have a pending
patch for OE-Core that is not in master yet, see:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dxu4/hob-bugfix-oecore&id=10968f8c0cf425011983ef7e0fe4c14b7da5ef74

Thanks,
Dongxiao

> 
> This is a detail we can fix in subsequent patches though.
> 
> Cheers,
> 
> Richard
>
Richard Purdie - March 26, 2012, 10:57 a.m.
On Mon, 2012-03-26 at 10:38 +0800, Xu, Dongxiao wrote:
> On Sun, 2012-03-25 at 12:07 +0100, Richard Purdie wrote:
> > On Sat, 2012-03-24 at 19:49 +0800, Dongxiao Xu wrote:
> > > Hi Richard,
> > > 
> > > This is the third pull request for Hob bug fixes, please help to review and pull.
> > > 
> > > Changes from v2:
> > > 1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
> > > 2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.
> > > 
> > > Thanks,
> > > Dongxiao
> > > 
> > > The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:
> > > 
> > >   Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)
> > > 
> > > are available in the git repository at:
> > >   git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
> > >   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
> > > 
> > > Dongxiao Xu (9):
> > >   Hob: Remove unnecessary PARSE_BBFILES command
> > >   Hob: Cleanup for hobeventhandler.py
> > >   Hob: Initial an empty label in recipeselectionpage.py
> > >   Hob: Change the Hob initialization process
> > >   Hob: Fix the workaround to get image types
> > >   Hob: Add a supported image type "vmdk"
> > >   Hob: runqemu and deployment functionality filter
> > >   Hob: Set empty DISTRO if "defaultsetup" is selected
> > >   Hob: Avoid getting TMPDIR in hardcode
> > 
> > Merged to master, thanks.
> > 
> > I do have some concerns around the "runqemu and deployment functionality
> > filter" in that I'd prefer it if we treated the
> > RUNNABLE_MACHINE_PATTERNS as a proper regexp and matched it against
> > MACHINE rather than the image name. I'd prefer to see if behave like
> > COMPATIBLE_MACHINE for example.
> 
> We can change the RUNNABLE_MACHINE_PATTERNS to be regexp style, but
> maybe we still need to match it with image name, since we will have two
> ways to access to the image details page:
> 1) Through a normal build, where we are able to get the MACHINE
> variable.
> 2) Through clicking "My images" button and load an already built image,
> from which we could not get the MACHINE variable but only image name.

Ok, that is a good point, thanks.

Can we reliably extract the machine name from the image name? I'm
thinking if regexps are involved they could use the start/end markers (^
$) which could get confusing if its matching the whole image name...

> BTW, to implement the filter functionality, we still have a pending
> patch for OE-Core that is not in master yet, see:
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dxu4/hob-bugfix-oecore&id=10968f8c0cf425011983ef7e0fe4c14b7da5ef74

That is on my to merge list, thanks.

Richard
Dongxiao Xu - March 27, 2012, 12:45 a.m.
On Mon, 2012-03-26 at 11:57 +0100, Richard Purdie wrote:
> On Mon, 2012-03-26 at 10:38 +0800, Xu, Dongxiao wrote:
> > On Sun, 2012-03-25 at 12:07 +0100, Richard Purdie wrote:
> > > On Sat, 2012-03-24 at 19:49 +0800, Dongxiao Xu wrote:
> > > > Hi Richard,
> > > > 
> > > > This is the third pull request for Hob bug fixes, please help to review and pull.
> > > > 
> > > > Changes from v2:
> > > > 1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
> > > > 2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.
> > > > 
> > > > Thanks,
> > > > Dongxiao
> > > > 
> > > > The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:
> > > > 
> > > >   Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)
> > > > 
> > > > are available in the git repository at:
> > > >   git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
> > > >   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
> > > > 
> > > > Dongxiao Xu (9):
> > > >   Hob: Remove unnecessary PARSE_BBFILES command
> > > >   Hob: Cleanup for hobeventhandler.py
> > > >   Hob: Initial an empty label in recipeselectionpage.py
> > > >   Hob: Change the Hob initialization process
> > > >   Hob: Fix the workaround to get image types
> > > >   Hob: Add a supported image type "vmdk"
> > > >   Hob: runqemu and deployment functionality filter
> > > >   Hob: Set empty DISTRO if "defaultsetup" is selected
> > > >   Hob: Avoid getting TMPDIR in hardcode
> > > 
> > > Merged to master, thanks.
> > > 
> > > I do have some concerns around the "runqemu and deployment functionality
> > > filter" in that I'd prefer it if we treated the
> > > RUNNABLE_MACHINE_PATTERNS as a proper regexp and matched it against
> > > MACHINE rather than the image name. I'd prefer to see if behave like
> > > COMPATIBLE_MACHINE for example.
> > 
> > We can change the RUNNABLE_MACHINE_PATTERNS to be regexp style, but
> > maybe we still need to match it with image name, since we will have two
> > ways to access to the image details page:
> > 1) Through a normal build, where we are able to get the MACHINE
> > variable.
> > 2) Through clicking "My images" button and load an already built image,
> > from which we could not get the MACHINE variable but only image name.
> 
> Ok, that is a good point, thanks.
> 
> Can we reliably extract the machine name from the image name? I'm
> thinking if regexps are involved they could use the start/end markers (^
> $) which could get confusing if its matching the whole image name...

That makes sense, and it is also what I am going to change for the
current code.


> 
> > BTW, to implement the filter functionality, we still have a pending
> > patch for OE-Core that is not in master yet, see:
> > 
> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dxu4/hob-bugfix-oecore&id=10968f8c0cf425011983ef7e0fe4c14b7da5ef74
> 
> That is on my to merge list, thanks.

Thanks,
Dongxiao
> 
> Richard
>