Patchwork [bitbake-devel,4/9] lib/bb/ui/crumbs/builddetailspage: fix label on 'Back' button

login
register
mail settings
Submitter Joshua Lock
Date March 24, 2012, 12:23 a.m.
Message ID <06186ae494fd5e84bbf27e07f45bcaed9e6fbdd6.1332545580.git.josh@linux.intel.com>
Download mbox | patch
Permalink /patch/24411/
State Accepted
Commit e0d598b454c01303a0ea9503feef3ce6f1ed1d69
Headers show

Comments

Joshua Lock - March 24, 2012, 12:23 a.m.
The buttons taking the user back to image configuration should be prefixed
with '<<'.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/builddetailspage.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Dongxiao Xu - March 24, 2012, 12:32 a.m.
On Fri, 2012-03-23 at 17:23 -0700, Joshua Lock wrote:
> The buttons taking the user back to image configuration should be prefixed
> with '<<'.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>

Acked-by: Dongxiao Xu <dongxiao.xu@intel.com>

> ---
>  lib/bb/ui/crumbs/builddetailspage.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/bb/ui/crumbs/builddetailspage.py b/lib/bb/ui/crumbs/builddetailspage.py
> index 5f1524f..59d5525 100755
> --- a/lib/bb/ui/crumbs/builddetailspage.py
> +++ b/lib/bb/ui/crumbs/builddetailspage.py
> @@ -80,7 +80,7 @@ class BuildDetailsPage (HobPage):
>          self.builder.handler.build.model.connect_after("row-changed", self.scroll_to_present_row, self.scrolled_view_build.get_vadjustment(), self.build_tv)
>  
>          self.button_box = gtk.HBox(False, 6)
> -        self.back_button = HobAltButton("Back to image configuration")
> +        self.back_button = HobAltButton("<< Back to image configuration")
>          self.back_button.connect("clicked", self.back_button_clicked_cb)
>          self.button_box.pack_start(self.back_button, expand=False, fill=False)
>

Patch

diff --git a/lib/bb/ui/crumbs/builddetailspage.py b/lib/bb/ui/crumbs/builddetailspage.py
index 5f1524f..59d5525 100755
--- a/lib/bb/ui/crumbs/builddetailspage.py
+++ b/lib/bb/ui/crumbs/builddetailspage.py
@@ -80,7 +80,7 @@  class BuildDetailsPage (HobPage):
         self.builder.handler.build.model.connect_after("row-changed", self.scroll_to_present_row, self.scrolled_view_build.get_vadjustment(), self.build_tv)
 
         self.button_box = gtk.HBox(False, 6)
-        self.back_button = HobAltButton("Back to image configuration")
+        self.back_button = HobAltButton("<< Back to image configuration")
         self.back_button.connect("clicked", self.back_button_clicked_cb)
         self.button_box.pack_start(self.back_button, expand=False, fill=False)