Patchwork python: Add tk to DEPENDS

login
register
mail settings
Submitter Andrei Gherzan
Date March 23, 2012, 11:14 p.m.
Message ID <1332544467-2071-1-git-send-email-andrei@gherzan.ro>
Download mbox | patch
Permalink /patch/24383/
State New
Headers show

Comments

Andrei Gherzan - March 23, 2012, 11:14 p.m.
This is needed for _tkinter python module.

[YOCTO #1937]

Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
 meta/recipes-devtools/python/python_2.7.2.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andreas Oberritter - March 23, 2012, 11:33 p.m.
On 24.03.2012 00:14, Andrei Gherzan wrote:
> This is needed for _tkinter python module.
> 
> [YOCTO #1937]
> 
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
>  meta/recipes-devtools/python/python_2.7.2.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/python/python_2.7.2.bb b/meta/recipes-devtools/python/python_2.7.2.bb
> index cb0a1d5..6969929 100644
> --- a/meta/recipes-devtools/python/python_2.7.2.bb
> +++ b/meta/recipes-devtools/python/python_2.7.2.bb
> @@ -1,5 +1,5 @@
>  require python.inc
> -DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib"
> +DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib tk"

Andrei,

this breaks builds without x11:

ERROR: Nothing PROVIDES 'virtual/libx11' (but .../meta-oe/recipes-devtools/tcltk/tk_8.5.8.bb DEPENDS on or otherwise requires it)
ERROR: libx11-diet PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
ERROR: libx11-trim PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
ERROR: libx11 PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
ERROR: libx11-nativesdk PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
ERROR: Required build target 'tk' has no buildable providers.
Missing or unbuildable dependency chain was: ['tk', 'virtual/libx11']

Besides that, tk is not part of OE-core.

Regards,
Andreas
Andreas Oberritter - March 23, 2012, 11:39 p.m.
On 24.03.2012 00:33, Andreas Oberritter wrote:
> On 24.03.2012 00:14, Andrei Gherzan wrote:
>> This is needed for _tkinter python module.
>>
>> [YOCTO #1937]
>>
>> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
>> ---
>>  meta/recipes-devtools/python/python_2.7.2.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/python/python_2.7.2.bb b/meta/recipes-devtools/python/python_2.7.2.bb
>> index cb0a1d5..6969929 100644
>> --- a/meta/recipes-devtools/python/python_2.7.2.bb
>> +++ b/meta/recipes-devtools/python/python_2.7.2.bb
>> @@ -1,5 +1,5 @@
>>  require python.inc
>> -DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib"
>> +DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib tk"
> 
> Andrei,
> 
> this breaks builds without x11:
> 
> ERROR: Nothing PROVIDES 'virtual/libx11' (but .../meta-oe/recipes-devtools/tcltk/tk_8.5.8.bb DEPENDS on or otherwise requires it)
> ERROR: libx11-diet PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
> ERROR: libx11-trim PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
> ERROR: libx11 PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
> ERROR: libx11-nativesdk PROVIDES virtual/libx11 but was skipped: 'x11' not in DISTRO_FEATURES
> ERROR: Required build target 'tk' has no buildable providers.
> Missing or unbuildable dependency chain was: ['tk', 'virtual/libx11']
> 
> Besides that, tk is not part of OE-core.

Sorry, I missed your patch adding tk to OE-core. Please disregard my
previous message. xproto doesn't seem to depend on libx11, so the
DEPENDS listed in your patch should be OK.

Regards,
Andreas

Patch

diff --git a/meta/recipes-devtools/python/python_2.7.2.bb b/meta/recipes-devtools/python/python_2.7.2.bb
index cb0a1d5..6969929 100644
--- a/meta/recipes-devtools/python/python_2.7.2.bb
+++ b/meta/recipes-devtools/python/python_2.7.2.bb
@@ -1,5 +1,5 @@ 
 require python.inc
-DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib"
+DEPENDS = "python-native bzip2 db gdbm openssl readline sqlite3 zlib tk"
 DEPENDS_sharprom = "python-native db readline zlib gdbm openssl"
 PR = "${INC_PR}.8"