From patchwork Thu Mar 22 23:31:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel,0/9] Hob changes to match visual design Date: Thu, 22 Mar 2012 23:31:05 -0000 From: Joshua Lock X-Patchwork-Id: 24205 Message-Id: To: bitbake-devel@lists.openembedded.org Here's another set of patches to move Hob closer to the proposed design. * Replace HobXpmLabelButtonBox with a new HobImageButton, this is a gtk.Button subclass which is modelled after the buttons in gnome-disk-utility, where Belen informs me the buttons on the main page for Layers, Recipes and Packages are modelled after. Since the first submission of this patch I've also ensured the buttons use an alternative icon for the hover state per Shane's suggestion. * Various tweaks to the LayerSelectionDialog per feedback from design: - title is Layers - add hover state icon to add button - follow Gnome HIG and only use a close button * Per feedback on my last pull request and the design document changes to the HobAltButton - bold text which uses a pale blue colour per visual design - modified 'Back to image configuration' buttons to have << prefix * Unify implementation of the primary action button as a shared widget HobButton and make use of it where we currently set up an orange button (this class should be used for all primary buttons in a future patch). Cheers, Joshua The following changes since commit 96e235a151fa04f5a15cd8b46f50a5852e2ba739: Hob: Revert interfaces of callbacks for layer_button, view_recipes_button, and view_packages_button. (2012-03-22 14:36:04 +0000) are available in the git repository at: git://github.com/incandescant/bitbake josh/hob https://github.com/incandescant/bitbake/tree/josh/hob git://git.yoctoproject.org/poky-contrib josh/hob http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob Joshua Lock (9): lib/bb/ui/icons: add new icons for use in Hob, autocrop some existing ones lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButton lib/bb/ui/crumbs/builder: only show a close button on the Layer Selector lib/bb/ui/crumbs/hig: tweak 'Add Layer' button per visual design lib/bb/ui/crumbs: add colour for HobAltButton per visual design lib/bb/ui/crumbs: fix 'Back to image configuration' alt button text lib/bb/ui/crumbs/hobwidget: add HobButton widget for the primary action lib/bb/ui/crumbs: make use of HobButton for existing primary action buttons lib/bb/ui/crumbs/builder: change dialogue title to Layers lib/bb/ui/crumbs/builder.py | 5 +- lib/bb/ui/crumbs/hig.py | 27 +++-- lib/bb/ui/crumbs/hobcolor.py | 1 + lib/bb/ui/crumbs/hobwidget.py | 148 ++++++++++++++++----------- lib/bb/ui/crumbs/imageconfigurationpage.py | 52 ++++------ lib/bb/ui/crumbs/imagedetailspage.py | 11 +-- lib/bb/ui/crumbs/packageselectionpage.py | 13 +-- lib/bb/ui/crumbs/recipeselectionpage.py | 13 +-- lib/bb/ui/icons/indicators/add-hover.png | Bin 0 -> 1212 bytes lib/bb/ui/icons/indicators/remove-hover.png | Bin 0 -> 2809 bytes lib/bb/ui/icons/layers/layers_hover.png | Bin 5390 -> 5257 bytes lib/bb/ui/icons/packages/packages_hover.png | Bin 7308 -> 7121 bytes lib/bb/ui/icons/recipe/recipe_hover.png | Bin 5003 -> 4866 bytes 13 files changed, 136 insertions(+), 134 deletions(-) create mode 100644 lib/bb/ui/icons/indicators/add-hover.png create mode 100644 lib/bb/ui/icons/indicators/remove-hover.png Signed-off-by: Joshua Lock