Patchwork busybox: enable eject

login
register
mail settings
Submitter Andreas Müller
Date March 22, 2012, 11:10 a.m.
Message ID <1332414627-6512-2-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/24131/
State Rejected
Headers show

Comments

Andreas Müller - March 22, 2012, 11:10 a.m.
In xfce-environment ejecting USB-memory stick caused:
Error starting job: Failed to execute child process "eject" (No such file or directory)

run-tested with angstrom/meta-oe environment on overo
---
 meta/recipes-core/busybox/busybox-1.19.4/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.4.bb        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Paul Eggleton - March 22, 2012, 2:41 p.m.
On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
> In xfce-environment ejecting USB-memory stick caused:
> Error starting job: Failed to execute child process "eject" (No such file or
> directory)

Not to say we shouldn't merge this, but I'm concerned if this continues we 
could end up with busybox in the default configuration creeping up in size as 
more and more features get enabled.

Where do we draw the line?

Cheers,
Paul
McClintock Matthew-B29882 - March 22, 2012, 2:44 p.m.
On Thu, Mar 22, 2012 at 9:41 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
>> In xfce-environment ejecting USB-memory stick caused:
>> Error starting job: Failed to execute child process "eject" (No such file or
>> directory)
>
> Not to say we shouldn't merge this, but I'm concerned if this continues we
> could end up with busybox in the default configuration creeping up in size as
> more and more features get enabled.
>
> Where do we draw the line?

Perhaps it should be the default settings? We always have 'bitbake -c
menuconfig busybox' for the "small" cases?

-M
Koen Kooi - March 22, 2012, 2:48 p.m.
Op 22 mrt. 2012, om 15:41 heeft Paul Eggleton het volgende geschreven:

> On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
>> In xfce-environment ejecting USB-memory stick caused:
>> Error starting job: Failed to execute child process "eject" (No such file or
>> directory)
> 
> Not to say we shouldn't merge this, but I'm concerned if this continues we 
> could end up with busybox in the default configuration creeping up in size as 
> more and more features get enabled.
> 
> Where do we draw the line?

FWIW, the standalone 'eject' is in meta-oe, so xfce could RDEPEND on that. I don't have a strong opinion on the busybox patch. 

regards,

Koen

Patch

diff --git a/meta/recipes-core/busybox/busybox-1.19.4/defconfig b/meta/recipes-core/busybox/busybox-1.19.4/defconfig
index 372d7b5..279933b 100644
--- a/meta/recipes-core/busybox/busybox-1.19.4/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.4/defconfig
@@ -669,7 +669,7 @@  CONFIG_DC=y
 # CONFIG_DEVFSD_VERBOSE is not set
 # CONFIG_FEATURE_DEVFS is not set
 # CONFIG_DEVMEM is not set
-# CONFIG_EJECT is not set
+CONFIG_EJECT=y
 # CONFIG_FEATURE_EJECT_SCSI is not set
 # CONFIG_FBSPLASH is not set
 # CONFIG_FLASHCP is not set
diff --git a/meta/recipes-core/busybox/busybox_1.19.4.bb b/meta/recipes-core/busybox/busybox_1.19.4.bb
index dff616d..01dd9be 100644
--- a/meta/recipes-core/busybox/busybox_1.19.4.bb
+++ b/meta/recipes-core/busybox/busybox_1.19.4.bb
@@ -1,5 +1,5 @@ 
 require busybox.inc
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \