Patchwork [bitbake-devel] runningbuild.py: fix goggle ui

login
register
mail settings
Submitter Eric BENARD
Date March 21, 2012, 3:44 p.m.
Message ID <1332344691-24973-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/24021/
State New
Headers show

Comments

Eric BENARD - March 21, 2012, 3:44 p.m.
without this fix I get the following error once the build is finished :
Traceback (most recent call last):
  File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 287, in handle_event
    pbar.set_text(event.msg)
AttributeError: 'ProgressBar' object has no attribute 'set_text'

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 lib/bb/ui/crumbs/runningbuild.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Joshua Lock - March 22, 2012, 1:10 a.m.
On 21/03/12 08:44, Eric Bénard wrote:
> without this fix I get the following error once the build is finished :
> Traceback (most recent call last):
>    File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
>      build.handle_event (event, pbar)
>    File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 287, in handle_event
>      pbar.set_text(event.msg)
> AttributeError: 'ProgressBar' object has no attribute 'set_text'
>
> Signed-off-by: Eric Bénard<eric@eukrea.com>
Signed-off-by: Joshua Lock <josh@linux.intel.com>

> ---
>   lib/bb/ui/crumbs/runningbuild.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
> index 4c3fe2c..343eac9 100644
> --- a/lib/bb/ui/crumbs/runningbuild.py
> +++ b/lib/bb/ui/crumbs/runningbuild.py
> @@ -284,7 +284,7 @@ class RunningBuild (gobject.GObject):
>               # handle when the build is finished
>               self.emit("build-complete")
>               if pbar:
> -                pbar.set_text(event.msg)
> +                pbar.set_title(event.msg)
>
>           elif isinstance(event, bb.command.CommandFailed):
>               if event.error.startswith("Exited with"):

Patch

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 4c3fe2c..343eac9 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -284,7 +284,7 @@  class RunningBuild (gobject.GObject):
             # handle when the build is finished
             self.emit("build-complete")
             if pbar:
-                pbar.set_text(event.msg)
+                pbar.set_title(event.msg)
 
         elif isinstance(event, bb.command.CommandFailed):
             if event.error.startswith("Exited with"):