From patchwork Thu Jan 13 15:44:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacob Kroon X-Patchwork-Id: 2395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EA3C433EF for ; Thu, 13 Jan 2022 15:44:34 +0000 (UTC) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web09.10509.1642088673325974488 for ; Thu, 13 Jan 2022 07:44:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bPKre2GL; spf=pass (domain: gmail.com, ip: 209.85.167.44, mailfrom: jacob.kroon@gmail.com) Received: by mail-lf1-f44.google.com with SMTP id x22so20851109lfd.10 for ; Thu, 13 Jan 2022 07:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to:from :subject; bh=SKZGZQUHUJYO+glgWQO64N+J+jbqEG/I8jLeEh9xV3Y=; b=bPKre2GLCBbA2w1nQlphMaae3zmjbgFSCI4lSDcekXwUgDwMZeHHpxA+MHYqgh01cy hKO2i9dIBkSsxQzIxGuuda+LbFXncUwpg78anILU9QiN0bZt4Ul7CwW2eAz0RBhHdOd6 d3oiGyfZpToAc4bFocq43c1Z8Jyx35Iu0XBFBLfSwukCsZO6Qo55Ymvhih94egVjbcEu cxLmgvQ3cTRczlD1HjI8Kh+Vdbk9mZcbHSxI4hoMuLE7KT/m4DYkeXRPoEwVU0bQDkUq 35OZZDyEr0OcdK2ChlEHAmQcA3xDSVRzLSeXiJBWDfYYwWGMIC0HiG9TpiPzKM/pJ0cq w0HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject; bh=SKZGZQUHUJYO+glgWQO64N+J+jbqEG/I8jLeEh9xV3Y=; b=4bDV4xnBeddidr2cAxDSuXKcoczgar4fwnNP6dlzmMJof9Yk7CwzaZUiudf7YQ0wnm SKhGUcJ6gjWedJKp5S3P/QGIzx4FAIXBTwOGh3hk6ysNnQo/BxtYyiYeON+KLKra4uY6 XrU/Pf8Bv8GXjohJxiox8+U64f/05lsJKsiJdEXSYHL1G6WJU96JDaMZn/Dclb6QzClK xtpqU/FwK4yAe7mT3UZnA4JrQwj4b4ETIP1ySp9So2TRnCagUnP14h5drND4cgwMtj+3 Dowi/JRUAkX8SCgGhRCYRgSdfQb4RczZK/IvedpmW/K8LQCtEwCYbpbZJpI+wDVmS92q OO3Q== X-Gm-Message-State: AOAM531MiywaNbHquZC8sES0rRPUIoy9fQlQONYIctcn+9oqxcdrVFxF +0RheAJfZ42rLRr+s4jTFnMIfmcBAfc= X-Google-Smtp-Source: ABdhPJxDLzdUU+wnvvR9vecuyAn17lxhLCYPbu7jaq3Samj/D1Gzcz4oK5+d7mCJ2LI9Mn8GUKSu9g== X-Received: by 2002:a05:6512:acd:: with SMTP id n13mr2790864lfu.283.1642088671301; Thu, 13 Jan 2022 07:44:31 -0800 (PST) Received: from [192.168.10.175] (37-247-29-68.customers.ownit.se. [37.247.29.68]) by smtp.gmail.com with ESMTPSA id x22sm301104ljp.128.2022.01.13.07.44.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 07:44:30 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 16:44:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-US To: OE Core mailing list From: Jacob Kroon Subject: Zero umask when unpacking sstate packages List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 13 Jan 2022 15:44:34 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/160525 Hi, I often see this diff churn in my buildistory for shadow-native (and similar issues with icedtea7-native from meta-java): -drwxr-xr-x - - 40 ./var/spool/mail +drwxrwxr-x - - 40 ./var/spool/mail One can reproduce it with: # bitbake -c cleansstate shadow-native && \ bitbake shadow-native && \ bitbake -c clean shadow-native && \ bitbake shadow-native I see that the sstate package contains the correct permissions for 'mail', 775. So it would seem to me that it is the unpacking from sstate that strips the group write permission. Testing with the attached patch and the problem goes away. Is something like this the correct solution ? Jacob From dcebf2977cb6bdc5198ab13272cf358c9ecd6b32 Mon Sep 17 00:00:00 2001 From: Jacob Kroon Date: Thu, 13 Jan 2022 16:31:47 +0100 Subject: [PATCH] sstate.bbclass: Zero umask when unpacking from sstate cache Signed-off-by: Jacob Kroon --- meta/classes/sstate.bbclass | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass index 645377fdd8..0c32387f43 100644 --- a/meta/classes/sstate.bbclass +++ b/meta/classes/sstate.bbclass @@ -793,7 +793,9 @@ pstaging_fetch[vardepsexclude] += "SRCPV" def sstate_setscene(d): shared_state = sstate_state_fromvars(d) + omask = os.umask(0) accelerate = sstate_installpkg(shared_state, d) + os.umask(omask) if not accelerate: bb.fatal("No suitable staging package found")