| Submitter | Joshua Lock |
|---|---|
| Date | March 21, 2012, 12:15 a.m. |
| Message ID | <cover.1332288516.git.josh@linux.intel.com> |
| Download | mbox |
| Permalink | /patch/23933/ |
| State | New |
| Headers | show |
Pull-request
git://github.com/incandescant/bitbake josh/hobComments
On 20/03/12 17:15, Joshua Lock wrote: > All, > > Here are some tweaks to the Hob GUI. > > Firstly I include a tweaked version of my recent LayerSelectionDialog patch, this > includes Dongxiao's suggestion to use a prelight on the clickable pixbuf in the > TreeView. Sadly on Ubuntu this isn't hugely noticable as the remove icon is > largely whitespace. > We should be able to replace the stock icon with a custom one soon. I've received an asset to use for the remove icon so will send an updated pull request later today. Please disregard this series. Thanks, Joshua
All, Here are some tweaks to the Hob GUI. Firstly I include a tweaked version of my recent LayerSelectionDialog patch, this includes Dongxiao's suggestion to use a prelight on the clickable pixbuf in the TreeView. Sadly on Ubuntu this isn't hugely noticable as the remove icon is largely whitespace. We should be able to replace the stock icon with a custom one soon. The second patch adds a clear button to the search entry in HobNoteBook, per a suggestion I made whilst reviewing that code. The remaining three patches are for the PersistentTooltip widget: 1) Tweak borders so that the button is aligned with the tooltip edge but the label remains inside padding. 2) Fix colours on darker Gtk+ themes, such as those used in Ubuntu Unity. 3) Fix whitespace to match the rest of BitBake (I had accidentally used tabs rather than 4 spaces per indent). Cheers, Joshua The following changes since commit b7b7c768761d205bc5a60922ff709c9c184d4158: utils: Add split_version function for splitting a version into its components (2012-03-20 14:37:16 +0000) are available in the git repository at: git://github.com/incandescant/bitbake josh/hob https://github.com/incandescant/bitbake/tree/josh/hob git://git.yoctoproject.org/poky-contrib josh/hob http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob Joshua Lock (5): ui/crumbs/hig: make the layer selection dialogue more closely match design ui/crumbs/hobwidget: add clear icon to search entries in HobNotebook ui/crumbs/persistenttooltip: tweak borders ui/crumbs/persistenttooltip: fix colours on darker themes ui/crumbs/persistenttooltip: fix whitespace lib/bb/ui/crumbs/hig.py | 97 ++++++++++--- lib/bb/ui/crumbs/hobwidget.py | 19 ++- lib/bb/ui/crumbs/persistenttooltip.py | 244 ++++++++++++++++++--------------- 3 files changed, 221 insertions(+), 139 deletions(-)