Patchwork [meta-oe,4/4] udev: remove 175

login
mail settings
Submitter Koen Kooi
Date March 20, 2012, 5:18 p.m.
Message ID <1332263919-19283-4-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/23909/
State New, archived
Headers show

Comments

Koen Kooi - March 20, 2012, 5:18 p.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta-oe/recipes-core/udev/udev_175.bb |   91 ---------------------------------
 1 files changed, 0 insertions(+), 91 deletions(-)
 delete mode 100644 meta-oe/recipes-core/udev/udev_175.bb
Andreas Müller - March 21, 2012, 7:49 a.m.
On Tue, Mar 20, 2012 at 6:18 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta-oe/recipes-core/udev/udev_175.bb |   91 ---------------------------------
>  1 files changed, 0 insertions(+), 91 deletions(-)
>  delete mode 100644 meta-oe/recipes-core/udev/udev_175.bb
>
> diff --git a/meta-oe/recipes-core/udev/udev_175.bb b/meta-oe/recipes-core/udev/udev_175.bb
> deleted file mode 100644
> index e14dde2..0000000
> --- a/meta-oe/recipes-core/udev/udev_175.bb
> +++ /dev/null
> @@ -1,91 +0,0 @@
> -DESCRIPTION = "udev is a daemon which dynamically creates and removes device nodes from \
> -/dev/, handles hotplug events and loads drivers at boot time. It replaces \
> -the hotplug package and requires a kernel not older than 2.6.27."
> -
> -DEFAULT_PREFERENCE = "-1"
> -
> -# udev 169 and up require kernel 2.6.36 for ARM:
> -# http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=67a77c8bf299f6264f001677becd056316ebce2f
> -
> -LICENSE = "GPLv2+ & LGPLv2.1+"
> -LICENSE_${PN} = "GPLv2+"
> -LICENSE_libudev = "LGPLv2.1+"
> -LICENSE_libgudev = "LGPLv2.1+"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> -                    file://libudev/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
> -                    file://extras/gudev/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343"
> -
> -# Needed for udev-extras
> -DEPENDS = "gperf-native usbutils acl glib-2.0"
> -
> -PR = "r1"
> -
> -# 6f410b81aa6d588b03ae795c9b76468591ef7efa -> 175 tag
> -SRCREV = "6f410b81aa6d588b03ae795c9b76468591ef7efa"
> -
> -# version specific SRC_URI
> -SRC_URI = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git \
> -           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \
> -           file://gtk-doc.make"
> -
> -# generic SRC_URI
> -SRC_URI += " \
> -       file://touchscreen.rules \
> -       file://modprobe.rules \
> -"
> -
> -S = "${WORKDIR}/git"
> -
> -# Machine specific udev rules should be in their own recipe that ${PN} can add to RRECOMMENDS
> -
> -inherit autotools
> -
> -EXTRA_OECONF += " \
> -                  --disable-introspection \
> -                  --with-pci-ids-path=/usr/share/misc \
> -                  ac_cv_file__usr_share_pci_ids=no \
> -                  ac_cv_file__usr_share_hwdata_pci_ids=no \
> -                  ac_cv_file__usr_share_misc_pci_ids=yes \
> -                  --sbindir=${base_sbindir} \
> -                  --libexecdir=${base_libdir}/udev \
> -                  --with-rootlibdir=${base_libdir} \
> -                  --disable-gtk-doc-html \
> -                  --with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> -"
> -
> -do_configure_prepend() {
> -       cp ${WORKDIR}/gtk-doc.make ${S}
> -}
> -
> -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit"
> -
> -FILES_${PN}-systemd = "${base_libdir}/systemd"
> -RDEPENDS_${PN}-systemd += "udev"
> -
> -FILES_libudev = "${base_libdir}/libudev.so.*"
> -FILES_libgudev = "${base_libdir}/libgudev*.so.*"
> -
> -FILES_udev-utils = "${bindir}/udevinfo ${bindir}/udevtest ${base_sbindir}/udevadm"
> -
> -RPROVIDES_${PN} = "hotplug"
> -FILES_${PN} += "${usrbindir}/* ${usrsbindir}/udevd"
> -FILES_${PN}-dbg += "${usrbindir}/.debug ${usrsbindir}/.debug"
> -RDEPENDS_${PN} += "module-init-tools-depmod udev-utils"
> -RRECOMMENDS_${PN} += "util-linux-blkid"
> -
> -# udev installs binaries under $(udev_prefix)/lib/udev, even if ${libdir}
> -# is ${prefix}/lib64
> -FILES_${PN} += "/lib/udev*"
> -FILES_${PN}-dbg += "/lib/udev/.debug"
> -
> -FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
> -RDEPENDS_${PN}-consolekit += "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
> -
> -do_install () {
> -       install -d ${D}${usrsbindir} \
> -                  ${D}${sbindir}
> -       oe_runmake 'DESTDIR=${D}' INSTALL=install install
> -
> -       install -m 0644 ${WORKDIR}/*.rules         ${D}${sysconfdir}/udev/rules.d/
> -}
> -
Could we wait with this until libertas works with udev >= 177 [1]?

Andreas

[1] http://www.spinics.net/lists/linux-wireless/msg85541.html
Koen Kooi - March 21, 2012, 12:10 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 21-03-12 08:49, Andreas Müller schreef:
> On Tue, Mar 20, 2012 at 6:18 PM, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>

> Could we wait with this until libertas works with udev >= 177 [1]?

I'd rather live with the breakage so people are motivated to fix the
libertas driver. Unless someone commits to maintain the 175 recipe, of course.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQIcBAEBAgAGBQJPacUXAAoJEHZqAkdh1vT6cUoP/jjErwsT8gHBgqWLmR/eIYZF
6PjELnqpmnucA6Vpz6YWXFcc9OFZexHHS0gi4r4onuvBXDYJimo4Uu8u/9NxG/7b
BJwExp84OsBUAopSErcuPR5IghZrP26UhErr3D6A9mfsp7Y0oEpqY2+xK9OQ4ErY
umryoniuAZJCt0qfFj0J1wR/hQyFrPFWZ+0WUT1QtXAys5j9Z5ezw8eO9yfdEH6l
16kzcDkauG+T4nik8ZE6N8fzJjyrUPT+FI5X9qWpY5MmNmp5NuIat1wBUA7ML0wF
MOIHTYpxTSINmlATq1wmIDkXf7butVj0EIPwotvmfWVS65SsWWxTc+sQg9m2POic
p0OW+V8hYu3gY7CT5zdhYTEClaglrRrc5FvA24RqhgvH6RQwbgHBQnimWH1qrT6Q
XLNE1RWdA1ljViRDVwWS1OBxmKXM96oUENWIpB067gta65OKGbLBNy6v++gdtchW
+WEQ9yCOfceVVkpUYCIVTotPgstMsU2dQIx8jLYf04onOgv8+2YuemPnnPJOsrjP
wF1MKEkpYFQFLBTOYF63i2QleJwIbqPmgJzkfpnKo3ZoVbOrjGqUC3bdosPqvmpx
T4EfJi8C4EXE9bOx1XklJ6ghptEBB6PD+BzXL2rpbx75QrLE9Ma2lrYF05JR3Sq3
7AYFa0wg8ivHmAf6ArY0
=w7zk
-----END PGP SIGNATURE-----
Otavio Salvador - March 21, 2012, 12:18 p.m.
On Wed, Mar 21, 2012 at 09:10, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Could we wait with this until libertas works with udev >= 177 [1]?
>
> I'd rather live with the breakage so people are motivated to fix the
> libertas driver. Unless someone commits to maintain the 175 recipe, of course.

I don't see any strong reason to boost the move as AFAIK everything is
working fine with 175 for now. So I'd say to keep on it until libertas
is made working with the newer udev version.
Koen Kooi - March 21, 2012, 12:48 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 21-03-12 13:18, Otavio Salvador schreef:
> On Wed, Mar 21, 2012 at 09:10, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>>> Could we wait with this until libertas works with udev >= 177 [1]?
>> 
>> I'd rather live with the breakage so people are motivated to fix the 
>> libertas driver. Unless someone commits to maintain the 175 recipe, of
>> course.
> 
> I don't see any strong reason to boost the move as AFAIK everything is 
> working fine with 175 for now. So I'd say to keep on it until libertas is
> made working with the newer udev version.

Are you committing to maintaining the udev 175 recipe?

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQIcBAEBAgAGBQJPac40AAoJEHZqAkdh1vT6E4kP/3AK1OqHfWqf0WcYuxPPeBVW
5MXJU0/gqhaNxcrm/GJNXHHuTgEfXMcW25gXNyjDxhh/THoqHY/z6kOARys8pOMp
+Y5bn+oO0K4+MnbqTEm3iMRlb8T8GrQddQ9+7f6cXN11AD2LZL///k+sr4ofPWkY
OZAOW7rgLzfk2Z2bSLI2uYaCsAygW4J58qb5h6dOxjckhZPqmaD/RB9XPyf8yCcd
gdskYXMMUvQ/LCRn8ob+SomZkCIoohPYCyMHtCT1FVkvHS0kJJCS+BfnCwWouwh5
KbRiY4QIkl8r/jLuc4XqofE9sz+gdIcYKTdRsFSkXi4CFgZq1zAJrp/wj3gbsEfY
Hri4YqE+I7+Z7PNKdLxW0TUyRP7PEqlXiJgIf2/ElNPNNd6lN7F7OE1o7uv0g5Wg
ILDjRlt8Ws+d2SYeZbpnjQS5u/RYk58+H0yUFBsPoptrMZ7Qy0FGcZhRuY4C5YIK
ZZFA0rfON3Dt3A+1V1oaEeOo9a3PNLSMcE5vint1BPe/iYBVHGdp+SQ03GNfugRt
0w5Qt/zlg9HFPTiiIinKrSpdSJB6Uw7MOh6Iu8DQJodpkufY3vdcOD8LjiqEzGbV
loHvjKOOzEU5LuwpbR+hXHHlQAYcmTJWDwFLSNcyGAefOCUmSEA2+qTIIjpDtByn
LO+kqAj4WzPmZ7DpQKh2
=I6Se
-----END PGP SIGNATURE-----
Otavio Salvador - March 21, 2012, 12:56 p.m.
On Wed, Mar 21, 2012 at 09:48, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> I don't see any strong reason to boost the move as AFAIK everything is
>> working fine with 175 for now. So I'd say to keep on it until libertas is
>> made working with the newer udev version.
>
> Are you committing to maintaining the udev 175 recipe?

I am commiting to nack an move to 18X if it has feature regressions as
it is the case.
Frans Meulenbroeks - March 21, 2012, 12:56 p.m.
2012/3/21 Koen Kooi <koen@dominion.thruhere.net>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 21-03-12 08:49, Andreas Müller schreef:
>> On Tue, Mar 20, 2012 at 6:18 PM, Koen Kooi <koen@dominion.thruhere.net>
>> wrote:
>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>
>> Could we wait with this until libertas works with udev >= 177 [1]?
>
> I'd rather live with the breakage so people are motivated to fix the
> libertas driver. Unless someone commits to maintain the 175 recipe, of course.
>
> regards,
>
> Koen

Interesting point of view.
I still recall the flak someone gave when some breakage occurred
because some old recipes were removed....
Seems the world is improving after all ;-)

Have fun!
Frans

PS: not volunteering to maintain 175; My products are still perfectly
happy with static device tables.

Patch

diff --git a/meta-oe/recipes-core/udev/udev_175.bb b/meta-oe/recipes-core/udev/udev_175.bb
deleted file mode 100644
index e14dde2..0000000
--- a/meta-oe/recipes-core/udev/udev_175.bb
+++ /dev/null
@@ -1,91 +0,0 @@ 
-DESCRIPTION = "udev is a daemon which dynamically creates and removes device nodes from \
-/dev/, handles hotplug events and loads drivers at boot time. It replaces \
-the hotplug package and requires a kernel not older than 2.6.27."
-
-DEFAULT_PREFERENCE = "-1"
-
-# udev 169 and up require kernel 2.6.36 for ARM: 
-# http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=67a77c8bf299f6264f001677becd056316ebce2f
-
-LICENSE = "GPLv2+ & LGPLv2.1+"
-LICENSE_${PN} = "GPLv2+"
-LICENSE_libudev = "LGPLv2.1+"
-LICENSE_libgudev = "LGPLv2.1+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
-                    file://libudev/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
-                    file://extras/gudev/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343"
-
-# Needed for udev-extras
-DEPENDS = "gperf-native usbutils acl glib-2.0"
-
-PR = "r1"
-
-# 6f410b81aa6d588b03ae795c9b76468591ef7efa -> 175 tag
-SRCREV = "6f410b81aa6d588b03ae795c9b76468591ef7efa"
-
-# version specific SRC_URI
-SRC_URI = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git \
-           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \
-           file://gtk-doc.make"
-
-# generic SRC_URI
-SRC_URI += " \
-       file://touchscreen.rules \
-       file://modprobe.rules \
-"
-
-S = "${WORKDIR}/git"
-
-# Machine specific udev rules should be in their own recipe that ${PN} can add to RRECOMMENDS
-
-inherit autotools
-
-EXTRA_OECONF += " \
-                  --disable-introspection \
-                  --with-pci-ids-path=/usr/share/misc \
-                  ac_cv_file__usr_share_pci_ids=no \
-                  ac_cv_file__usr_share_hwdata_pci_ids=no \
-                  ac_cv_file__usr_share_misc_pci_ids=yes \
-                  --sbindir=${base_sbindir} \
-                  --libexecdir=${base_libdir}/udev \
-                  --with-rootlibdir=${base_libdir} \
-                  --disable-gtk-doc-html \
-                  --with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
-"
-
-do_configure_prepend() {
-	cp ${WORKDIR}/gtk-doc.make ${S}
-}
-
-PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit"
-
-FILES_${PN}-systemd = "${base_libdir}/systemd"
-RDEPENDS_${PN}-systemd += "udev"
-
-FILES_libudev = "${base_libdir}/libudev.so.*"
-FILES_libgudev = "${base_libdir}/libgudev*.so.*"
-
-FILES_udev-utils = "${bindir}/udevinfo ${bindir}/udevtest ${base_sbindir}/udevadm"
-
-RPROVIDES_${PN} = "hotplug"
-FILES_${PN} += "${usrbindir}/* ${usrsbindir}/udevd"
-FILES_${PN}-dbg += "${usrbindir}/.debug ${usrsbindir}/.debug"
-RDEPENDS_${PN} += "module-init-tools-depmod udev-utils"
-RRECOMMENDS_${PN} += "util-linux-blkid"
-
-# udev installs binaries under $(udev_prefix)/lib/udev, even if ${libdir}
-# is ${prefix}/lib64
-FILES_${PN} += "/lib/udev*"
-FILES_${PN}-dbg += "/lib/udev/.debug"
- 
-FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
-RDEPENDS_${PN}-consolekit += "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
-
-do_install () {
-	install -d ${D}${usrsbindir} \
-		   ${D}${sbindir}
-	oe_runmake 'DESTDIR=${D}' INSTALL=install install
-
-	install -m 0644 ${WORKDIR}/*.rules         ${D}${sysconfdir}/udev/rules.d/
-}
-