Patchwork [bitbake-devel,1/6] ui/crumbs/hig: use close rather than OK for dismis button

login
register
mail settings
Submitter Joshua Lock
Date March 20, 2012, 12:18 a.m.
Message ID <bad78ebcdbf59381ce93021afbc005b3f50438a4.1332202341.git.josh@linux.intel.com>
Download mbox | patch
Permalink /patch/23829/
State Accepted
Commit 7b28ed7dfa59d9e7cec662159113a03633f8bb36
Headers show

Comments

Joshua Lock - March 20, 2012, 12:18 a.m.
Dialogue buttons should have descriptive names

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/hig.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Dongxiao Xu - March 20, 2012, 5:33 a.m.
On Mon, 2012-03-19 at 17:18 -0700, Joshua Lock wrote:
> Dialogue buttons should have descriptive names
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
Acked-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  lib/bb/ui/crumbs/hig.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
> index 67cc94e..849d7c9 100644
> --- a/lib/bb/ui/crumbs/hig.py
> +++ b/lib/bb/ui/crumbs/hig.py
> @@ -838,7 +838,7 @@ class LayerSelectionDialog (CrumbsDialog):
>                  layer_store.append([path])
>                  return
>              dialog = CrumbsMessageDialog(parent, lbl)
> -            dialog.add_button(gtk.STOCK_OK, gtk.RESPONSE_OK)
> +            dialog.add_button(gtk.STOCK_CLOSE, gtk.RESPONSE_OK)
>              response = dialog.run()
>              dialog.destroy()
>

Patch

diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
index 67cc94e..849d7c9 100644
--- a/lib/bb/ui/crumbs/hig.py
+++ b/lib/bb/ui/crumbs/hig.py
@@ -838,7 +838,7 @@  class LayerSelectionDialog (CrumbsDialog):
                 layer_store.append([path])
                 return
             dialog = CrumbsMessageDialog(parent, lbl)
-            dialog.add_button(gtk.STOCK_OK, gtk.RESPONSE_OK)
+            dialog.add_button(gtk.STOCK_CLOSE, gtk.RESPONSE_OK)
             response = dialog.run()
             dialog.destroy()